[v2] Add 8-byte wide AMD flash support, partial interleaving

[Qemu-devel] [PATCH v2 0/1] Add 8-byte wide AMD flash support, partial interleaving

Mike Nawrocki posted 1 patch 6 years, 5 months ago

Diff against v1 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171110202556.28541-1-michael.nawrocki@gtri.gatech.edu

Test checkpatch passed

Test docker passed

Test ppc passed

Test s390x passed

There is a newer version of this series

hw/block/pflash_cfi02.c | 491 +++++++++++++++++++++++++++++++++---------------
1 file changed, 337 insertions(+), 154 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/1] Add 8-byte wide AMD flash support, partial interleaving

Posted by Mike Nawrocki 6 years, 5 months ago

This patch set does a few things. First, it switches the AMD CFI flash MMIO
operations from the old MMIO API to the new one. Second, it enables 8-byte wide
flash arrays. Finally, it adds flash interleaving using the "device-width" and
"max-device-width" properties, using the same interface as pflash_cfi01.c. Much
of the code was taken and adapted from that file.

Version 1 of the patch set changed the flash register function (and all
usages), version 2 localizes changes to the pflash_cfi02.c file.

Mike Nawrocki (1):
  Add 8-byte access, interleaving to AMD CFI devices

 hw/block/pflash_cfi02.c | 491 +++++++++++++++++++++++++++++++++---------------
 1 file changed, 337 insertions(+), 154 deletions(-)

-- 
2.14.2

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/1] Add 8-byte wide AMD flash support, partial interleaving

Posted by Paolo Bonzini 6 years, 5 months ago

On 10/11/2017 21:25, Mike Nawrocki wrote:
> This patch set does a few things. First, it switches the AMD CFI flash MMIO
> operations from the old MMIO API to the new one. Second, it enables 8-byte wide
> flash arrays. Finally, it adds flash interleaving using the "device-width" and
> "max-device-width" properties, using the same interface as pflash_cfi01.c. Much
> of the code was taken and adapted from that file.

This unfortunately is not a patch set, it's a patch that does many
things.  You should split it in three parts, according to the three
things you've mentioned in the message above.

Paolo

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/1] Add 8-byte wide AMD flash support, partial interleaving

Posted by Michael Nawrocki 6 years, 5 months ago

On 11/10/2017 06:12 PM, Paolo Bonzini wrote:
> On 10/11/2017 21:25, Mike Nawrocki wrote:
>> This patch set does a few things. First, it switches the AMD CFI flash MMIO
>> operations from the old MMIO API to the new one. Second, it enables 8-byte wide
>> flash arrays. Finally, it adds flash interleaving using the "device-width" and
>> "max-device-width" properties, using the same interface as pflash_cfi01.c. Much
>> of the code was taken and adapted from that file.
> 
> This unfortunately is not a patch set, it's a patch that does many
> things.  You should split it in three parts, according to the three
> things you've mentioned in the message above.
> 
> Paolo
> 

Sure, no problem. I'll get the split patch set out shortly.

Thanks,
Mike