[v1] machine: Polish -machine xxx,help

[Qemu-devel] [PATCH qemu] machine: Polish -machine xxx,help

Alexey Kardashevskiy posted 1 patch 6 years, 5 months ago

Diff against v2
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171026012910.45515-1-aik@ozlabs.ru

Test checkpatch passed

Test docker passed

Test s390x passed

There is a newer version of this series

hw/core/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH qemu] machine: Polish -machine xxx,help

Posted by Alexey Kardashevskiy 6 years, 5 months ago

The "-machine xxx,help" prints kernel-irqchip possible values as
"OnOffSplit", this adds separators to the printed line.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---

aik@fstn1-p1:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep kernel-irqchip

Was:
pseries-2.11.kernel-irqchip=OnOffSplit (Configure KVM in-kernel irqchip)

Now:
pseries-2.11.kernel-irqchip=On|Off|Split (Configure KVM in-kernel irqchip)
---
 hw/core/machine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/core/machine.c b/hw/core/machine.c
index 36c2fb069c..ea89cf706e 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -506,7 +506,7 @@ static void machine_class_init(ObjectClass *oc, void *data)
     object_class_property_set_description(oc, "accel",
         "Accelerator list", &error_abort);
 
-    object_class_property_add(oc, "kernel-irqchip", "OnOffSplit",
+    object_class_property_add(oc, "kernel-irqchip", "On|Off|Split",
         NULL, machine_set_kernel_irqchip,
         NULL, NULL, &error_abort);
     object_class_property_set_description(oc, "kernel-irqchip",
-- 
2.11.0

Re: [Qemu-devel] [PATCH qemu] machine: Polish -machine xxx,help

Posted by Alexey Kardashevskiy 6 years, 5 months ago

On 26/10/17 12:29, Alexey Kardashevskiy wrote:
> The "-machine xxx,help" prints kernel-irqchip possible values as
> "OnOffSplit", this adds separators to the printed line.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> 
> aik@fstn1-p1:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep kernel-irqchip
> 
> Was:
> pseries-2.11.kernel-irqchip=OnOffSplit (Configure KVM in-kernel irqchip)
> 
> Now:
> pseries-2.11.kernel-irqchip=On|Off|Split (Configure KVM in-kernel irqchip)
> ---
>  hw/core/machine.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 36c2fb069c..ea89cf706e 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -506,7 +506,7 @@ static void machine_class_init(ObjectClass *oc, void *data)
>      object_class_property_set_description(oc, "accel",
>          "Accelerator list", &error_abort);
>  
> -    object_class_property_add(oc, "kernel-irqchip", "OnOffSplit",
> +    object_class_property_add(oc, "kernel-irqchip", "On|Off|Split",


ah, only small case letters are allowed actually, v2 with "on|off|split" is
coming.


>          NULL, machine_set_kernel_irqchip,
>          NULL, NULL, &error_abort);
>      object_class_property_set_description(oc, "kernel-irqchip",
> 


-- 
Alexey