1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help

Alexey Kardashevskiy posted 1 patch 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171026014139.46221-1-aik@ozlabs.ru
Test checkpatch passed
Test docker passed
Test s390x passed
hw/core/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help
Posted by Alexey Kardashevskiy 6 years, 6 months ago 
The "-machine xxx,help" prints kernel-irqchip possible values as
"OnOffSplit", this adds separators to the printed line.

Also, since only lower case letters are specified in qapi/common.json,
this changes the letter cases too.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---

aik@fstn1-p1:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep kernel-irqchip

Was:
pseries-2.11.kernel-irqchip=OnOffSplit (Configure KVM in-kernel irqchip)

Now:
pseries-2.11.kernel-irqchip=on|off|split (Configure KVM in-kernel irqchip)
---
 hw/core/machine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/core/machine.c b/hw/core/machine.c
index 36c2fb069c..bd3db14e12 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -506,7 +506,7 @@ static void machine_class_init(ObjectClass *oc, void *data)
     object_class_property_set_description(oc, "accel",
         "Accelerator list", &error_abort);
 
-    object_class_property_add(oc, "kernel-irqchip", "OnOffSplit",
+    object_class_property_add(oc, "kernel-irqchip", "on|off|split",
         NULL, machine_set_kernel_irqchip,
         NULL, NULL, &error_abort);
     object_class_property_set_description(oc, "kernel-irqchip",
-- 
2.11.0
Re: [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help
Posted by Alexey Kardashevskiy 6 years, 4 months ago 
On 26/10/17 12:41, Alexey Kardashevskiy wrote:
> The "-machine xxx,help" prints kernel-irqchip possible values as
> "OnOffSplit", this adds separators to the printed line.
> 
> Also, since only lower case letters are specified in qapi/common.json,
> this changes the letter cases too.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

ping?


> ---
> 
> aik@fstn1-p1:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep kernel-irqchip
> 
> Was:
> pseries-2.11.kernel-irqchip=OnOffSplit (Configure KVM in-kernel irqchip)
> 
> Now:
> pseries-2.11.kernel-irqchip=on|off|split (Configure KVM in-kernel irqchip)
> ---
>  hw/core/machine.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 36c2fb069c..bd3db14e12 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -506,7 +506,7 @@ static void machine_class_init(ObjectClass *oc, void *data)
>      object_class_property_set_description(oc, "accel",
>          "Accelerator list", &error_abort);
>  
> -    object_class_property_add(oc, "kernel-irqchip", "OnOffSplit",
> +    object_class_property_add(oc, "kernel-irqchip", "on|off|split",
>          NULL, machine_set_kernel_irqchip,
>          NULL, NULL, &error_abort);
>      object_class_property_set_description(oc, "kernel-irqchip",
> 


-- 
Alexey
Re: [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help
Posted by Alexey Kardashevskiy 6 years, 3 months ago 
On 15/12/17 15:47, Alexey Kardashevskiy wrote:
> On 26/10/17 12:41, Alexey Kardashevskiy wrote:
>> The "-machine xxx,help" prints kernel-irqchip possible values as
>> "OnOffSplit", this adds separators to the printed line.
>>
>> Also, since only lower case letters are specified in qapi/common.json,
>> this changes the letter cases too.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> 
> ping?


anyone?

> 
> 
>> ---
>>
>> aik@fstn1-p1:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep kernel-irqchip
>>
>> Was:
>> pseries-2.11.kernel-irqchip=OnOffSplit (Configure KVM in-kernel irqchip)
>>
>> Now:
>> pseries-2.11.kernel-irqchip=on|off|split (Configure KVM in-kernel irqchip)
>> ---
>>  hw/core/machine.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/core/machine.c b/hw/core/machine.c
>> index 36c2fb069c..bd3db14e12 100644
>> --- a/hw/core/machine.c
>> +++ b/hw/core/machine.c
>> @@ -506,7 +506,7 @@ static void machine_class_init(ObjectClass *oc, void *data)
>>      object_class_property_set_description(oc, "accel",
>>          "Accelerator list", &error_abort);
>>  
>> -    object_class_property_add(oc, "kernel-irqchip", "OnOffSplit",
>> +    object_class_property_add(oc, "kernel-irqchip", "on|off|split",
>>          NULL, machine_set_kernel_irqchip,
>>          NULL, NULL, &error_abort);
>>      object_class_property_set_description(oc, "kernel-irqchip",
>>
> 
> 


-- 
Alexey
Re: [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help
Posted by Alexey Kardashevskiy 6 years, 2 months ago 
On 29/01/18 16:03, Alexey Kardashevskiy wrote:
> On 15/12/17 15:47, Alexey Kardashevskiy wrote:
>> On 26/10/17 12:41, Alexey Kardashevskiy wrote:
>>> The "-machine xxx,help" prints kernel-irqchip possible values as
>>> "OnOffSplit", this adds separators to the printed line.
>>>
>>> Also, since only lower case letters are specified in qapi/common.json,
>>> this changes the letter cases too.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>
>> ping?
> 
> 
> anyone?

Let's try trivial list now :)


> 
>>
>>
>>> ---
>>>
>>> aik@fstn1-p1:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep kernel-irqchip
>>>
>>> Was:
>>> pseries-2.11.kernel-irqchip=OnOffSplit (Configure KVM in-kernel irqchip)
>>>
>>> Now:
>>> pseries-2.11.kernel-irqchip=on|off|split (Configure KVM in-kernel irqchip)
>>> ---
>>>  hw/core/machine.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/hw/core/machine.c b/hw/core/machine.c
>>> index 36c2fb069c..bd3db14e12 100644
>>> --- a/hw/core/machine.c
>>> +++ b/hw/core/machine.c
>>> @@ -506,7 +506,7 @@ static void machine_class_init(ObjectClass *oc, void *data)
>>>      object_class_property_set_description(oc, "accel",
>>>          "Accelerator list", &error_abort);
>>>  
>>> -    object_class_property_add(oc, "kernel-irqchip", "OnOffSplit",
>>> +    object_class_property_add(oc, "kernel-irqchip", "on|off|split",
>>>          NULL, machine_set_kernel_irqchip,
>>>          NULL, NULL, &error_abort);
>>>      object_class_property_set_description(oc, "kernel-irqchip",
>>>
>>
>>
> 
> 


-- 
Alexey
Re: [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help
Posted by Alexey Kardashevskiy 6 years, 2 months ago 
On 02/02/18 13:45, Alexey Kardashevskiy wrote:
> On 29/01/18 16:03, Alexey Kardashevskiy wrote:
>> On 15/12/17 15:47, Alexey Kardashevskiy wrote:
>>> On 26/10/17 12:41, Alexey Kardashevskiy wrote:
>>>> The "-machine xxx,help" prints kernel-irqchip possible values as
>>>> "OnOffSplit", this adds separators to the printed line.
>>>>
>>>> Also, since only lower case letters are specified in qapi/common.json,
>>>> this changes the letter cases too.
>>>>
>>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>>
>>> ping?
>>
>>
>> anyone?
> 
> Let's try trivial list now :)


And ping again :)


> 
> 
>>
>>>
>>>
>>>> ---
>>>>
>>>> aik@fstn1-p1:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep kernel-irqchip
>>>>
>>>> Was:
>>>> pseries-2.11.kernel-irqchip=OnOffSplit (Configure KVM in-kernel irqchip)
>>>>
>>>> Now:
>>>> pseries-2.11.kernel-irqchip=on|off|split (Configure KVM in-kernel irqchip)
>>>> ---
>>>>  hw/core/machine.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/hw/core/machine.c b/hw/core/machine.c
>>>> index 36c2fb069c..bd3db14e12 100644
>>>> --- a/hw/core/machine.c
>>>> +++ b/hw/core/machine.c
>>>> @@ -506,7 +506,7 @@ static void machine_class_init(ObjectClass *oc, void *data)
>>>>      object_class_property_set_description(oc, "accel",
>>>>          "Accelerator list", &error_abort);
>>>>  
>>>> -    object_class_property_add(oc, "kernel-irqchip", "OnOffSplit",
>>>> +    object_class_property_add(oc, "kernel-irqchip", "on|off|split",
>>>>          NULL, machine_set_kernel_irqchip,
>>>>          NULL, NULL, &error_abort);
>>>>      object_class_property_set_description(oc, "kernel-irqchip",
>>>>
>>>
>>>
>>
>>
> 
> 


-- 
Alexey
Re: [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help
Posted by Michael Tokarev 6 years, 2 months ago 
26.10.2017 04:41, Alexey Kardashevskiy пишет:
> The "-machine xxx,help" prints kernel-irqchip possible values as
> "OnOffSplit", this adds separators to the printed line.

Applied to -trivial, thanks, and please excuse us for the very long delay!

/mjt

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.