[Qemu-devel] [Qemu-PPC] [PATCH 0/3] target/ppc: Implement radix mmu debug functions

Suraj Jitindar Singh posted 3 patches 6 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170703061948.18220-1-sjitindarsingh@gmail.com
Test FreeBSD passed
Test checkpatch passed
Test docker passed
Test s390x passed
target/ppc/mmu-radix64.c | 116 +++++++++++++++++++++++++++++++++++++++++------
target/ppc/mmu-radix64.h |   2 +
target/ppc/mmu_helper.c  |   5 +-
3 files changed, 107 insertions(+), 16 deletions(-)
[Qemu-devel] [Qemu-PPC] [PATCH 0/3] target/ppc: Implement radix mmu debug functions
Posted by Suraj Jitindar Singh 6 years, 9 months ago
When the radix mmu emulation code was implemented the translation
debug functions were left as a todo.

Implement the functions ppc_radix64_get_phys_page_debug() and 
ppc_radix64_dump_level() to translate a single address and dump all the 
address translations respectively.

This functionality is already implemented for the hash mmu.

A slight refactor of the radix mmu emulation code was necessary to enable
the debug code to call existing functions.

Suraj Jitindar Singh (3):
  target/ppc: Refactor tcg radix mmu code
  target/ppc: Add debug function for radix mmu translation
  target/ppc: Add debug function to dump radix mmu translations

 target/ppc/mmu-radix64.c | 116 +++++++++++++++++++++++++++++++++++++++++------
 target/ppc/mmu-radix64.h |   2 +
 target/ppc/mmu_helper.c  |   5 +-
 3 files changed, 107 insertions(+), 16 deletions(-)

-- 
2.9.4


Re: [Qemu-devel] [Qemu-PPC] [PATCH 0/3] target/ppc: Implement radix mmu debug functions
Posted by David Gibson 6 years, 9 months ago
On Mon, Jul 03, 2017 at 04:19:45PM +1000, Suraj Jitindar Singh wrote:
> When the radix mmu emulation code was implemented the translation
> debug functions were left as a todo.
> 
> Implement the functions ppc_radix64_get_phys_page_debug() and 
> ppc_radix64_dump_level() to translate a single address and dump all the 
> address translations respectively.
> 
> This functionality is already implemented for the hash mmu.
> 
> A slight refactor of the radix mmu emulation code was necessary to enable
> the debug code to call existing functions.

I've applied 1&2 to ppc-for-2.10.  I have some further comments on 3/3.

> 
> Suraj Jitindar Singh (3):
>   target/ppc: Refactor tcg radix mmu code
>   target/ppc: Add debug function for radix mmu translation
>   target/ppc: Add debug function to dump radix mmu translations
> 
>  target/ppc/mmu-radix64.c | 116 +++++++++++++++++++++++++++++++++++++++++------
>  target/ppc/mmu-radix64.h |   2 +
>  target/ppc/mmu_helper.c  |   5 +-
>  3 files changed, 107 insertions(+), 16 deletions(-)
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson