target/sh4: misc FPU fixes and optimizations

[Qemu-devel] [PATCH v2 0/5] target/sh4: misc FPU fixes and optimizations

Aurelien Jarno posted 5 patches 6 years, 9 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170702202814.27793-1-aurelien@aurel32.net

Test FreeBSD passed

Test checkpatch passed

Test docker passed

Test s390x passed

target/sh4/helper.h    | 11 +++-----
target/sh4/op_helper.c | 71 ++++++++++++++++----------------------------------
target/sh4/translate.c | 30 ++++++++-------------
3 files changed, 37 insertions(+), 75 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/5] target/sh4: misc FPU fixes and optimizations

Posted by Aurelien Jarno 6 years, 9 months ago

This patchset should fix the bug#1701821 reported by Bruno Haible,
which makes the gnulib testsuite to fail for single precision libm
tests or for tests relying on unordered comparisons.

It also fixes an inversion of cause and flag bits in the FPSCR register,
which is unrelated with the reported bug. It also improves a bit the fneg
and fcmp instructions.

Aurelien Jarno (5):
  target/sh4: do not check for PR bit for fabs instruction
  target/sh4: fix FPU unorderered compare
  target/sh4: fix FPSCR cause vs flag inversion
  target/sh4: do not use a helper to implement fneg
  target/sh4: return result of fcmp using TCG

 target/sh4/helper.h    | 11 +++-----
 target/sh4/op_helper.c | 71 ++++++++++++++++----------------------------------
 target/sh4/translate.c | 30 ++++++++-------------
 3 files changed, 37 insertions(+), 75 deletions(-)

-- 
2.11.0

Re: [Qemu-devel] [PATCH v2 0/5] target/sh4: misc FPU fixes and optimizations

Posted by Bruno Haible 6 years, 9 months ago

Aurelien Jarno wrote:
> This patchset should fix the bug#1701821 reported by Bruno Haible,
> which makes the gnulib testsuite to fail for single precision libm
> tests or for tests relying on unordered comparisons.

It does fix it: All floating-point related tests of gnulib now pass with
qemu-sh4. Thanks!

Bruno

Re: [Qemu-devel] [PATCH v2 0/5] target/sh4: misc FPU fixes and optimizations

Posted by Richard Henderson 6 years, 9 months ago

On 07/02/2017 01:28 PM, Aurelien Jarno wrote:
> This patchset should fix the bug#1701821 reported by Bruno Haible,
> which makes the gnulib testsuite to fail for single precision libm
> tests or for tests relying on unordered comparisons.
> 
> It also fixes an inversion of cause and flag bits in the FPSCR register,
> which is unrelated with the reported bug. It also improves a bit the fneg
> and fcmp instructions.
> 
> Aurelien Jarno (5):
>    target/sh4: do not check for PR bit for fabs instruction
>    target/sh4: fix FPU unorderered compare
>    target/sh4: fix FPSCR cause vs flag inversion
>    target/sh4: do not use a helper to implement fneg
>    target/sh4: return result of fcmp using TCG
> 
>   target/sh4/helper.h    | 11 +++-----
>   target/sh4/op_helper.c | 71 ++++++++++++++++----------------------------------
>   target/sh4/translate.c | 30 ++++++++-------------
>   3 files changed, 37 insertions(+), 75 deletions(-)
> 

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~