1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH 0/2] qobject coccinelle followups

Eric Blake posted 2 patches 8 years, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170609152017.7286-1-eblake@redhat.com
Test FreeBSD passed
Test checkpatch passed
Test docker passed
Test s390x passed
There is a newer version of this series
qemu-img.c                       | 2 +-
scripts/coccinelle/qobject.cocci | 6 ++++++
2 files changed, 7 insertions(+), 1 deletion(-)
[Qemu-devel] [PATCH 0/2] qobject coccinelle followups
Posted by Eric Blake 8 years, 3 months ago 
Inspired by https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg02505.html

Surprisingly, the updated script didn't find any existing longhand
use as candidates for QDECREF() (our last such use was cleaned up
as a side effect, in commit b72fe9e), but it DID find another straggler
missed in commit 579cf1d1.

Eric Blake (2):
  qobject: Update coccinelle script to catch Q{INC,DEC}REF
  qobject: Catch another straggler for use of qdict_put_str()

 qemu-img.c                       | 2 +-
 scripts/coccinelle/qobject.cocci | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

-- 
2.9.4
Re: [Qemu-devel] [PATCH 0/2] qobject coccinelle followups
Posted by Michael Tokarev 8 years, 2 months ago 
09.06.2017 18:20, Eric Blake wrote:
> Inspired by https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg02505.html
> 
> Surprisingly, the updated script didn't find any existing longhand
> use as candidates for QDECREF() (our last such use was cleaned up
> as a side effect, in commit b72fe9e), but it DID find another straggler
> missed in commit 579cf1d1.
> 
> Eric Blake (2):
>   qobject: Update coccinelle script to catch Q{INC,DEC}REF
>   qobject: Catch another straggler for use of qdict_put_str()

Applied to -trivial, thanks!

/mjt
Re: [Qemu-devel] [PATCH 0/2] qobject coccinelle followups
Posted by Eric Blake 8 years, 2 months ago 
On 07/12/2017 08:35 AM, Michael Tokarev wrote:
> 09.06.2017 18:20, Eric Blake wrote:
>> Inspired by https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg02505.html
>>
>> Surprisingly, the updated script didn't find any existing longhand
>> use as candidates for QDECREF() (our last such use was cleaned up
>> as a side effect, in commit b72fe9e), but it DID find another straggler
>> missed in commit 579cf1d1.
>>
>> Eric Blake (2):
>>   qobject: Update coccinelle script to catch Q{INC,DEC}REF
>>   qobject: Catch another straggler for use of qdict_put_str()
> 
> Applied to -trivial, thanks!

Markus has taken v2 of these patches through his qapi-next tree:
https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg05589.html

so you can drop this v1 from -trivial

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org
Re: [Qemu-devel] [PATCH 0/2] qobject coccinelle followups
Posted by Markus Armbruster 8 years, 2 months ago 
Eric Blake <eblake@redhat.com> writes:

> On 07/12/2017 08:35 AM, Michael Tokarev wrote:
>> 09.06.2017 18:20, Eric Blake wrote:
>>> Inspired by https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg02505.html
>>>
>>> Surprisingly, the updated script didn't find any existing longhand
>>> use as candidates for QDECREF() (our last such use was cleaned up
>>> as a side effect, in commit b72fe9e), but it DID find another straggler
>>> missed in commit 579cf1d1.
>>>
>>> Eric Blake (2):
>>>   qobject: Update coccinelle script to catch Q{INC,DEC}REF
>>>   qobject: Catch another straggler for use of qdict_put_str()
>> 
>> Applied to -trivial, thanks!
>
> Markus has taken v2 of these patches through his qapi-next tree:
> https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg05589.html
>
> so you can drop this v1 from -trivial

I've dragged my feet on the pull request in the hope of still adding a
few patches of my own.  Figure I better put them into the next one.

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.