[v2] qobject coccinelle followups

[Qemu-devel] [PATCH v2 0/2] qobject coccinelle followups

Eric Blake posted 2 patches 6 years, 9 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170624181008.25497-1-eblake@redhat.com

Test FreeBSD passed

Test checkpatch passed

Test docker passed

Test s390x passed

monitor.c                        | 2 +-
qemu-img.c                       | 2 +-
scripts/coccinelle/qobject.cocci | 6 ++++++
3 files changed, 8 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/2] qobject coccinelle followups

Posted by Eric Blake 6 years, 9 months ago

v1 was here:
https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg02589.html

Since then:
- reorder the series
- add R-b on patch 1
- patch 2 updated to catch recent introduction of longhand usage

Eric Blake (2):
  qobject: Catch another straggler for use of qdict_put_str()
  qobject: Update coccinelle script to catch Q{INC,DEC}REF

 monitor.c                        | 2 +-
 qemu-img.c                       | 2 +-
 scripts/coccinelle/qobject.cocci | 6 ++++++
 3 files changed, 8 insertions(+), 2 deletions(-)

-- 
2.9.4

Re: [Qemu-devel] [PATCH v2 0/2] qobject coccinelle followups

Posted by Markus Armbruster 6 years, 9 months ago

Eric Blake <eblake@redhat.com> writes:

> v1 was here:
> https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg02589.html
>
> Since then:
> - reorder the series
> - add R-b on patch 1

You missed Max's.  Adding it in my tree.

> - patch 2 updated to catch recent introduction of longhand usage

Applied to qapi-next.  Thanks!

Re: [Qemu-devel] [PATCH v2 0/2] qobject coccinelle followups

Posted by Stefan Hajnoczi 6 years, 9 months ago

On Sat, Jun 24, 2017 at 12:10:06PM -0600, Eric Blake wrote:
> v1 was here:
> https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg02589.html
> 
> Since then:
> - reorder the series
> - add R-b on patch 1
> - patch 2 updated to catch recent introduction of longhand usage
> 
> Eric Blake (2):
>   qobject: Catch another straggler for use of qdict_put_str()
>   qobject: Update coccinelle script to catch Q{INC,DEC}REF
> 
>  monitor.c                        | 2 +-
>  qemu-img.c                       | 2 +-
>  scripts/coccinelle/qobject.cocci | 6 ++++++
>  3 files changed, 8 insertions(+), 2 deletions(-)
> 
> -- 
> 2.9.4
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>