3 easy-to-fix clang warnings, 1 error code fixed

[Qemu-devel] [PATCH v2 0/4] 3 easy-to-fix clang warnings, 1 error code fixed

Philippe Mathieu-Daudé posted 4 patches 7 years ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170407222016.15308-1-f4bug@amsat.org

Test checkpatch passed

Test docker passed

Test s390x passed

device_tree.c                 |  1 +
hw/usb/dev-smartcard-reader.c |  5 ++++-
qga/commands-posix.c          | 11 ++++++++---
3 files changed, 13 insertions(+), 4 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/4] 3 easy-to-fix clang warnings, 1 error code fixed

Posted by Philippe Mathieu-Daudé 7 years ago

This patchset fixes three easy-to-fix unrelated clang warnings, so it was
probably better to send them separately the first time.

v2:
    - hw/usb/dev-smartcard-reader.c: The first patch was treating NULL and 0 as
      errors but those values are legal in some cases, i.e. no (virtual)
      smartcard inserted into the card reader (Gerd Hoffmann's review).
    - device_tree.c: Added Marc-André Lureau's Reviewed-by.
    - qga/commands-posix.c: Added a commit to improve failed operation, as
      suggested by Michael Roth.

Philippe Mathieu-Daudé (4):
  usb-ccid: make ccid_write_data_block() cope with null buffers
  device_tree: fix compiler warnings (clang 5)
  qga: fix compiler warnings (clang 5)
  qga: improve error handling in transfer_memory_block

 device_tree.c                 |  1 +
 hw/usb/dev-smartcard-reader.c |  5 ++++-
 qga/commands-posix.c          | 11 ++++++++---
 3 files changed, 13 insertions(+), 4 deletions(-)

-- 
2.11.0

Re: [Qemu-devel] [PATCH v2 0/4] 3 easy-to-fix clang warnings, 1 error code fixed

Posted by Michael Tokarev 7 years ago

08.04.2017 01:20, Philippe Mathieu-Daudé wrote:
> This patchset fixes three easy-to-fix unrelated clang warnings, so it was
> probably better to send them separately the first time.
> 
> v2:
>     - hw/usb/dev-smartcard-reader.c: The first patch was treating NULL and 0 as
>       errors but those values are legal in some cases, i.e. no (virtual)
>       smartcard inserted into the card reader (Gerd Hoffmann's review).
>     - device_tree.c: Added Marc-André Lureau's Reviewed-by.
>     - qga/commands-posix.c: Added a commit to improve failed operation, as
>       suggested by Michael Roth.
> 
> Philippe Mathieu-Daudé (4):
>   usb-ccid: make ccid_write_data_block() cope with null buffers
>   device_tree: fix compiler warnings (clang 5)
>   qga: fix compiler warnings (clang 5)
>   qga: improve error handling in transfer_memory_block

Applied to -trivial, thanks!

/mjt