From nobody Sun May 5 19:38:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491603791839911.4349464264777; Fri, 7 Apr 2017 15:23:11 -0700 (PDT) Received: from localhost ([::1]:52785 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwcHe-0000l1-JV for importer@patchew.org; Fri, 07 Apr 2017 18:23:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwcFl-0007vf-OK for qemu-devel@nongnu.org; Fri, 07 Apr 2017 18:21:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cwcFj-00051V-3z for qemu-devel@nongnu.org; Fri, 07 Apr 2017 18:21:13 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:35381) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cwcFi-00051M-WC; Fri, 07 Apr 2017 18:21:11 -0400 Received: by mail-qt0-x244.google.com with SMTP id r5so11572805qtb.2; Fri, 07 Apr 2017 15:21:10 -0700 (PDT) Received: from yoga.lan ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id d133sm1442146qke.9.2017.04.07.15.21.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Apr 2017 15:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=roO5S6VZ+7cwj/eu4jG7oLhUYwUiPPLY4V0rpI9ScD8=; b=OgEgL3INvwH1ve2s52yZpcZ7KDxaCDabZC6MR6EpFj163Mz3fChal44BJim7+xZd4Y O22YfbMYa1A26ftz9iMcSBXQP0dr/R7fCHeSLzakSVCTO8hrZP9hHnrm5N/dWv3R7nBu YIhbo+YqfkEj9w5Zy7sElxs+o43DAWW43a0E0LegVGqffDKROSh+ai1oZ9RBlwMn0HsJ F875HmeMKvdQfp0/QGKodfMKN6motDVnpmvs4Pjs4/ewxf+vsuzOCOYLyraKYZaxswRH YYbaabHKCvd7s79JPWPc5ed4R0QR9meadvdFkzpeUrr5OUSgGvYp96HpsjZbZApX6HxD yrEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=roO5S6VZ+7cwj/eu4jG7oLhUYwUiPPLY4V0rpI9ScD8=; b=D6WTG4clJGeIACfcb9/NlyUfmR7ZGnGOTo9jzsXuxDUlUGUG569O+0k9YEYboFN+Dg qBJIihFGlio0EHUz/x7jgU269DMMOJ473Ww0oI3QcDXYQMFRoEJz2hqUmNYXsR0PZlpS 2Ht4tLPQ9PBoZIUzbSw7H+txGhkV8T/xvULHy7knO/8byN3c3cBWh9LF2+iEvb9kV27t PixHVAAkY0j3tpDYJku41XqooB48AFYy1vI6AJDGNe8aBPSC0PQzDsopsTJ4pH+FGVdL I3oW9zrE3x3jrAqATvJpCumuqtlbXe4H8FpsMGNpeKt4pIvg5CYbvvA7JuTi5ddRmyt3 Jeuw== X-Gm-Message-State: AN3rC/7KeXmdOsVsxOFDPN1JC3VrTcNxkuoVAdIIMblCZ1LTLK3Gyzf5iA0jIlfsiGB+7g== X-Received: by 10.237.63.69 with SMTP id q5mr537208qtf.236.1491603670511; Fri, 07 Apr 2017 15:21:10 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Gerd Hoffmann , Markus Armbruster , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Fri, 7 Apr 2017 19:20:13 -0300 Message-Id: <20170407222016.15308-2-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170407222016.15308-1-f4bug@amsat.org> References: <20170407222016.15308-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH v2 1/4] usb-ccid: make ccid_write_data_block() cope with null buffers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 static code analyzer complain: hw/usb/dev-smartcard-reader.c:816:5: warning: Null pointer passed as an arg= ument to a 'nonnull' parameter memcpy(p->abData, data, len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/dev-smartcard-reader.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index 757b8b3f5a..49cb1829b5 100644 --- a/hw/usb/dev-smartcard-reader.c +++ b/hw/usb/dev-smartcard-reader.c @@ -813,7 +813,10 @@ static void ccid_write_data_block(USBCCIDState *s, uin= t8_t slot, uint8_t seq, if (p->b.bError) { DPRINTF(s, D_VERBOSE, "error %d\n", p->b.bError); } - memcpy(p->abData, data, len); + if (len) { + g_assert_nonnull(data); + memcpy(p->abData, data, len); + } ccid_reset_error_status(s); usb_wakeup(s->bulk, 0); } --=20 2.11.0 From nobody Sun May 5 19:38:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491603792917228.37048236134433; Fri, 7 Apr 2017 15:23:12 -0700 (PDT) Received: from localhost ([::1]:52786 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwcHf-0000mI-PS for importer@patchew.org; Fri, 07 Apr 2017 18:23:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwcFq-0007yM-GH for qemu-devel@nongnu.org; Fri, 07 Apr 2017 18:21:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cwcFp-00054X-MB for qemu-devel@nongnu.org; Fri, 07 Apr 2017 18:21:18 -0400 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:34602) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cwcFp-00054R-Ic; Fri, 07 Apr 2017 18:21:17 -0400 Received: by mail-qt0-x242.google.com with SMTP id x35so11506603qtc.1; Fri, 07 Apr 2017 15:21:17 -0700 (PDT) Received: from yoga.lan ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id d133sm1442146qke.9.2017.04.07.15.21.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Apr 2017 15:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=n8P/IH7BEEhbOCW+/Bn7SebjwtfiGvKFqU2HF9lfAkg=; b=X5/w6F4fNkUk5NC64RGiPiSLYqJTt1mvSBw7SQK5yPXpSfTg49scSGW6Na4eV2Wuix A/vMR9+K2BYWz6hDBrEB8KJxgtsoWrXBJYxcR2f1f6C+9+AiICFcBNaaVPidlhUSNB40 FhzzrEcJi6T5+8Nec92e5H4PVLnaSVyXIB3ER51ez1s9Lg9KI0Bj2w49K0VxKJSb0fwF cFvuIQtKPSPVGlyxTXr9jOscyEiC4ZvOFp1hweTV0yr2Ml0480vKlOYvlJdLlIaEUbPY adsWe6oa7VHaSDcIuS1EG/ZnfACk7WVa810LKezdpZngROrtM7dun+xnsEqKDBMyniWJ Gsaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=n8P/IH7BEEhbOCW+/Bn7SebjwtfiGvKFqU2HF9lfAkg=; b=Kk1qTkDI553PL80HWQ/c7nDVHlwAaZWwC7P9TV/+Ij+M20V91mhsOF72+Y/A3RAtaP q6Cse7FBVQAakVVdTQMIwWaN3TVUbNeIpTcn04bRC+Sw10BRaomkKJlUM+mahkAtkZYo jscgAbo+gxb7DTFjVve609pMls2arOIdgdJtMAzv2ixrztjZx9KAi3JAt+KBfxdRpHtV utF6ObbuVnbWKBi5gxiauN37EO56wcNMvyuHmYS7iVKHnE1JDucxwIyi8v8HCPLcUSue s30VjDQcCJQzTpwx+yykax4i5Rn3TUCbD3PyixO1NR1n1Y0RjzdgESnrTUQH194A85eo ZlQA== X-Gm-Message-State: AN3rC/4mpaCtGc8ZrJb6m+Btt5UOwmw1cJOWQ5GTRfSx5jv/vdQq5PjPT+pTgXgBuUTNcQ== X-Received: by 10.237.36.105 with SMTP id s38mr1401617qtc.185.1491603677027; Fri, 07 Apr 2017 15:21:17 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Crosthwaite , Alexander Graf Date: Fri, 7 Apr 2017 19:20:14 -0300 Message-Id: <20170407222016.15308-3-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170407222016.15308-1-f4bug@amsat.org> References: <20170407222016.15308-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH v2 2/4] device_tree: fix compiler warnings (clang 5) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 static code analyzer complain: device_tree.c:155:18: warning: Null pointer passed as an argument to a 'non= null' parameter while ((de =3D readdir(d)) !=3D NULL) { ^~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- device_tree.c | 1 + 1 file changed, 1 insertion(+) diff --git a/device_tree.c b/device_tree.c index 6e06320830..a24ddff02b 100644 --- a/device_tree.c +++ b/device_tree.c @@ -148,6 +148,7 @@ static void read_fstree(void *fdt, const char *dirname) d =3D opendir(dirname); if (!d) { error_setg(&error_fatal, "%s cannot open %s", __func__, dirname); + return; } =20 while ((de =3D readdir(d)) !=3D NULL) { --=20 2.11.0 From nobody Sun May 5 19:38:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491603802879555.6043913275903; Fri, 7 Apr 2017 15:23:22 -0700 (PDT) Received: from localhost ([::1]:52788 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwcHp-0000vx-CU for importer@patchew.org; Fri, 07 Apr 2017 18:23:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwcG0-000858-2K for qemu-devel@nongnu.org; Fri, 07 Apr 2017 18:21:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cwcFz-00055Z-8Z for qemu-devel@nongnu.org; Fri, 07 Apr 2017 18:21:28 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:34306) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cwcFz-00055Q-4Y; Fri, 07 Apr 2017 18:21:27 -0400 Received: by mail-qk0-x244.google.com with SMTP id p68so11961435qke.1; Fri, 07 Apr 2017 15:21:27 -0700 (PDT) Received: from yoga.lan ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id d133sm1442146qke.9.2017.04.07.15.21.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Apr 2017 15:21:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b0Zx4R2huULvyqsmzKH8JZcKV7QLs3Zq9TqOuJkiEjE=; b=rg+6fIT1Fi+dDhgvBCyVZvR0MLQaP14FpqiQJtN0F/JoIX3Usaiz5kqgZorKbGus0Z ApJBlT+GhZKZJ7ONWBDk+XifVs7nRdzVbH4ScRYK2nKBr4oC4h/yELmr0dMM82KR+6sV ir2/M5/ZeWIz7oYyEA8j8z/gcqkVzWPtQKmxQ1zYVsY9xYVOttuYDbiHkLNsRh9B8EuD 1NoNJ2Seb0vpZmdwkS2xSNjbcQJ09GDz2UGy0PXxNp9n/aqcyRwl8yPzxyjZYOZzOTz4 kf5SE2nqGg4PXalvIP7RfVu6datjzDXKSbcy5pfDDht1YDKrqSKFcj/+0zHt5l/DmkGb abBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=b0Zx4R2huULvyqsmzKH8JZcKV7QLs3Zq9TqOuJkiEjE=; b=k5N/YAgp9FkvUlZguC0K53u/HgJrNyCeW1/8FN/TIfSo8qRY+SgCMjDNFHPJVHF4sB oiuY/NnHeVfC0laSTcb6/r6BNOVdrWS8dSBAey3CTHtiOOKtmxPh+hytWm9A/JJvD7j4 QpFsT0KHp+Q9OGFGI+v0zsSsEXs6lYYp8XttbJpG+Xnc/XpAwWNSM2NxrJNdY2prjvq3 Zi12wxew2tU2F2DYUT9NIT0eCeWqXHRS7RrAxODWxqv90V6thzKSh6h5TOF1G5ZbCwS0 PnSZaYhtfIu1DKgjkPzrZNrcQscC47Onoon8MpkCH7ertBKtTnlExDPGHf5Jc54JQhEi WTVw== X-Gm-Message-State: AFeK/H3FBo6PQ0WNLYrxvp7vXAEeX3fXxEeTo/D6PHVz3tuWO2nIVrdQYQAYZ3DxSXp+og== X-Received: by 10.233.239.19 with SMTP id d19mr29791783qkg.256.1491603686574; Fri, 07 Apr 2017 15:21:26 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Michael Roth Date: Fri, 7 Apr 2017 19:20:15 -0300 Message-Id: <20170407222016.15308-4-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170407222016.15308-1-f4bug@amsat.org> References: <20170407222016.15308-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH v2 3/4] qga: fix compiler warnings (clang 5) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 static code analyzer complain: qga/commands-posix.c:2127:9: warning: Null pointer passed as an argument to= a 'nonnull' parameter closedir(dp); ^~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Michael Roth --- qga/commands-posix.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 915df9ed90..fc45102a1e 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -2124,9 +2124,11 @@ static void transfer_memory_block(GuestMemoryBlock *= mem_blk, bool sys2memblk, * we think this VM does not support online/offline memory block, * any other solution? */ - if (!dp && errno =3D=3D ENOENT) { - result->response =3D - GUEST_MEMORY_BLOCK_RESPONSE_TYPE_OPERATION_NOT_SUPPORTED; + if (!dp) { + if (errno =3D=3D ENOENT) { + result->response =3D + GUEST_MEMORY_BLOCK_RESPONSE_TYPE_OPERATION_NOT_SUPPORT= ED; + } goto out1; } closedir(dp); --=20 2.11.0 From nobody Sun May 5 19:38:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491603912444170.89149076395427; Fri, 7 Apr 2017 15:25:12 -0700 (PDT) Received: from localhost ([::1]:52795 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwcJb-0002OA-DM for importer@patchew.org; Fri, 07 Apr 2017 18:25:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwcG3-00086f-TQ for qemu-devel@nongnu.org; Fri, 07 Apr 2017 18:21:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cwcG3-000575-2N for qemu-devel@nongnu.org; Fri, 07 Apr 2017 18:21:31 -0400 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:32961) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cwcG2-00056k-Uo for qemu-devel@nongnu.org; Fri, 07 Apr 2017 18:21:31 -0400 Received: by mail-qt0-x242.google.com with SMTP id c45so3675212qtb.0 for ; Fri, 07 Apr 2017 15:21:30 -0700 (PDT) Received: from yoga.lan ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id d133sm1442146qke.9.2017.04.07.15.21.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Apr 2017 15:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5CUxhrJmWSMfvt+gcfo83kV5Tf30FCyHNox8xlrihQ4=; b=gSZDCWctZSxIk8f2+kmF9JpB9XchmkDvHvIdwhOsvtA/zOIyAUaxOBaEDqZFk1PhH5 NPg6Yj40LeIWZ1ZwM9BvjEExE1RoAnQXPom0E26OHwW0BJ5vCGELVHOmgZMm+3t8vYUk ExtjkRvirvgzLSpwkB9KqjgBvB499Ia46PnjjnHFSc4Jh/sckvm74S4HVxo9Wvr5KWP+ dRY7udZQ1oGytXnPyW0OAFY2oeRkfo04l499mH/78jFES9q8YHf7nN4iBFpndH3wi59n z6c+SoGOyinryz6aiFZOA5goRTM5VhOYcxnwtCkW9WnsgYHPRv4AMhtTCs9Xf1OxWBQC YkLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=5CUxhrJmWSMfvt+gcfo83kV5Tf30FCyHNox8xlrihQ4=; b=ZudpN6GkMYm1473AIzBVYBRli4DM5RNSkOUFeoqLugxZhtKREtNb8JC7VI8mbWO83Z tHbZOQK7LQivYQfSzUY59pgaCdvs7Wjpfb+TkVw2DUAnJZ0Fsgc6pcpGdJx9FdIkKxEk XsX6v3H3mMITBtw99TbZpyYJ1Qlgf1ZWKSYtWPxsyr5jDetBnRKNVshgEihzuNyD/ois x8sS0cPupx8pXrDFsC9yTNsJp+Ch8nEGYA/m8t4N1l0d0ZzLy/SaBJ2PVRN/jZHgr9sY EeXvwIZM/QeU1+FJRPGNFC8pQJPBpo64DvXyTcGaoxSPlIA3wIauVY6cxfGDI4cdkHxw oj9A== X-Gm-Message-State: AFeK/H29ZL6w8bqR1wPp6dS5eTZ3CYVwEaOz6mafWj81/MblpD7N7Pd0oWYEU5cTCFdgig== X-Received: by 10.200.37.13 with SMTP id 13mr41523057qtm.209.1491603690495; Fri, 07 Apr 2017 15:21:30 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Michael Roth Date: Fri, 7 Apr 2017 19:20:16 -0300 Message-Id: <20170407222016.15308-5-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170407222016.15308-1-f4bug@amsat.org> References: <20170407222016.15308-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH v2 4/4] qga: improve error handling in transfer_memory_block X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Suggested-by: Michael Roth Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Michael Roth --- Michael should I use Signed-off-by instead of the Suggested-by (since it is= your code)? qga/commands-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index fc45102a1e..ca5a24b2c9 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -2128,6 +2128,9 @@ static void transfer_memory_block(GuestMemoryBlock *m= em_blk, bool sys2memblk, if (errno =3D=3D ENOENT) { result->response =3D GUEST_MEMORY_BLOCK_RESPONSE_TYPE_OPERATION_NOT_SUPPORT= ED; + } else { + result->response =3D + GUEST_MEMORY_BLOCK_RESPONSE_TYPE_OPERATION_FAILED; } goto out1; } --=20 2.11.0