Running QEMU with "qemu-system-x86_64 -M none -nographic -m 256" and executing
"dump-guest-memory /dev/null 0 8192" results in segfault.
Fix by checking if we have CPU.
Signed-off-by: Iwona Kotlarska <iwona260909@gmail.com>
---
target/i386/arch_dump.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target/i386/arch_dump.c b/target/i386/arch_dump.c
index 5a2e4be5d0..fe0aa36932 100644
--- a/target/i386/arch_dump.c
+++ b/target/i386/arch_dump.c
@@ -391,8 +391,7 @@ int cpu_get_dump_info(ArchDumpInfo *info,
#ifdef TARGET_X86_64
X86CPU *first_x86_cpu = X86_CPU(first_cpu);
-
- lma = !!(first_x86_cpu->env.hflags & HF_LMA_MASK);
+ lma = first_cpu && (first_x86_cpu->env.hflags & HF_LMA_MASK);
#endif
if (lma) {
--
2.12.0
On Thu, Mar 30, 2017 at 6:09 AM, Iwona Kotlarska <iwona260909@gmail.com> wrote: > Running QEMU with "qemu-system-x86_64 -M none -nographic -m 256" and executing > "dump-guest-memory /dev/null 0 8192" results in segfault. > Fix by checking if we have CPU. > > Signed-off-by: Iwona Kotlarska <iwona260909@gmail.com> > --- > target/i386/arch_dump.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
On 03/30/2017 08:09 AM, Iwona Kotlarska wrote: > Running QEMU with "qemu-system-x86_64 -M none -nographic -m 256" and executing > "dump-guest-memory /dev/null 0 8192" results in segfault. > Fix by checking if we have CPU. > > Signed-off-by: Iwona Kotlarska <iwona260909@gmail.com> > --- Hi Iwona, Next time (this patch is OK) please add here, after the "---" line a quick info on the version changes, e.g. : v2 -> v3: - Addressed Eduardo's comment and didn't split the assignment. - ... v1-> v2: - .... > target/i386/arch_dump.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target/i386/arch_dump.c b/target/i386/arch_dump.c > index 5a2e4be5d0..fe0aa36932 100644 > --- a/target/i386/arch_dump.c > +++ b/target/i386/arch_dump.c > @@ -391,8 +391,7 @@ int cpu_get_dump_info(ArchDumpInfo *info, > > #ifdef TARGET_X86_64 > X86CPU *first_x86_cpu = X86_CPU(first_cpu); > - > - lma = !!(first_x86_cpu->env.hflags & HF_LMA_MASK); > + lma = first_cpu && (first_x86_cpu->env.hflags & HF_LMA_MASK); > #endif > > if (lma) { > Reviewed-by: Marcel Apfelbaum <marcel@redhat.com> Thanks, Marcel
On Thu, Mar 30, 2017 at 07:09:24AM +0200, Iwona Kotlarska wrote: > Running QEMU with "qemu-system-x86_64 -M none -nographic -m 256" and executing > "dump-guest-memory /dev/null 0 8192" results in segfault. > Fix by checking if we have CPU. > > Signed-off-by: Iwona Kotlarska <iwona260909@gmail.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> Thanks! Paolo, are you queueing x86 bug fixes for the next -rc? -- Eduardo
On 30/03/2017 16:28, Eduardo Habkost wrote: > On Thu, Mar 30, 2017 at 07:09:24AM +0200, Iwona Kotlarska wrote: >> Running QEMU with "qemu-system-x86_64 -M none -nographic -m 256" and executing >> "dump-guest-memory /dev/null 0 8192" results in segfault. >> Fix by checking if we have CPU. >> >> Signed-off-by: Iwona Kotlarska <iwona260909@gmail.com> > > Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> > > Thanks! > > Paolo, are you queueing x86 bug fixes for the next -rc? This being HMP, I was leaving it to Dave, but I can queue it too since I have some memory API stuff to post too. Paolo
* Paolo Bonzini (pbonzini@redhat.com) wrote: > > > On 30/03/2017 16:28, Eduardo Habkost wrote: > > On Thu, Mar 30, 2017 at 07:09:24AM +0200, Iwona Kotlarska wrote: > >> Running QEMU with "qemu-system-x86_64 -M none -nographic -m 256" and executing > >> "dump-guest-memory /dev/null 0 8192" results in segfault. > >> Fix by checking if we have CPU. > >> > >> Signed-off-by: Iwona Kotlarska <iwona260909@gmail.com> > > > > Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> > > > > Thanks! > > > > Paolo, are you queueing x86 bug fixes for the next -rc? > > This being HMP, I was leaving it to Dave, but I can queue it too since I > have some memory API stuff to post too. Yeh I'll take this. Dave > Paolo -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
* Iwona Kotlarska (iwona260909@gmail.com) wrote: > Running QEMU with "qemu-system-x86_64 -M none -nographic -m 256" and executing > "dump-guest-memory /dev/null 0 8192" results in segfault. > Fix by checking if we have CPU. > > Signed-off-by: Iwona Kotlarska <iwona260909@gmail.com> Queued. I've fixed up the title to hmp: fix "dump-quest-memory" segfault since that's the actual command it fixes. Dave > --- > target/i386/arch_dump.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target/i386/arch_dump.c b/target/i386/arch_dump.c > index 5a2e4be5d0..fe0aa36932 100644 > --- a/target/i386/arch_dump.c > +++ b/target/i386/arch_dump.c > @@ -391,8 +391,7 @@ int cpu_get_dump_info(ArchDumpInfo *info, > > #ifdef TARGET_X86_64 > X86CPU *first_x86_cpu = X86_CPU(first_cpu); > - > - lma = !!(first_x86_cpu->env.hflags & HF_LMA_MASK); > + lma = first_cpu && (first_x86_cpu->env.hflags & HF_LMA_MASK); > #endif > > if (lma) { > -- > 2.12.0 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
© 2016 - 2024 Red Hat, Inc.