From nobody Fri May 3 09:39:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490850679448683.0391635047225; Wed, 29 Mar 2017 22:11:19 -0700 (PDT) Received: from localhost ([::1]:33635 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctSMK-0002Wa-Am for importer@patchew.org; Thu, 30 Mar 2017 01:10:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctSLZ-0002AX-4P for qemu-devel@nongnu.org; Thu, 30 Mar 2017 01:10:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctSLW-0006BW-0L for qemu-devel@nongnu.org; Thu, 30 Mar 2017 01:10:09 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:35174) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ctSLV-0006AT-PB for qemu-devel@nongnu.org; Thu, 30 Mar 2017 01:10:05 -0400 Received: by mail-lf0-x244.google.com with SMTP id v2so3516576lfi.2 for ; Wed, 29 Mar 2017 22:10:05 -0700 (PDT) Received: from localhost.localdomain (89-77-183-36.dynamic.chello.pl. [89.77.183.36]) by smtp.gmail.com with ESMTPSA id i18sm165977lfe.16.2017.03.29.22.10.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Mar 2017 22:10:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=lNVc7I2ZfOj4WxO3RUVaEIVZWj3UhPr+VYA2WYUKnW8=; b=pq6i5wkwoPrDM99yfRMRb2XH0Tpky5026YQzSOdh0XwxdVSRtaNHbG/K9kl0G9amwP AgEVaG70HmRGQ8sbDni3e63rrS9pMXgAA5j8UyEfWYEHRdIDbDVTSFKnh8OCfeoue71c /c9yspRn2szWgcVMR56lfJy3xs+dfdDPfcDcgrfENtbT2HwtxDUaPB4j+SSRPnv4tAwT gfYsRZWkCy4uO+jxcw95rwlReRD1J1ZSpNDwDT5QK1pGy8XYY97pM40NxxEi3PCFDVTd Gl8PJD39OHzLjLXeWmHCurNMB4phPbKqYQUjRj+PtFZ69XfEJwLyosB/99urlOembGGq sAng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=lNVc7I2ZfOj4WxO3RUVaEIVZWj3UhPr+VYA2WYUKnW8=; b=KmiqNpSq1JNvOs5NIY9x05BvXeNvZdfTS0G1Rd5j0X4loXf8IPzCiXHXa3E/Ha5O+6 MI0/oxrKubuxNQ/kJNp6LwkSViOsMLjTP6oTPDk5JIpxHwQXHKok2BwYALG3NhUq7TJr ve5w9mwYdy4hJ8GyDDejRYtnyWSeFVhmhuceUFwhWvX6JDLiU3XLD86lcRpMDUfcLBOF fY+9JT9UFMUOrrSmgLOUN8OyONuJ6Rgy8IK6j41nfdY4jlgV3Qgnaz4zog+IDVauGTOl TVHo72eXzoQWwWQB5Gx6GsRvHKPZYwJBjZ0PVqRphps8hN0nKP0ThRs9t/IYevsaQH0m 5JcQ== X-Gm-Message-State: AFeK/H3rVhhHR/2mKdOENaundfOg6wjA0qjFXVdpRqAmLC7ncCptbaVQmDylNN2W/1KQ+g== X-Received: by 10.25.23.215 with SMTP id 84mr1048484lfx.148.1490850604365; Wed, 29 Mar 2017 22:10:04 -0700 (PDT) From: Iwona Kotlarska To: Date: Thu, 30 Mar 2017 07:09:24 +0200 Message-Id: <20170330050924.22134-1-iwona260909@gmail.com> X-Mailer: git-send-email 2.12.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::244 Subject: [Qemu-devel] [PATCH v3] hmp: fix "info cpu" segfault X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ehabkost@redhat.com, qemu-devel@nongnu.org, Iwona Kotlarska , marcel@redhat.com, pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Running QEMU with "qemu-system-x86_64 -M none -nographic -m 256" and execut= ing "dump-guest-memory /dev/null 0 8192" results in segfault. Fix by checking if we have CPU. Signed-off-by: Iwona Kotlarska Reviewed-by: Eduardo Habkost Reviewed-by: Marcel Apfelbaum Reviewed-by: Stefan Hajnoczi --- target/i386/arch_dump.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/i386/arch_dump.c b/target/i386/arch_dump.c index 5a2e4be5d0..fe0aa36932 100644 --- a/target/i386/arch_dump.c +++ b/target/i386/arch_dump.c @@ -391,8 +391,7 @@ int cpu_get_dump_info(ArchDumpInfo *info, =20 #ifdef TARGET_X86_64 X86CPU *first_x86_cpu =3D X86_CPU(first_cpu); - - lma =3D !!(first_x86_cpu->env.hflags & HF_LMA_MASK); + lma =3D first_cpu && (first_x86_cpu->env.hflags & HF_LMA_MASK); #endif =20 if (lma) { --=20 2.12.0