[v2] Fix couple of issues with AMD topology

[PATCH v2 0/3] Fix couple of issues with AMD topology

Babu Moger posted 3 patches 3 years, 9 months ago

Diff against v1 v3
Download series mbox

Test FreeBSD passed

Test docker-quick@centos7 passed

Test checkpatch passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/159362436285.36204.986406297373871949.stgit@naples-babu.amd.com

Maintainers: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Eduardo Habkost <ehabkost@redhat.com>, Richard Henderson <rth@twiddle.net>, Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

There is a newer version of this series

hw/i386/pc.c               |   16 +++++++++++++++-
hw/i386/x86.c              |   19 +++++++++++++------
include/hw/i386/topology.h |   33 ++++++++++++++++++++++++++++++---
include/hw/i386/x86.h      |    6 ++++--
tests/test-x86-cpuid.c     |   39 ++++++++++++++++++++-------------------
5 files changed, 82 insertions(+), 31 deletions(-)

Expand all Fold all

[PATCH v2 0/3] Fix couple of issues with AMD topology

Posted by Babu Moger 3 years, 9 months ago

This series fixes couple of issues with recent topology related code.
1. Maintain consistency while building the topology. Use the numa
   information passed from user to build the apic_id.
2. Fix uninitialized memory with -device and CPU hotplug

Here are the discussion thread.
https://lore.kernel.org/qemu-devel/159164739269.20543.3074052993891532749.stgit@naples-babu.amd.com/
https://lore.kernel.org/qemu-devel/20200602175212.GH577771@habkost.net/

Fixes:
Link: https://bugzilla.redhat.com/show_bug.cgi?id=1828750
---

v2:
 - Used the numa information from CpuInstanceProperties for building
   the apic_id suggested by Igor.
 - Also did some minor code re-aarangement to take care of changes.
 - Dropped the patch "Simplify CPUID_8000_001E" from v1. Will send
   it later.

v1:
 https://lore.kernel.org/qemu-devel/159164739269.20543.3074052993891532749.stgit@naples-babu.amd.com
   
Babu Moger (3):
      hw/i386: Initialize topo_ids from CpuInstanceProperties
      hw/i386: Build apic_id from CpuInstanceProperties
      hw/386: Fix uninitialized memory with -device and CPU hotplug


 hw/i386/pc.c               |   16 +++++++++++++++-
 hw/i386/x86.c              |   19 +++++++++++++------
 include/hw/i386/topology.h |   33 ++++++++++++++++++++++++++++++---
 include/hw/i386/x86.h      |    6 ++++--
 tests/test-x86-cpuid.c     |   39 ++++++++++++++++++++-------------------
 5 files changed, 82 insertions(+), 31 deletions(-)

--
Signature