1. Patchew
  2. QEMU
  3. View series

[PATCH v3 0/6] hw/arm/smmuv3: Correct stream ID and event address handling

Simon Veith posted 6 patches 4 years, 4 months ago
Test asan failed
Test checkpatch failed
Test FreeBSD failed
Test docker-mingw@fedora failed
Test docker-clang@ubuntu failed
Test docker-quick@centos7 failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1576509312-13083-1-git-send-email-sveith@amazon.de
Maintainers: Peter Maydell <peter.maydell@linaro.org>, Eric Auger <eric.auger@redhat.com>
hw/arm/smmuv3-internal.h |  6 +++---
hw/arm/smmuv3.c          | 28 +++++++++++++++++++++-------
2 files changed, 24 insertions(+), 10 deletions(-)
[PATCH v3 0/6] hw/arm/smmuv3: Correct stream ID and event address handling
Posted by Simon Veith 4 years, 4 months ago 
While working on the Linux SMMUv3 driver, I noticed a few cases where the QEMU
SMMUv3 behavior relating to stream tables was inconsistent with our hardware.

Also, when debugging those differences, I found that the errors reported through
the QEMU SMMUv3 event queue contained the address fields in an incorrect
position.

These patches correct the QEMU SMMUv3 behavior to match the specification (and
the behavior that I observed in our hardware). Linux guests normally will not
notice these issues, but other SMMUv3 driver implementations might.

Changes in v2:

* New patch "hw/arm/smmuv3: Correct SMMU_BASE_ADDR_MASK value" added
* Updated patch "hw/arm/smmuv3: Check stream IDs against actual table LOG2SIZE"
* Updated patch "hw/arm/smmuv3: Align stream table base address to table size"

Changes in v3:

* No changes, but sending again to correct a patch submission mishap that
  confused Patchew

Simon Veith (6):
  hw/arm/smmuv3: Apply address mask to linear strtab base address
  hw/arm/smmuv3: Correct SMMU_BASE_ADDR_MASK value
  hw/arm/smmuv3: Check stream IDs against actual table LOG2SIZE
  hw/arm/smmuv3: Align stream table base address to table size
  hw/arm/smmuv3: Use correct bit positions in EVT_SET_ADDR2 macro
  hw/arm/smmuv3: Report F_STE_FETCH fault address in correct word
    position

 hw/arm/smmuv3-internal.h |  6 +++---
 hw/arm/smmuv3.c          | 28 +++++++++++++++++++++-------
 2 files changed, 24 insertions(+), 10 deletions(-)

-- 
2.7.4
Re: [PATCH v3 0/6] hw/arm/smmuv3: Correct stream ID and event address handling
Posted by Auger Eric 4 years, 4 months ago 
Hi,

On 12/16/19 4:15 PM, Simon Veith wrote:
> While working on the Linux SMMUv3 driver, I noticed a few cases where the QEMU
> SMMUv3 behavior relating to stream tables was inconsistent with our hardware.
> 
> Also, when debugging those differences, I found that the errors reported through
> the QEMU SMMUv3 event queue contained the address fields in an incorrect
> position.
> 
> These patches correct the QEMU SMMUv3 behavior to match the specification (and
> the behavior that I observed in our hardware). Linux guests normally will not
> notice these issues, but other SMMUv3 driver implementations might.
> 
> Changes in v2:
> 
> * New patch "hw/arm/smmuv3: Correct SMMU_BASE_ADDR_MASK value" added
> * Updated patch "hw/arm/smmuv3: Check stream IDs against actual table LOG2SIZE"
> * Updated patch "hw/arm/smmuv3: Align stream table base address to table size"
> 
> Changes in v3:
> 
> * No changes, but sending again to correct a patch submission mishap that
>   confused Patchew
> 
> Simon Veith (6):
>   hw/arm/smmuv3: Apply address mask to linear strtab base address
>   hw/arm/smmuv3: Correct SMMU_BASE_ADDR_MASK value
>   hw/arm/smmuv3: Check stream IDs against actual table LOG2SIZE
>   hw/arm/smmuv3: Align stream table base address to table size
>   hw/arm/smmuv3: Use correct bit positions in EVT_SET_ADDR2 macro
>   hw/arm/smmuv3: Report F_STE_FETCH fault address in correct word
>     position

The series looks good to me. Also tested against non regression.

Tested-by: Eric Auger <eric.auger@redhat.com>

Thanks

Eric


> 
>  hw/arm/smmuv3-internal.h |  6 +++---
>  hw/arm/smmuv3.c          | 28 +++++++++++++++++++++-------
>  2 files changed, 24 insertions(+), 10 deletions(-)
>
Re: [PATCH v3 0/6] hw/arm/smmuv3: Correct stream ID and event address handling
Posted by Peter Maydell 4 years, 4 months ago 
On Tue, 17 Dec 2019 at 10:04, Auger Eric <eric.auger@redhat.com> wrote:
>
> Hi,
>
> On 12/16/19 4:15 PM, Simon Veith wrote:
> > While working on the Linux SMMUv3 driver, I noticed a few cases where the QEMU
> > SMMUv3 behavior relating to stream tables was inconsistent with our hardware.
> >
> > Also, when debugging those differences, I found that the errors reported through
> > the QEMU SMMUv3 event queue contained the address fields in an incorrect
> > position.
> >
> > These patches correct the QEMU SMMUv3 behavior to match the specification (and
> > the behavior that I observed in our hardware). Linux guests normally will not
> > notice these issues, but other SMMUv3 driver implementations might.
> >
> > Changes in v2:
> >
> > * New patch "hw/arm/smmuv3: Correct SMMU_BASE_ADDR_MASK value" added
> > * Updated patch "hw/arm/smmuv3: Check stream IDs against actual table LOG2SIZE"
> > * Updated patch "hw/arm/smmuv3: Align stream table base address to table size"
> >
> > Changes in v3:
> >
> > * No changes, but sending again to correct a patch submission mishap that
> >   confused Patchew
> >
> > Simon Veith (6):
> >   hw/arm/smmuv3: Apply address mask to linear strtab base address
> >   hw/arm/smmuv3: Correct SMMU_BASE_ADDR_MASK value
> >   hw/arm/smmuv3: Check stream IDs against actual table LOG2SIZE
> >   hw/arm/smmuv3: Align stream table base address to table size
> >   hw/arm/smmuv3: Use correct bit positions in EVT_SET_ADDR2 macro
> >   hw/arm/smmuv3: Report F_STE_FETCH fault address in correct word
> >     position
>
> The series looks good to me. Also tested against non regression.
>
> Tested-by: Eric Auger <eric.auger@redhat.com>

Applied to target-arm.next, thanks.

-- PMM

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.