target/mips: gdbstub: Revert commit 8e0b373

[Qemu-devel] [PATCH] target/mips: gdbstub: Revert commit 8e0b373

Aleksandar Markovic posted 1 patch 4 years, 7 months ago

Download mbox

Test docker-quick@centos7 passed

Test docker-clang@ubuntu passed

Test FreeBSD passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1568207966-25202-1-git-send-email-aleksandar.markovic@rt-rk.com

Maintainers: Aleksandar Markovic <amarkovic@wavecomp.com>, Aleksandar Rikalo <arikalo@wavecomp.com>, Aurelien Jarno <aurelien@aurel32.net>

target/mips/gdbstub.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] target/mips: gdbstub: Revert commit 8e0b373

Posted by Aleksandar Markovic 4 years, 7 months ago

From: Libo Zhou <zhlb29@foxmail.com>

Multiple report from users were received regarding failures
of "packet g" comminucation with gdb. Revert this commit until
a better solution is developed.

Suggested-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Signed-off-by: Libo Zhou <zhlb29@foxmail.com>
Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
---
 target/mips/gdbstub.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/target/mips/gdbstub.c b/target/mips/gdbstub.c
index ebcc98b..bbb2544 100644
--- a/target/mips/gdbstub.c
+++ b/target/mips/gdbstub.c
@@ -38,7 +38,7 @@ int mips_cpu_gdb_read_register(CPUState *cs, uint8_t *mem_buf, int n)
             return gdb_get_regl(mem_buf, (int32_t)env->active_fpu.fcr0);
         default:
             if (env->CP0_Status & (1 << CP0St_FR)) {
-                return gdb_get_reg64(mem_buf,
+                return gdb_get_regl(mem_buf,
                     env->active_fpu.fpr[n - 38].d);
             } else {
                 return gdb_get_regl(mem_buf,
@@ -99,7 +99,6 @@ int mips_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)
             break;
         default:
             if (env->CP0_Status & (1 << CP0St_FR)) {
-                uint64_t tmp = ldq_p(mem_buf);
                 env->active_fpu.fpr[n - 38].d = tmp;
             } else {
                 env->active_fpu.fpr[n - 38].w[FP_ENDIAN_IDX] = tmp;
-- 
2.7.4

Re: [Qemu-devel] [PATCH] target/mips: gdbstub: Revert commit 8e0b373

Posted by Aleksandar Markovic 4 years, 7 months ago

11.09.2019. 15.21, "Aleksandar Markovic" <aleksandar.markovic@rt-rk.com> је
написао/ла:
>
> From: Libo Zhou <zhlb29@foxmail.com>
>
> Multiple report from users were received regarding failures
> of "packet g" comminucation with gdb. Revert this commit until
> a better solution is developed.
>
> Suggested-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> Signed-off-by: Libo Zhou <zhlb29@foxmail.com>
> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> ---

Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>

>  target/mips/gdbstub.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/target/mips/gdbstub.c b/target/mips/gdbstub.c
> index ebcc98b..bbb2544 100644
> --- a/target/mips/gdbstub.c
> +++ b/target/mips/gdbstub.c
> @@ -38,7 +38,7 @@ int mips_cpu_gdb_read_register(CPUState *cs, uint8_t
*mem_buf, int n)
>              return gdb_get_regl(mem_buf, (int32_t)env->active_fpu.fcr0);
>          default:
>              if (env->CP0_Status & (1 << CP0St_FR)) {
> -                return gdb_get_reg64(mem_buf,
> +                return gdb_get_regl(mem_buf,
>                      env->active_fpu.fpr[n - 38].d);
>              } else {
>                  return gdb_get_regl(mem_buf,
> @@ -99,7 +99,6 @@ int mips_cpu_gdb_write_register(CPUState *cs, uint8_t
*mem_buf, int n)
>              break;
>          default:
>              if (env->CP0_Status & (1 << CP0St_FR)) {
> -                uint64_t tmp = ldq_p(mem_buf);
>                  env->active_fpu.fpr[n - 38].d = tmp;
>              } else {
>                  env->active_fpu.fpr[n - 38].w[FP_ENDIAN_IDX] = tmp;
> --
> 2.7.4
>
>