From nobody Wed Apr 24 04:07:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1568208152; cv=none; d=zoho.com; s=zohoarc; b=SQFaEFcWswE2lGOanzOHSIb8fjADTCSghDczyQP48u7Xv4hs8gfo85sBEEKzbN/gVkJjy7C0JXKvM6EViTZtt/JMyzUvryY4GiGFG7pJiHAINYCqv0mbyUuHmkv5euaiuYnQxNg8dWBxRp3RaQnXHSLArrNTRFXVLCe4S+uOoZI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568208152; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=b7WrhlE/FtVy+Os3+GU9iqWSEaSwp62uR/prIHdYhi4=; b=ifwf6vJbbKmYJQn8evz09Yh/84hGLjldIW0uuDI3lxvIVP8efdPTX3JVaF2iiZstca1RpRfDnKM2cCZsYVv1q8aLnkofJyUzuVwZr3tR4z+/GKRMJIRVYYeUcaHYshOpxL3dxhXO2FnbWaEYZCaZTzgWzigWICwfNvMLJC1U3TE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568208151855768.77271946948; Wed, 11 Sep 2019 06:22:31 -0700 (PDT) Received: from localhost ([::1]:50990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i82Zo-00083b-Q8 for importer@patchew.org; Wed, 11 Sep 2019 09:22:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58705) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i82YA-0006ij-Q9 for qemu-devel@nongnu.org; Wed, 11 Sep 2019 09:20:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i82Y7-0006iA-Qp for qemu-devel@nongnu.org; Wed, 11 Sep 2019 09:20:45 -0400 Received: from mx2.rt-rk.com ([89.216.37.149]:35393 helo=mail.rt-rk.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i82Y7-00062C-Ki for qemu-devel@nongnu.org; Wed, 11 Sep 2019 09:20:43 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.rt-rk.com (Postfix) with ESMTP id 8FAFB1A1E97; Wed, 11 Sep 2019 15:19:38 +0200 (CEST) Received: from rtrkw774-lin.domain.local (rtrkw774-lin.domain.local [10.10.13.43]) by mail.rt-rk.com (Postfix) with ESMTPSA id 77BA01A1E2D; Wed, 11 Sep 2019 15:19:38 +0200 (CEST) X-Virus-Scanned: amavisd-new at rt-rk.com From: Aleksandar Markovic To: qemu-devel@nongnu.org Date: Wed, 11 Sep 2019 15:19:26 +0200 Message-Id: <1568207966-25202-1-git-send-email-aleksandar.markovic@rt-rk.com> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 89.216.37.149 Subject: [Qemu-devel] [PATCH] target/mips: gdbstub: Revert commit 8e0b373 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arikalo@wavecomp.com, Libo Zhou , amarkovic@wavecomp.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Libo Zhou Multiple report from users were received regarding failures of "packet g" comminucation with gdb. Revert this commit until a better solution is developed. Suggested-by: Aleksandar Markovic Signed-off-by: Libo Zhou Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Markovic --- target/mips/gdbstub.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/mips/gdbstub.c b/target/mips/gdbstub.c index ebcc98b..bbb2544 100644 --- a/target/mips/gdbstub.c +++ b/target/mips/gdbstub.c @@ -38,7 +38,7 @@ int mips_cpu_gdb_read_register(CPUState *cs, uint8_t *mem= _buf, int n) return gdb_get_regl(mem_buf, (int32_t)env->active_fpu.fcr0); default: if (env->CP0_Status & (1 << CP0St_FR)) { - return gdb_get_reg64(mem_buf, + return gdb_get_regl(mem_buf, env->active_fpu.fpr[n - 38].d); } else { return gdb_get_regl(mem_buf, @@ -99,7 +99,6 @@ int mips_cpu_gdb_write_register(CPUState *cs, uint8_t *me= m_buf, int n) break; default: if (env->CP0_Status & (1 << CP0St_FR)) { - uint64_t tmp =3D ldq_p(mem_buf); env->active_fpu.fpr[n - 38].d =3D tmp; } else { env->active_fpu.fpr[n - 38].w[FP_ENDIAN_IDX] =3D tmp; --=20 2.7.4