1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH 0/9] refactor cpu topo into machine properties

Like Xu posted 9 patches 5 years ago
Test docker-clang@ubuntu failed
Test docker-mingw@fedora passed
Test checkpatch passed
Test asan failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1553849325-44201-1-git-send-email-like.xu@linux.intel.com
Maintainers: Christian Borntraeger <borntraeger@de.ibm.com>, "Cédric Le Goater" <clg@kaod.org>, "Hervé Poussineau" <hpoussin@reactos.org>, Halil Pasic <pasic@linux.ibm.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Stafford Horne <shorne@gmail.com>, Jean-Christophe Dubois <jcd@tribudubois.net>, Palmer Dabbelt <palmer@sifive.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Peter Maydell <peter.maydell@linaro.org>, Andrew Baumann <Andrew.Baumann@microsoft.com>, David Gibson <david@gibson.dropbear.id.au>, Aleksandar Rikalo <arikalo@wavecomp.com>, Juan Quintela <quintela@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Aleksandar Markovic <amarkovic@wavecomp.com>, "Michael S. Tsirkin" <mst@redhat.com>, Richard Henderson <rth@twiddle.net>, Rob Herring <robh@kernel.org>, Alistair Francis <alistair@alistair23.me>, Helge Deller <deller@gmx.de>, Alistair Francis <Alistair.Francis@wdc.com>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Igor Mammedov <imammedo@redhat.com>, Max Filippov <jcmvbkbc@gmail.com>, Eduardo Habkost <ehabkost@redhat.com>, Jia Liu <proljc@gmail.com>, Sagar Karandikar <sagark@eecs.berkeley.edu>, Aurelien Jarno <aurelien@aurel32.net>, Paul Burton <pburton@wavecomp.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, David Hildenbrand <david@redhat.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Andrey Smirnov <andrew.smirnov@gmail.com>, Artyom Tarasenko <atar4qemu@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>
There is a newer version of this series
accel/kvm/kvm-all.c          |  3 +++
backends/hostmem.c           |  4 ++++
cpus.c                       |  4 ++++
exec.c                       |  2 ++
gdbstub.c                    |  7 ++++++-
hw/alpha/dp264.c             |  1 +
hw/arm/fsl-imx6.c            |  5 +++++
hw/arm/fsl-imx6ul.c          |  5 +++++
hw/arm/fsl-imx7.c            |  5 +++++
hw/arm/highbank.c            |  1 +
hw/arm/mcimx6ul-evk.c        |  1 +
hw/arm/mcimx7d-sabre.c       |  3 +++
hw/arm/raspi.c               |  2 ++
hw/arm/realview.c            |  1 +
hw/arm/sabrelite.c           |  1 +
hw/arm/vexpress.c            |  3 +++
hw/arm/virt.c                |  7 +++++++
hw/arm/xlnx-zynqmp.c         |  7 +++++++
hw/cpu/core.c                |  3 +++
hw/hppa/machine.c            |  4 ++++
hw/i386/acpi-build.c         |  3 +++
hw/i386/kvmvapic.c           |  5 +++++
hw/i386/pc.c                 | 12 +++++++++++
hw/mips/boston.c             |  1 +
hw/mips/mips_malta.c         |  9 +++++++++
hw/openrisc/openrisc_sim.c   |  1 +
hw/ppc/e500.c                |  3 +++
hw/ppc/mac_newworld.c        |  2 ++
hw/ppc/mac_oldworld.c        |  2 ++
hw/ppc/pnv.c                 |  3 +++
hw/ppc/prep.c                |  2 ++
hw/ppc/spapr.c               | 29 ++++++++++++++++++++++++++
hw/ppc/spapr_rtas.c          |  3 +++
hw/riscv/sifive_e.c          |  4 ++++
hw/riscv/sifive_plic.c       |  3 +++
hw/riscv/sifive_u.c          |  4 ++++
hw/riscv/spike.c             |  2 ++
hw/riscv/virt.c              |  1 +
hw/s390x/s390-virtio-ccw.c   |  2 ++
hw/s390x/sclp.c              |  1 +
hw/smbios/smbios.c           | 11 ++++++++++
hw/sparc/sun4m.c             |  2 ++
hw/sparc64/sun4u.c           |  2 ++
hw/xtensa/sim.c              |  1 +
hw/xtensa/xtfpga.c           |  1 +
include/hw/arm/virt.h        |  2 +-
include/hw/boards.h          |  8 ++++++++
include/sysemu/sysemu.h      |  2 +-
migration/postcopy-ram.c     |  7 +++++++
numa.c                       |  1 +
target/arm/cpu.c             |  7 +++++++
target/i386/cpu.c            |  4 ++++
target/openrisc/sys_helper.c |  5 +++++
target/s390x/cpu.c           |  3 +++
target/s390x/excp_helper.c   |  6 ++++++
tcg/tcg.c                    | 15 ++++++++++++++
vl.c                         | 48 ++++++++++++++++++++++++--------------------
57 files changed, 261 insertions(+), 25 deletions(-)
[Qemu-devel] [PATCH 0/9] refactor cpu topo into machine properties
Posted by Like Xu 5 years ago 
This patch series make existing cores/threads/sockets into machine
properties and get rid of global variables they use currently.

Like Xu (9):
  cpu/topology: add struct CpuTopology to MachineState
  cpu/topology: add general support for machine properties
  cpu/topology: add uncommon arch support for smp machine properties
  cpu/topology: add ARM support for smp machine properties
  cpu/topology: add i386 support for smp machine properties
  cpu/topology: add PPC support for smp machine properties
  cpu/topology: add riscv support for smp machine properties
  cpu/topology: add s390x support for smp machine properties
  cpu/topology: replace smp global variables with machine propertie

 accel/kvm/kvm-all.c          |  3 +++
 backends/hostmem.c           |  4 ++++
 cpus.c                       |  4 ++++
 exec.c                       |  2 ++
 gdbstub.c                    |  7 ++++++-
 hw/alpha/dp264.c             |  1 +
 hw/arm/fsl-imx6.c            |  5 +++++
 hw/arm/fsl-imx6ul.c          |  5 +++++
 hw/arm/fsl-imx7.c            |  5 +++++
 hw/arm/highbank.c            |  1 +
 hw/arm/mcimx6ul-evk.c        |  1 +
 hw/arm/mcimx7d-sabre.c       |  3 +++
 hw/arm/raspi.c               |  2 ++
 hw/arm/realview.c            |  1 +
 hw/arm/sabrelite.c           |  1 +
 hw/arm/vexpress.c            |  3 +++
 hw/arm/virt.c                |  7 +++++++
 hw/arm/xlnx-zynqmp.c         |  7 +++++++
 hw/cpu/core.c                |  3 +++
 hw/hppa/machine.c            |  4 ++++
 hw/i386/acpi-build.c         |  3 +++
 hw/i386/kvmvapic.c           |  5 +++++
 hw/i386/pc.c                 | 12 +++++++++++
 hw/mips/boston.c             |  1 +
 hw/mips/mips_malta.c         |  9 +++++++++
 hw/openrisc/openrisc_sim.c   |  1 +
 hw/ppc/e500.c                |  3 +++
 hw/ppc/mac_newworld.c        |  2 ++
 hw/ppc/mac_oldworld.c        |  2 ++
 hw/ppc/pnv.c                 |  3 +++
 hw/ppc/prep.c                |  2 ++
 hw/ppc/spapr.c               | 29 ++++++++++++++++++++++++++
 hw/ppc/spapr_rtas.c          |  3 +++
 hw/riscv/sifive_e.c          |  4 ++++
 hw/riscv/sifive_plic.c       |  3 +++
 hw/riscv/sifive_u.c          |  4 ++++
 hw/riscv/spike.c             |  2 ++
 hw/riscv/virt.c              |  1 +
 hw/s390x/s390-virtio-ccw.c   |  2 ++
 hw/s390x/sclp.c              |  1 +
 hw/smbios/smbios.c           | 11 ++++++++++
 hw/sparc/sun4m.c             |  2 ++
 hw/sparc64/sun4u.c           |  2 ++
 hw/xtensa/sim.c              |  1 +
 hw/xtensa/xtfpga.c           |  1 +
 include/hw/arm/virt.h        |  2 +-
 include/hw/boards.h          |  8 ++++++++
 include/sysemu/sysemu.h      |  2 +-
 migration/postcopy-ram.c     |  7 +++++++
 numa.c                       |  1 +
 target/arm/cpu.c             |  7 +++++++
 target/i386/cpu.c            |  4 ++++
 target/openrisc/sys_helper.c |  5 +++++
 target/s390x/cpu.c           |  3 +++
 target/s390x/excp_helper.c   |  6 ++++++
 tcg/tcg.c                    | 15 ++++++++++++++
 vl.c                         | 48 ++++++++++++++++++++++++--------------------
 57 files changed, 261 insertions(+), 25 deletions(-)

-- 
1.8.3.1
Re: [Qemu-devel] [PATCH 0/9] refactor cpu topo into machine properties
Posted by no-reply@patchew.org 5 years ago 
Patchew URL: https://patchew.org/QEMU/1553849325-44201-1-git-send-email-like.xu@linux.intel.com/



Hi,

This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===

/usr/bin/ld: /tmp/qemu-test/src/hw/i386/xen/xen-hvm.c:(.text+0x17f7): undefined reference to `max_cpus'
/usr/bin/ld: /tmp/qemu-test/src/hw/i386/xen/xen-hvm.c:(.text+0x1b1e): undefined reference to `max_cpus'
/usr/bin/ld: hw/i386/xen/xen-hvm.o:/tmp/qemu-test/src/hw/i386/xen/xen-hvm.c:(.text+0x1b3e): more undefined references to `max_cpus' follow
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [Makefile:204: qemu-system-x86_64] Error 1
make: *** [Makefile:450: subdir-x86_64-softmmu] Error 2
Traceback (most recent call last):


The full log is available at
http://patchew.org/logs/1553849325-44201-1-git-send-email-like.xu@linux.intel.com/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH 0/9] refactor cpu topo into machine properties
Posted by Igor Mammedov 5 years ago 
On Fri, 29 Mar 2019 16:48:36 +0800
Like Xu <like.xu@linux.intel.com> wrote:

> This patch series make existing cores/threads/sockets into machine
> properties and get rid of global variables they use currently.
Thanks for looking into it!
Its long overdue and rather desired conversion (albeit naive one,
but this series is a good starting point). I'll go over your patches
next week with comments and concrete suggestions how to implement
particular things.

> Like Xu (9):
>   cpu/topology: add struct CpuTopology to MachineState
>   cpu/topology: add general support for machine properties
>   cpu/topology: add uncommon arch support for smp machine properties
>   cpu/topology: add ARM support for smp machine properties
>   cpu/topology: add i386 support for smp machine properties
>   cpu/topology: add PPC support for smp machine properties
>   cpu/topology: add riscv support for smp machine properties
>   cpu/topology: add s390x support for smp machine properties
>   cpu/topology: replace smp global variables with machine propertie
> 
>  accel/kvm/kvm-all.c          |  3 +++
>  backends/hostmem.c           |  4 ++++
>  cpus.c                       |  4 ++++
>  exec.c                       |  2 ++
>  gdbstub.c                    |  7 ++++++-
>  hw/alpha/dp264.c             |  1 +
>  hw/arm/fsl-imx6.c            |  5 +++++
>  hw/arm/fsl-imx6ul.c          |  5 +++++
>  hw/arm/fsl-imx7.c            |  5 +++++
>  hw/arm/highbank.c            |  1 +
>  hw/arm/mcimx6ul-evk.c        |  1 +
>  hw/arm/mcimx7d-sabre.c       |  3 +++
>  hw/arm/raspi.c               |  2 ++
>  hw/arm/realview.c            |  1 +
>  hw/arm/sabrelite.c           |  1 +
>  hw/arm/vexpress.c            |  3 +++
>  hw/arm/virt.c                |  7 +++++++
>  hw/arm/xlnx-zynqmp.c         |  7 +++++++
>  hw/cpu/core.c                |  3 +++
>  hw/hppa/machine.c            |  4 ++++
>  hw/i386/acpi-build.c         |  3 +++
>  hw/i386/kvmvapic.c           |  5 +++++
>  hw/i386/pc.c                 | 12 +++++++++++
>  hw/mips/boston.c             |  1 +
>  hw/mips/mips_malta.c         |  9 +++++++++
>  hw/openrisc/openrisc_sim.c   |  1 +
>  hw/ppc/e500.c                |  3 +++
>  hw/ppc/mac_newworld.c        |  2 ++
>  hw/ppc/mac_oldworld.c        |  2 ++
>  hw/ppc/pnv.c                 |  3 +++
>  hw/ppc/prep.c                |  2 ++
>  hw/ppc/spapr.c               | 29 ++++++++++++++++++++++++++
>  hw/ppc/spapr_rtas.c          |  3 +++
>  hw/riscv/sifive_e.c          |  4 ++++
>  hw/riscv/sifive_plic.c       |  3 +++
>  hw/riscv/sifive_u.c          |  4 ++++
>  hw/riscv/spike.c             |  2 ++
>  hw/riscv/virt.c              |  1 +
>  hw/s390x/s390-virtio-ccw.c   |  2 ++
>  hw/s390x/sclp.c              |  1 +
>  hw/smbios/smbios.c           | 11 ++++++++++
>  hw/sparc/sun4m.c             |  2 ++
>  hw/sparc64/sun4u.c           |  2 ++
>  hw/xtensa/sim.c              |  1 +
>  hw/xtensa/xtfpga.c           |  1 +
>  include/hw/arm/virt.h        |  2 +-
>  include/hw/boards.h          |  8 ++++++++
>  include/sysemu/sysemu.h      |  2 +-
>  migration/postcopy-ram.c     |  7 +++++++
>  numa.c                       |  1 +
>  target/arm/cpu.c             |  7 +++++++
>  target/i386/cpu.c            |  4 ++++
>  target/openrisc/sys_helper.c |  5 +++++
>  target/s390x/cpu.c           |  3 +++
>  target/s390x/excp_helper.c   |  6 ++++++
>  tcg/tcg.c                    | 15 ++++++++++++++
>  vl.c                         | 48 ++++++++++++++++++++++++--------------------
>  57 files changed, 261 insertions(+), 25 deletions(-)
>
Re: [Qemu-devel] [PATCH 0/9] refactor cpu topo into machine properties
Posted by Like Xu 5 years ago 
On 2019/3/29 18:21, Igor Mammedov wrote:
> On Fri, 29 Mar 2019 16:48:36 +0800
> Like Xu <like.xu@linux.intel.com> wrote:
> 
>> This patch series make existing cores/threads/sockets into machine
>> properties and get rid of global variables they use currently.
> Thanks for looking into it!
> Its long overdue and rather desired conversion (albeit naive one,
> but this series is a good starting point). I'll go over your patches
> next week with comments and concrete suggestions how to implement
> particular things.

Hi Igor, any comments and suggestions on smp machine properties
in this patch considering we may add die topology for PCMachine as an 
extension?

> 
>> Like Xu (9):
>>    cpu/topology: add struct CpuTopology to MachineState
>>    cpu/topology: add general support for machine properties
>>    cpu/topology: add uncommon arch support for smp machine properties
>>    cpu/topology: add ARM support for smp machine properties
>>    cpu/topology: add i386 support for smp machine properties
>>    cpu/topology: add PPC support for smp machine properties
>>    cpu/topology: add riscv support for smp machine properties
>>    cpu/topology: add s390x support for smp machine properties
>>    cpu/topology: replace smp global variables with machine propertie
>>
>>   accel/kvm/kvm-all.c          |  3 +++
>>   backends/hostmem.c           |  4 ++++
>>   cpus.c                       |  4 ++++
>>   exec.c                       |  2 ++
>>   gdbstub.c                    |  7 ++++++-
>>   hw/alpha/dp264.c             |  1 +
>>   hw/arm/fsl-imx6.c            |  5 +++++
>>   hw/arm/fsl-imx6ul.c          |  5 +++++
>>   hw/arm/fsl-imx7.c            |  5 +++++
>>   hw/arm/highbank.c            |  1 +
>>   hw/arm/mcimx6ul-evk.c        |  1 +
>>   hw/arm/mcimx7d-sabre.c       |  3 +++
>>   hw/arm/raspi.c               |  2 ++
>>   hw/arm/realview.c            |  1 +
>>   hw/arm/sabrelite.c           |  1 +
>>   hw/arm/vexpress.c            |  3 +++
>>   hw/arm/virt.c                |  7 +++++++
>>   hw/arm/xlnx-zynqmp.c         |  7 +++++++
>>   hw/cpu/core.c                |  3 +++
>>   hw/hppa/machine.c            |  4 ++++
>>   hw/i386/acpi-build.c         |  3 +++
>>   hw/i386/kvmvapic.c           |  5 +++++
>>   hw/i386/pc.c                 | 12 +++++++++++
>>   hw/mips/boston.c             |  1 +
>>   hw/mips/mips_malta.c         |  9 +++++++++
>>   hw/openrisc/openrisc_sim.c   |  1 +
>>   hw/ppc/e500.c                |  3 +++
>>   hw/ppc/mac_newworld.c        |  2 ++
>>   hw/ppc/mac_oldworld.c        |  2 ++
>>   hw/ppc/pnv.c                 |  3 +++
>>   hw/ppc/prep.c                |  2 ++
>>   hw/ppc/spapr.c               | 29 ++++++++++++++++++++++++++
>>   hw/ppc/spapr_rtas.c          |  3 +++
>>   hw/riscv/sifive_e.c          |  4 ++++
>>   hw/riscv/sifive_plic.c       |  3 +++
>>   hw/riscv/sifive_u.c          |  4 ++++
>>   hw/riscv/spike.c             |  2 ++
>>   hw/riscv/virt.c              |  1 +
>>   hw/s390x/s390-virtio-ccw.c   |  2 ++
>>   hw/s390x/sclp.c              |  1 +
>>   hw/smbios/smbios.c           | 11 ++++++++++
>>   hw/sparc/sun4m.c             |  2 ++
>>   hw/sparc64/sun4u.c           |  2 ++
>>   hw/xtensa/sim.c              |  1 +
>>   hw/xtensa/xtfpga.c           |  1 +
>>   include/hw/arm/virt.h        |  2 +-
>>   include/hw/boards.h          |  8 ++++++++
>>   include/sysemu/sysemu.h      |  2 +-
>>   migration/postcopy-ram.c     |  7 +++++++
>>   numa.c                       |  1 +
>>   target/arm/cpu.c             |  7 +++++++
>>   target/i386/cpu.c            |  4 ++++
>>   target/openrisc/sys_helper.c |  5 +++++
>>   target/s390x/cpu.c           |  3 +++
>>   target/s390x/excp_helper.c   |  6 ++++++
>>   tcg/tcg.c                    | 15 ++++++++++++++
>>   vl.c                         | 48 ++++++++++++++++++++++++--------------------
>>   57 files changed, 261 insertions(+), 25 deletions(-)
>>
> 
> 
>
Re: [Qemu-devel] [PATCH 0/9] refactor cpu topo into machine properties
Posted by Igor Mammedov 5 years ago 
On Thu, 4 Apr 2019 11:26:09 +0800
Like Xu <like.xu@linux.intel.com> wrote:

> On 2019/3/29 18:21, Igor Mammedov wrote:
> > On Fri, 29 Mar 2019 16:48:36 +0800
> > Like Xu <like.xu@linux.intel.com> wrote:
> >   
> >> This patch series make existing cores/threads/sockets into machine
> >> properties and get rid of global variables they use currently.  
> > Thanks for looking into it!
> > Its long overdue and rather desired conversion (albeit naive one,
> > but this series is a good starting point). I'll go over your patches
> > next week with comments and concrete suggestions how to implement
> > particular things.  
> 
> Hi Igor, any comments and suggestions on smp machine properties
> in this patch considering we may add die topology for PCMachine as an 
> extension?

I've looked at several patches and that it for this series.
The most comments apply to the patches I've not reviewed as well.

> >   
> >> Like Xu (9):
> >>    cpu/topology: add struct CpuTopology to MachineState
> >>    cpu/topology: add general support for machine properties
> >>    cpu/topology: add uncommon arch support for smp machine properties
> >>    cpu/topology: add ARM support for smp machine properties
> >>    cpu/topology: add i386 support for smp machine properties
> >>    cpu/topology: add PPC support for smp machine properties
> >>    cpu/topology: add riscv support for smp machine properties
> >>    cpu/topology: add s390x support for smp machine properties
> >>    cpu/topology: replace smp global variables with machine propertie
> >>
> >>   accel/kvm/kvm-all.c          |  3 +++
> >>   backends/hostmem.c           |  4 ++++
> >>   cpus.c                       |  4 ++++
> >>   exec.c                       |  2 ++
> >>   gdbstub.c                    |  7 ++++++-
> >>   hw/alpha/dp264.c             |  1 +
> >>   hw/arm/fsl-imx6.c            |  5 +++++
> >>   hw/arm/fsl-imx6ul.c          |  5 +++++
> >>   hw/arm/fsl-imx7.c            |  5 +++++
> >>   hw/arm/highbank.c            |  1 +
> >>   hw/arm/mcimx6ul-evk.c        |  1 +
> >>   hw/arm/mcimx7d-sabre.c       |  3 +++
> >>   hw/arm/raspi.c               |  2 ++
> >>   hw/arm/realview.c            |  1 +
> >>   hw/arm/sabrelite.c           |  1 +
> >>   hw/arm/vexpress.c            |  3 +++
> >>   hw/arm/virt.c                |  7 +++++++
> >>   hw/arm/xlnx-zynqmp.c         |  7 +++++++
> >>   hw/cpu/core.c                |  3 +++
> >>   hw/hppa/machine.c            |  4 ++++
> >>   hw/i386/acpi-build.c         |  3 +++
> >>   hw/i386/kvmvapic.c           |  5 +++++
> >>   hw/i386/pc.c                 | 12 +++++++++++
> >>   hw/mips/boston.c             |  1 +
> >>   hw/mips/mips_malta.c         |  9 +++++++++
> >>   hw/openrisc/openrisc_sim.c   |  1 +
> >>   hw/ppc/e500.c                |  3 +++
> >>   hw/ppc/mac_newworld.c        |  2 ++
> >>   hw/ppc/mac_oldworld.c        |  2 ++
> >>   hw/ppc/pnv.c                 |  3 +++
> >>   hw/ppc/prep.c                |  2 ++
> >>   hw/ppc/spapr.c               | 29 ++++++++++++++++++++++++++
> >>   hw/ppc/spapr_rtas.c          |  3 +++
> >>   hw/riscv/sifive_e.c          |  4 ++++
> >>   hw/riscv/sifive_plic.c       |  3 +++
> >>   hw/riscv/sifive_u.c          |  4 ++++
> >>   hw/riscv/spike.c             |  2 ++
> >>   hw/riscv/virt.c              |  1 +
> >>   hw/s390x/s390-virtio-ccw.c   |  2 ++
> >>   hw/s390x/sclp.c              |  1 +
> >>   hw/smbios/smbios.c           | 11 ++++++++++
> >>   hw/sparc/sun4m.c             |  2 ++
> >>   hw/sparc64/sun4u.c           |  2 ++
> >>   hw/xtensa/sim.c              |  1 +
> >>   hw/xtensa/xtfpga.c           |  1 +
> >>   include/hw/arm/virt.h        |  2 +-
> >>   include/hw/boards.h          |  8 ++++++++
> >>   include/sysemu/sysemu.h      |  2 +-
> >>   migration/postcopy-ram.c     |  7 +++++++
> >>   numa.c                       |  1 +
> >>   target/arm/cpu.c             |  7 +++++++
> >>   target/i386/cpu.c            |  4 ++++
> >>   target/openrisc/sys_helper.c |  5 +++++
> >>   target/s390x/cpu.c           |  3 +++
> >>   target/s390x/excp_helper.c   |  6 ++++++
> >>   tcg/tcg.c                    | 15 ++++++++++++++
> >>   vl.c                         | 48 ++++++++++++++++++++++++--------------------
> >>   57 files changed, 261 insertions(+), 25 deletions(-)
> >>  
> > 
> > 
> >   
> 
>
Re: [Qemu-devel] [PATCH 0/9] refactor cpu topo into machine properties
Posted by Like Xu 5 years ago 
On 2019/4/8 21:26, Igor Mammedov wrote:
> On Thu, 4 Apr 2019 11:26:09 +0800
> Like Xu <like.xu@linux.intel.com> wrote:
> 
>> On 2019/3/29 18:21, Igor Mammedov wrote:
>>> On Fri, 29 Mar 2019 16:48:36 +0800
>>> Like Xu <like.xu@linux.intel.com> wrote:
>>>    
>>>> This patch series make existing cores/threads/sockets into machine
>>>> properties and get rid of global variables they use currently.
>>> Thanks for looking into it!
>>> Its long overdue and rather desired conversion (albeit naive one,
>>> but this series is a good starting point). I'll go over your patches
>>> next week with comments and concrete suggestions how to implement
>>> particular things.
>>
>> Hi Igor, any comments and suggestions on smp machine properties
>> in this patch considering we may add die topology for PCMachine as an
>> extension?
> 
> I've looked at several patches and that it for this series.
> The most comments apply to the patches I've not reviewed as well.

Hi Igor, thanks for your comments, time and patience.

I'll try to fix them in next version ASAP.

> 
>>>    
>>>> Like Xu (9):
>>>>     cpu/topology: add struct CpuTopology to MachineState
>>>>     cpu/topology: add general support for machine properties
>>>>     cpu/topology: add uncommon arch support for smp machine properties
>>>>     cpu/topology: add ARM support for smp machine properties
>>>>     cpu/topology: add i386 support for smp machine properties
>>>>     cpu/topology: add PPC support for smp machine properties
>>>>     cpu/topology: add riscv support for smp machine properties
>>>>     cpu/topology: add s390x support for smp machine properties
>>>>     cpu/topology: replace smp global variables with machine propertie
>>>>
>>>>    accel/kvm/kvm-all.c          |  3 +++
>>>>    backends/hostmem.c           |  4 ++++
>>>>    cpus.c                       |  4 ++++
>>>>    exec.c                       |  2 ++
>>>>    gdbstub.c                    |  7 ++++++-
>>>>    hw/alpha/dp264.c             |  1 +
>>>>    hw/arm/fsl-imx6.c            |  5 +++++
>>>>    hw/arm/fsl-imx6ul.c          |  5 +++++
>>>>    hw/arm/fsl-imx7.c            |  5 +++++
>>>>    hw/arm/highbank.c            |  1 +
>>>>    hw/arm/mcimx6ul-evk.c        |  1 +
>>>>    hw/arm/mcimx7d-sabre.c       |  3 +++
>>>>    hw/arm/raspi.c               |  2 ++
>>>>    hw/arm/realview.c            |  1 +
>>>>    hw/arm/sabrelite.c           |  1 +
>>>>    hw/arm/vexpress.c            |  3 +++
>>>>    hw/arm/virt.c                |  7 +++++++
>>>>    hw/arm/xlnx-zynqmp.c         |  7 +++++++
>>>>    hw/cpu/core.c                |  3 +++
>>>>    hw/hppa/machine.c            |  4 ++++
>>>>    hw/i386/acpi-build.c         |  3 +++
>>>>    hw/i386/kvmvapic.c           |  5 +++++
>>>>    hw/i386/pc.c                 | 12 +++++++++++
>>>>    hw/mips/boston.c             |  1 +
>>>>    hw/mips/mips_malta.c         |  9 +++++++++
>>>>    hw/openrisc/openrisc_sim.c   |  1 +
>>>>    hw/ppc/e500.c                |  3 +++
>>>>    hw/ppc/mac_newworld.c        |  2 ++
>>>>    hw/ppc/mac_oldworld.c        |  2 ++
>>>>    hw/ppc/pnv.c                 |  3 +++
>>>>    hw/ppc/prep.c                |  2 ++
>>>>    hw/ppc/spapr.c               | 29 ++++++++++++++++++++++++++
>>>>    hw/ppc/spapr_rtas.c          |  3 +++
>>>>    hw/riscv/sifive_e.c          |  4 ++++
>>>>    hw/riscv/sifive_plic.c       |  3 +++
>>>>    hw/riscv/sifive_u.c          |  4 ++++
>>>>    hw/riscv/spike.c             |  2 ++
>>>>    hw/riscv/virt.c              |  1 +
>>>>    hw/s390x/s390-virtio-ccw.c   |  2 ++
>>>>    hw/s390x/sclp.c              |  1 +
>>>>    hw/smbios/smbios.c           | 11 ++++++++++
>>>>    hw/sparc/sun4m.c             |  2 ++
>>>>    hw/sparc64/sun4u.c           |  2 ++
>>>>    hw/xtensa/sim.c              |  1 +
>>>>    hw/xtensa/xtfpga.c           |  1 +
>>>>    include/hw/arm/virt.h        |  2 +-
>>>>    include/hw/boards.h          |  8 ++++++++
>>>>    include/sysemu/sysemu.h      |  2 +-
>>>>    migration/postcopy-ram.c     |  7 +++++++
>>>>    numa.c                       |  1 +
>>>>    target/arm/cpu.c             |  7 +++++++
>>>>    target/i386/cpu.c            |  4 ++++
>>>>    target/openrisc/sys_helper.c |  5 +++++
>>>>    target/s390x/cpu.c           |  3 +++
>>>>    target/s390x/excp_helper.c   |  6 ++++++
>>>>    tcg/tcg.c                    | 15 ++++++++++++++
>>>>    vl.c                         | 48 ++++++++++++++++++++++++--------------------
>>>>    57 files changed, 261 insertions(+), 25 deletions(-)
>>>>   
>>>
>>>
>>>    
>>
>>
> 
>

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.