[v5] Support Kconfig in QEMU

[Qemu-devel] [PATCH 01/52] arm: disable CONFIG_SERIAL_ISA

Paolo Bonzini posted 52 patches 7 years ago

Diff against v1 v2 v3 v4 v6
Download mbox

Maintainers: Eduardo Habkost <ehabkost@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Palmer Dabbelt <palmer@sifive.com>, Max Filippov <jcmvbkbc@gmail.com>, Alistair Francis <alistair@alistair23.me>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Max Reitz <mreitz@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Igor Mammedov <imammedo@redhat.com>, Aleksandar Markovic <amarkovic@wavecomp.com>, Fam Zheng <fam@euphon.net>, Cornelia Huck <cohuck@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>, Aleksandar Rikalo <arikalo@wavecomp.com>, Corey Minyard <minyard@acm.org>, Sagar Karandikar <sagark@eecs.berkeley.edu>, Alex Williamson <alex.williamson@redhat.com>, Alberto Garcia <berto@igalia.com>, Anthony Green <green@moxielogic.com>, Jason Wang <jasowang@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>, Greg Kurz <groug@kaod.org>, "Daniel P. Berrangé" <berrange@redhat.com>, Alistair Francis <Alistair.Francis@wdc.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Michael Clark <mjc@sifive.com>, Kevin Wolf <kwolf@redhat.com>, Chris Wulff <crwulff@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>, Stafford Horne <shorne@gmail.com>, Michael Walle <michael@walle.cc>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, David Hildenbrand <david@redhat.com>, Marek Vasut <marex@denx.de>, Paolo Bonzini <pbonzini@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, Peter Maydell <peter.maydell@linaro.org>, Halil Pasic <pasic@linux.ibm.com>, Stefan Berger <stefanb@linux.ibm.com>, John Snow <jsnow@redhat.com>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Christian Borntraeger <borntraeger@de.ibm.com>, Artyom Tarasenko <atar4qemu@gmail.com>, Cleber Rosa <crosa@redhat.com>

There is a newer version of this series

Expand all Fold all

[Qemu-devel] [PATCH 01/52] arm: disable CONFIG_SERIAL_ISA

Posted by Paolo Bonzini 7 years ago

ARM does not have an ISA bus, this device should not be enabled.  Kconfig
catches the contradiction because ARM does not define CONFIG_ISA_BUS.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 default-configs/arm-softmmu.mak | 1 -
 1 file changed, 1 deletion(-)

diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
index 2420491..3c9351f 100644
--- a/default-configs/arm-softmmu.mak
+++ b/default-configs/arm-softmmu.mak
@@ -6,7 +6,6 @@ CONFIG_VGA=y
 CONFIG_NAND=y
 CONFIG_ECC=y
 CONFIG_SERIAL=y
-CONFIG_SERIAL_ISA=y
 CONFIG_PTIMER=y
 CONFIG_SD=y
 CONFIG_MAX7310=y
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH 01/52] arm: disable CONFIG_SERIAL_ISA

Posted by Thomas Huth 7 years ago

On 2019-01-25 11:06, Paolo Bonzini wrote:
> ARM does not have an ISA bus, this device should not be enabled.  Kconfig
> catches the contradiction because ARM does not define CONFIG_ISA_BUS.

That description is a little bit wrong, since ARM includes pci.mak, and
pci.mak enables CONFIG_ISA_BUS=y for the IDE code.

> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  default-configs/arm-softmmu.mak | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index 2420491..3c9351f 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -6,7 +6,6 @@ CONFIG_VGA=y
>  CONFIG_NAND=y
>  CONFIG_ECC=y
>  CONFIG_SERIAL=y
> -CONFIG_SERIAL_ISA=y
>  CONFIG_PTIMER=y
>  CONFIG_SD=y
>  CONFIG_MAX7310=y

Anyway, looking through the code and the description of commit
1401c322c8d431fa750cff8276 I think you're right that CONFIG_SERIAL_ISA
is not required for ARM, so if you change the commit message a little bit:

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [PATCH 01/52] arm: disable CONFIG_SERIAL_ISA

Posted by Paolo Bonzini 7 years ago

On 25/01/19 15:49, Thomas Huth wrote:
> On 2019-01-25 11:06, Paolo Bonzini wrote:
>> ARM does not have an ISA bus, this device should not be enabled.  Kconfig
>> catches the contradiction because ARM does not define CONFIG_ISA_BUS.
> 
> That description is a little bit wrong, since ARM includes pci.mak, and
> pci.mak enables CONFIG_ISA_BUS=y for the IDE code.

Right:

ARM should not have an ISA bus, this device should not be enabled.
Kconfig allows to clean up the dependencies and remove CONFIG_ISA_BUS=y
from ARM, and then catches a contradiction between the hardcoded
CONFIG_SERIAL_ISA=y and CONFIG_ISA_BUS=n.

Paolo

>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  default-configs/arm-softmmu.mak | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
>> index 2420491..3c9351f 100644
>> --- a/default-configs/arm-softmmu.mak
>> +++ b/default-configs/arm-softmmu.mak
>> @@ -6,7 +6,6 @@ CONFIG_VGA=y
>>  CONFIG_NAND=y
>>  CONFIG_ECC=y
>>  CONFIG_SERIAL=y
>> -CONFIG_SERIAL_ISA=y
>>  CONFIG_PTIMER=y
>>  CONFIG_SD=y
>>  CONFIG_MAX7310=y
> 
> Anyway, looking through the code and the description of commit
> 1401c322c8d431fa750cff8276 I think you're right that CONFIG_SERIAL_ISA
> is not required for ARM, so if you change the commit message a little bit:
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>