[Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

Paolo Bonzini posted 51 patches 28 weeks ago
Test docker-mingw@fedora failed
Test asan failed
Test docker-clang@ubuntu failed
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1549562254-41157-1-git-send-email-pbonzini@redhat.com
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, Alistair Francis <alistair@alistair23.me>, Peter Maydell <peter.maydell@linaro.org>, Sagar Karandikar <sagark@eecs.berkeley.edu>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Eduardo Habkost <ehabkost@redhat.com>, Cleber Rosa <crosa@redhat.com>, Michael Walle <michael@walle.cc>, Igor Mammedov <imammedo@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Cornelia Huck <cohuck@redhat.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Palmer Dabbelt <palmer@sifive.com>, Paolo Bonzini <pbonzini@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Christian Borntraeger <borntraeger@de.ibm.com>, Max Reitz <mreitz@redhat.com>, Stefan Berger <stefanb@linux.ibm.com>, Max Filippov <jcmvbkbc@gmail.com>, Jason Wang <jasowang@redhat.com>, Marek Vasut <marex@denx.de>, Stefan Hajnoczi <stefanha@redhat.com>, Corey Minyard <minyard@acm.org>, Gerd Hoffmann <kraxel@redhat.com>, John Snow <jsnow@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, "Michael S. Tsirkin" <mst@redhat.com>, Chris Wulff <crwulff@gmail.com>, Richard Henderson <rth@twiddle.net>, Aleksandar Rikalo <arikalo@wavecomp.com>, Stafford Horne <shorne@gmail.com>, Greg Kurz <groug@kaod.org>, David Gibson <david@gibson.dropbear.id.au>, Alberto Garcia <berto@igalia.com>, Aurelien Jarno <aurelien@aurel32.net>, Fam Zheng <fam@euphon.net>, Artyom Tarasenko <atar4qemu@gmail.com>, Alex Williamson <alex.williamson@redhat.com>, David Hildenbrand <david@redhat.com>, Aleksandar Markovic <amarkovic@wavecomp.com>, Anthony Green <green@moxielogic.com>
.travis.yml                             |   6 +
Kconfig.host                            |  27 ++
Makefile                                |  25 +-
Makefile.target                         |   7 +-
configure                               |  18 +-
default-configs/alpha-softmmu.mak       |  26 +-
default-configs/arm-softmmu.mak         |  15 +-
default-configs/cris-softmmu.mak        |   6 +-
default-configs/hppa-softmmu.mak        |  20 +-
default-configs/hyperv.mak              |   2 -
default-configs/i386-softmmu.mak        |  93 ++---
default-configs/lm32-softmmu.mak        |  12 +-
default-configs/m68k-softmmu.mak        |   4 +-
default-configs/microblaze-softmmu.mak  |  12 +-
default-configs/mips-softmmu-common.mak |  10 +-
default-configs/mips64el-softmmu.mak    |   2 +
default-configs/moxie-softmmu.mak       |   7 +-
default-configs/nios2-softmmu.mak       |   6 +-
default-configs/or1k-softmmu.mak        |   5 +-
default-configs/pci.mak                 |  51 ---
default-configs/ppc-softmmu.mak         |  60 ---
default-configs/ppc64-softmmu.mak       |  13 -
default-configs/riscv32-softmmu.mak     |   6 +-
default-configs/riscv64-softmmu.mak     |   6 +-
default-configs/s390x-softmmu.mak       |  23 +-
default-configs/sh4-softmmu.mak         |  28 +-
default-configs/sh4eb-softmmu.mak       |  22 +-
default-configs/sound.mak               |   4 -
default-configs/sparc-softmmu.mak       |  24 +-
default-configs/sparc64-softmmu.mak     |  25 +-
default-configs/unicore32-softmmu.mak   |   6 +-
default-configs/usb.mak                 |  11 -
default-configs/virtio.mak              |  15 -
default-configs/xtensa-softmmu.mak      |   6 +-
default-configs/xtensaeb-softmmu.mak    |   7 +-
docs/devel/build-system.txt             |   1 -
hw/9pfs/Kconfig                         |   6 +
hw/Kconfig                              |  73 ++++
hw/Makefile.objs                        |   2 +-
hw/acpi/Kconfig                         |  29 ++
hw/adc/Kconfig                          |   2 +
hw/alpha/Kconfig                        |  12 +
hw/arm/Kconfig                          | 123 ++++++
hw/audio/Kconfig                        |  52 +++
hw/block/Kconfig                        |  39 ++
hw/block/Makefile.objs                  |   3 +-
hw/block/dataplane/Makefile.objs        |   2 +-
hw/bt/Kconfig                           |   2 +
hw/char/Kconfig                         |  42 ++
hw/core/Kconfig                         |  11 +
hw/cpu/Kconfig                          |   8 +
hw/cris/Kconfig                         |   9 +
hw/display/Kconfig                      | 108 +++++
hw/display/Makefile.objs                |   4 +-
hw/dma/Kconfig                          |  21 +
hw/gpio/Kconfig                         |   9 +
hw/hppa/Kconfig                         |  10 +
hw/hyperv/Kconfig                       |   8 +
hw/i2c/Kconfig                          |  27 ++
hw/i2c/Makefile.objs                    |   2 +-
hw/i386/Kconfig                         | 100 +++++
hw/i386/Makefile.objs                   |   5 +-
hw/ide/Kconfig                          |  54 +++
hw/input/Kconfig                        |  33 ++
hw/intc/Kconfig                         |  57 +++
hw/ipack/Kconfig                        |   4 +
hw/ipmi/Kconfig                         |  22 +
hw/isa/Kconfig                          |  53 +++
hw/lm32/Kconfig                         |  13 +
hw/m68k/Kconfig                         |   9 +
hw/mem/Kconfig                          |  11 +
hw/microblaze/Kconfig                   |  20 +
hw/mips/Kconfig                         |  21 +
hw/misc/Kconfig                         | 118 ++++++
hw/misc/macio/Kconfig                   |  11 +
hw/moxie/Kconfig                        |   3 +
hw/net/Kconfig                          | 125 ++++++
hw/nios2/Kconfig                        |   8 +
hw/nvram/Kconfig                        |   9 +
hw/openrisc/Kconfig                     |   5 +
hw/pci-bridge/Kconfig                   |  29 ++
hw/pci-host/Kconfig                     |  51 +++
hw/pci/Kconfig                          |   9 +
hw/pci/Makefile.objs                    |   9 +-
hw/pcmcia/Kconfig                       |   2 +
hw/ppc/Kconfig                          | 121 ++++++
hw/riscv/Kconfig                        |  20 +
hw/s390x/Kconfig                        |  11 +
hw/s390x/Makefile.objs                  |   4 +-
hw/scsi/Kconfig                         |  54 +++
hw/scsi/Makefile.objs                   |   2 +-
hw/sd/Kconfig                           |  17 +
hw/sh4/Kconfig                          |  23 ++
hw/smbios/Kconfig                       |   2 +
hw/sparc/Kconfig                        |  26 ++
hw/sparc64/Kconfig                      |  19 +
hw/ssi/Kconfig                          |  18 +
hw/timer/Kconfig                        |  63 +++
hw/tpm/Kconfig                          |  25 ++
hw/tricore/Kconfig                      |   2 +
hw/unicore32/Kconfig                    |   5 +
hw/usb/Kconfig                          |  91 +++++
hw/usb/Makefile.objs                    |   2 +-
hw/vfio/Kconfig                         |  36 ++
hw/virtio/Kconfig                       |  31 ++
hw/virtio/vhost-stub.c                  |  58 +++
hw/watchdog/Kconfig                     |  16 +
hw/xtensa/Kconfig                       |   8 +
rules.mak                               |   2 +-
scripts/make_device_config.sh           |  30 --
scripts/minikconf.py                    | 700 ++++++++++++++++++++++++++++++++
111 files changed, 2917 insertions(+), 465 deletions(-)
create mode 100644 Kconfig.host
delete mode 100644 default-configs/hyperv.mak
delete mode 100644 default-configs/pci.mak
delete mode 100644 default-configs/sound.mak
delete mode 100644 default-configs/usb.mak
delete mode 100644 default-configs/virtio.mak
create mode 100644 hw/9pfs/Kconfig
create mode 100644 hw/Kconfig
create mode 100644 hw/acpi/Kconfig
create mode 100644 hw/adc/Kconfig
create mode 100644 hw/alpha/Kconfig
create mode 100644 hw/arm/Kconfig
create mode 100644 hw/audio/Kconfig
create mode 100644 hw/block/Kconfig
create mode 100644 hw/bt/Kconfig
create mode 100644 hw/char/Kconfig
create mode 100644 hw/core/Kconfig
create mode 100644 hw/cpu/Kconfig
create mode 100644 hw/cris/Kconfig
create mode 100644 hw/display/Kconfig
create mode 100644 hw/dma/Kconfig
create mode 100644 hw/gpio/Kconfig
create mode 100644 hw/hppa/Kconfig
create mode 100644 hw/hyperv/Kconfig
create mode 100644 hw/i2c/Kconfig
create mode 100644 hw/i386/Kconfig
create mode 100644 hw/ide/Kconfig
create mode 100644 hw/input/Kconfig
create mode 100644 hw/intc/Kconfig
create mode 100644 hw/ipack/Kconfig
create mode 100644 hw/ipmi/Kconfig
create mode 100644 hw/isa/Kconfig
create mode 100644 hw/lm32/Kconfig
create mode 100644 hw/m68k/Kconfig
create mode 100644 hw/mem/Kconfig
create mode 100644 hw/microblaze/Kconfig
create mode 100644 hw/mips/Kconfig
create mode 100644 hw/misc/Kconfig
create mode 100644 hw/misc/macio/Kconfig
create mode 100644 hw/moxie/Kconfig
create mode 100644 hw/net/Kconfig
create mode 100644 hw/nios2/Kconfig
create mode 100644 hw/nvram/Kconfig
create mode 100644 hw/openrisc/Kconfig
create mode 100644 hw/pci-bridge/Kconfig
create mode 100644 hw/pci-host/Kconfig
create mode 100644 hw/pci/Kconfig
create mode 100644 hw/pcmcia/Kconfig
create mode 100644 hw/ppc/Kconfig
create mode 100644 hw/riscv/Kconfig
create mode 100644 hw/s390x/Kconfig
create mode 100644 hw/scsi/Kconfig
create mode 100644 hw/sd/Kconfig
create mode 100644 hw/sh4/Kconfig
create mode 100644 hw/smbios/Kconfig
create mode 100644 hw/sparc/Kconfig
create mode 100644 hw/sparc64/Kconfig
create mode 100644 hw/ssi/Kconfig
create mode 100644 hw/timer/Kconfig
create mode 100644 hw/tpm/Kconfig
create mode 100644 hw/tricore/Kconfig
create mode 100644 hw/unicore32/Kconfig
create mode 100644 hw/usb/Kconfig
create mode 100644 hw/vfio/Kconfig
create mode 100644 hw/virtio/Kconfig
create mode 100644 hw/watchdog/Kconfig
create mode 100644 hw/xtensa/Kconfig
delete mode 100644 scripts/make_device_config.sh
create mode 100644 scripts/minikconf.py

[Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

Posted by Paolo Bonzini 28 weeks ago
Now dropping RFC... Documentation is still lacking, but all targets except
ARM and MIPS are converted.  I'll let the respective maintainers decide what
timeframe they prefer.

defconfig and allnoconfig are supported as configure options, respectively
--with-default-devices (the default) and --without-default-devices.
Optional devices are listed in .mak files as commented-out "#CONFIG_FOO=n"
lines and marked as "imply" directives in Kconfig files.  ("Imply" is
new in this iteration).

For the previous discussions on the Kconfig design, see
http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg02827.html

The first part, with the Makefile changes, has already been committed.
This is only the second part therefore, with the conversion.

The last patch is needed for now to support --without-default-devices
builds, but it will go away with the other pending patches to revamp
vhost configuration.

Summary of changes from v5:
- new directive "imply" for soft dependencies (really a "reverse
  default y if ..." that is placed under the condition symbol,
  used for PCI_DEVICES and TEST_DEVICES
- conversion of various boards
- TEST_DEVICES patch moved earlier
- new patches for various subsystems and boards
- tested Xen

I still have _not_ procesed Philippe's review though.

Paolo

Paolo Bonzini (39):
  minikconfig: add parser skeleton
  minikconfig: add AST
  minikconfig: add semantic analysis
  kconfig: introduce kconfig files
  build: switch to Kconfig
  minikconfig: implement allnoconfig and defconfig modes
  kconfig: introduce CONFIG_TEST_DEVICES
  ide: express dependencies with Kconfig
  build: convert pci.mak to Kconfig
  build: convert sound.mak to Kconfig
  build: convert usb.mak to Kconfig
  block: fix recursion in hw/block/dataplane
  scsi: express dependencies with Kconfig
  isa: express dependencies with kconfig
  i386: express dependencies with Kconfig
  i2c: express dependencies with Kconfig
  ptimer: express dependencies with Kconfig
  vfio: express vfio dependencies with Kconfig
  tpm: express dependencies with Kconfig
  isa: express SuperIO dependencies with Kconfig
  ssi: express dependencies with kconfig
  sd: express dependencies with kconfig
  ipmi: express dependencies with kconfig
  alpha-softmmu.mak: express dependencies with Kconfig
  cris-softmmu.mak: express dependencies with Kconfig
  hppa-softmmu.mak: express dependencies with Kconfig
  lm32-softmmu.mak: express dependencies with Kconfig
  m68k-softmmu.mak: express dependencies with Kconfig
  microblaze-softmmu.mak: express dependencies with Kconfig
  moxie-softmmu.mak: express dependencies with Kconfig
  nios2-softmmu.mak: express dependencies with Kconfig
  or1k-softmmu.mak: express dependencies with Kconfig
  sh4-softmmu.mak: express dependencies with Kconfig
  sparc-softmmu.mak: express dependencies with Kconfig
  sparc64-softmmu.mak: express dependencies with Kconfig
  unicore32-softmmu.mak: express dependencies with Kconfig
  xtensa-softmmu.mak: express dependencies with Kconfig
  .travis.yml: test that no-default-device builds do not regress
  FIXME vhost: add more stubs

Thomas Huth (6):
  ppc64: Express dependencies of 'pseries' and 'powernv' machines with
    kconfig
  ppc: Express dependencies of the 'prep' and '40p' machines with
    kconfig
  ppc: Express dependencies of the Mac machines with kconfig
  ppc: Express dependencies of the Sam460EX machines with kconfig
  ppc: Express dependencies of the embedded machines with kconfig
  s390x: express dependencies with Kconfig

Yang Zhong (6):
  hw/display: make edid configurable
  hw/pci/Makefile.objs: make pcie configurable
  display: express dependencies with kconfig
  hyperv: express dependencies with kconfig
  virtio: express virtio dependencies with Kconfig
  i386-softmmu.mak: remove all CONFIG_* except boards definitions

 .travis.yml                             |   6 +
 Kconfig.host                            |  27 ++
 Makefile                                |  25 +-
 Makefile.target                         |   7 +-
 configure                               |  18 +-
 default-configs/alpha-softmmu.mak       |  26 +-
 default-configs/arm-softmmu.mak         |  15 +-
 default-configs/cris-softmmu.mak        |   6 +-
 default-configs/hppa-softmmu.mak        |  20 +-
 default-configs/hyperv.mak              |   2 -
 default-configs/i386-softmmu.mak        |  93 ++---
 default-configs/lm32-softmmu.mak        |  12 +-
 default-configs/m68k-softmmu.mak        |   4 +-
 default-configs/microblaze-softmmu.mak  |  12 +-
 default-configs/mips-softmmu-common.mak |  10 +-
 default-configs/mips64el-softmmu.mak    |   2 +
 default-configs/moxie-softmmu.mak       |   7 +-
 default-configs/nios2-softmmu.mak       |   6 +-
 default-configs/or1k-softmmu.mak        |   5 +-
 default-configs/pci.mak                 |  51 ---
 default-configs/ppc-softmmu.mak         |  60 ---
 default-configs/ppc64-softmmu.mak       |  13 -
 default-configs/riscv32-softmmu.mak     |   6 +-
 default-configs/riscv64-softmmu.mak     |   6 +-
 default-configs/s390x-softmmu.mak       |  23 +-
 default-configs/sh4-softmmu.mak         |  28 +-
 default-configs/sh4eb-softmmu.mak       |  22 +-
 default-configs/sound.mak               |   4 -
 default-configs/sparc-softmmu.mak       |  24 +-
 default-configs/sparc64-softmmu.mak     |  25 +-
 default-configs/unicore32-softmmu.mak   |   6 +-
 default-configs/usb.mak                 |  11 -
 default-configs/virtio.mak              |  15 -
 default-configs/xtensa-softmmu.mak      |   6 +-
 default-configs/xtensaeb-softmmu.mak    |   7 +-
 docs/devel/build-system.txt             |   1 -
 hw/9pfs/Kconfig                         |   6 +
 hw/Kconfig                              |  73 ++++
 hw/Makefile.objs                        |   2 +-
 hw/acpi/Kconfig                         |  29 ++
 hw/adc/Kconfig                          |   2 +
 hw/alpha/Kconfig                        |  12 +
 hw/arm/Kconfig                          | 123 ++++++
 hw/audio/Kconfig                        |  52 +++
 hw/block/Kconfig                        |  39 ++
 hw/block/Makefile.objs                  |   3 +-
 hw/block/dataplane/Makefile.objs        |   2 +-
 hw/bt/Kconfig                           |   2 +
 hw/char/Kconfig                         |  42 ++
 hw/core/Kconfig                         |  11 +
 hw/cpu/Kconfig                          |   8 +
 hw/cris/Kconfig                         |   9 +
 hw/display/Kconfig                      | 108 +++++
 hw/display/Makefile.objs                |   4 +-
 hw/dma/Kconfig                          |  21 +
 hw/gpio/Kconfig                         |   9 +
 hw/hppa/Kconfig                         |  10 +
 hw/hyperv/Kconfig                       |   8 +
 hw/i2c/Kconfig                          |  27 ++
 hw/i2c/Makefile.objs                    |   2 +-
 hw/i386/Kconfig                         | 100 +++++
 hw/i386/Makefile.objs                   |   5 +-
 hw/ide/Kconfig                          |  54 +++
 hw/input/Kconfig                        |  33 ++
 hw/intc/Kconfig                         |  57 +++
 hw/ipack/Kconfig                        |   4 +
 hw/ipmi/Kconfig                         |  22 +
 hw/isa/Kconfig                          |  53 +++
 hw/lm32/Kconfig                         |  13 +
 hw/m68k/Kconfig                         |   9 +
 hw/mem/Kconfig                          |  11 +
 hw/microblaze/Kconfig                   |  20 +
 hw/mips/Kconfig                         |  21 +
 hw/misc/Kconfig                         | 118 ++++++
 hw/misc/macio/Kconfig                   |  11 +
 hw/moxie/Kconfig                        |   3 +
 hw/net/Kconfig                          | 125 ++++++
 hw/nios2/Kconfig                        |   8 +
 hw/nvram/Kconfig                        |   9 +
 hw/openrisc/Kconfig                     |   5 +
 hw/pci-bridge/Kconfig                   |  29 ++
 hw/pci-host/Kconfig                     |  51 +++
 hw/pci/Kconfig                          |   9 +
 hw/pci/Makefile.objs                    |   9 +-
 hw/pcmcia/Kconfig                       |   2 +
 hw/ppc/Kconfig                          | 121 ++++++
 hw/riscv/Kconfig                        |  20 +
 hw/s390x/Kconfig                        |  11 +
 hw/s390x/Makefile.objs                  |   4 +-
 hw/scsi/Kconfig                         |  54 +++
 hw/scsi/Makefile.objs                   |   2 +-
 hw/sd/Kconfig                           |  17 +
 hw/sh4/Kconfig                          |  23 ++
 hw/smbios/Kconfig                       |   2 +
 hw/sparc/Kconfig                        |  26 ++
 hw/sparc64/Kconfig                      |  19 +
 hw/ssi/Kconfig                          |  18 +
 hw/timer/Kconfig                        |  63 +++
 hw/tpm/Kconfig                          |  25 ++
 hw/tricore/Kconfig                      |   2 +
 hw/unicore32/Kconfig                    |   5 +
 hw/usb/Kconfig                          |  91 +++++
 hw/usb/Makefile.objs                    |   2 +-
 hw/vfio/Kconfig                         |  36 ++
 hw/virtio/Kconfig                       |  31 ++
 hw/virtio/vhost-stub.c                  |  58 +++
 hw/watchdog/Kconfig                     |  16 +
 hw/xtensa/Kconfig                       |   8 +
 rules.mak                               |   2 +-
 scripts/make_device_config.sh           |  30 --
 scripts/minikconf.py                    | 700 ++++++++++++++++++++++++++++++++
 111 files changed, 2917 insertions(+), 465 deletions(-)
 create mode 100644 Kconfig.host
 delete mode 100644 default-configs/hyperv.mak
 delete mode 100644 default-configs/pci.mak
 delete mode 100644 default-configs/sound.mak
 delete mode 100644 default-configs/usb.mak
 delete mode 100644 default-configs/virtio.mak
 create mode 100644 hw/9pfs/Kconfig
 create mode 100644 hw/Kconfig
 create mode 100644 hw/acpi/Kconfig
 create mode 100644 hw/adc/Kconfig
 create mode 100644 hw/alpha/Kconfig
 create mode 100644 hw/arm/Kconfig
 create mode 100644 hw/audio/Kconfig
 create mode 100644 hw/block/Kconfig
 create mode 100644 hw/bt/Kconfig
 create mode 100644 hw/char/Kconfig
 create mode 100644 hw/core/Kconfig
 create mode 100644 hw/cpu/Kconfig
 create mode 100644 hw/cris/Kconfig
 create mode 100644 hw/display/Kconfig
 create mode 100644 hw/dma/Kconfig
 create mode 100644 hw/gpio/Kconfig
 create mode 100644 hw/hppa/Kconfig
 create mode 100644 hw/hyperv/Kconfig
 create mode 100644 hw/i2c/Kconfig
 create mode 100644 hw/i386/Kconfig
 create mode 100644 hw/ide/Kconfig
 create mode 100644 hw/input/Kconfig
 create mode 100644 hw/intc/Kconfig
 create mode 100644 hw/ipack/Kconfig
 create mode 100644 hw/ipmi/Kconfig
 create mode 100644 hw/isa/Kconfig
 create mode 100644 hw/lm32/Kconfig
 create mode 100644 hw/m68k/Kconfig
 create mode 100644 hw/mem/Kconfig
 create mode 100644 hw/microblaze/Kconfig
 create mode 100644 hw/mips/Kconfig
 create mode 100644 hw/misc/Kconfig
 create mode 100644 hw/misc/macio/Kconfig
 create mode 100644 hw/moxie/Kconfig
 create mode 100644 hw/net/Kconfig
 create mode 100644 hw/nios2/Kconfig
 create mode 100644 hw/nvram/Kconfig
 create mode 100644 hw/openrisc/Kconfig
 create mode 100644 hw/pci-bridge/Kconfig
 create mode 100644 hw/pci-host/Kconfig
 create mode 100644 hw/pci/Kconfig
 create mode 100644 hw/pcmcia/Kconfig
 create mode 100644 hw/ppc/Kconfig
 create mode 100644 hw/riscv/Kconfig
 create mode 100644 hw/s390x/Kconfig
 create mode 100644 hw/scsi/Kconfig
 create mode 100644 hw/sd/Kconfig
 create mode 100644 hw/sh4/Kconfig
 create mode 100644 hw/smbios/Kconfig
 create mode 100644 hw/sparc/Kconfig
 create mode 100644 hw/sparc64/Kconfig
 create mode 100644 hw/ssi/Kconfig
 create mode 100644 hw/timer/Kconfig
 create mode 100644 hw/tpm/Kconfig
 create mode 100644 hw/tricore/Kconfig
 create mode 100644 hw/unicore32/Kconfig
 create mode 100644 hw/usb/Kconfig
 create mode 100644 hw/vfio/Kconfig
 create mode 100644 hw/virtio/Kconfig
 create mode 100644 hw/watchdog/Kconfig
 create mode 100644 hw/xtensa/Kconfig
 delete mode 100644 scripts/make_device_config.sh
 create mode 100644 scripts/minikconf.py

-- 
1.8.3.1


Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

Posted by no-reply@patchew.org 28 weeks ago
Patchew URL: https://patchew.org/QEMU/1549562254-41157-1-git-send-email-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU
Type: series
Message-id: 1549562254-41157-1-git-send-email-pbonzini@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
7200ddfa38 FIXME vhost: add more stubs
1a1c76cc66 .travis.yml: test that no-default-device builds do not regress
9a0a2fe490 xtensa-softmmu.mak: express dependencies with Kconfig
be618b0b43 unicore32-softmmu.mak: express dependencies with Kconfig
d9ad090d4a sparc64-softmmu.mak: express dependencies with Kconfig
18a4c0d985 sparc-softmmu.mak: express dependencies with Kconfig
f06759a86b sh4-softmmu.mak: express dependencies with Kconfig
3f8d9dac4f s390x: express dependencies with Kconfig
666c38d4f1 or1k-softmmu.mak: express dependencies with Kconfig
e4cf0b120e nios2-softmmu.mak: express dependencies with Kconfig
271e994332 moxie-softmmu.mak: express dependencies with Kconfig
11ac6fe9d4 microblaze-softmmu.mak: express dependencies with Kconfig
8630d29685 m68k-softmmu.mak: express dependencies with Kconfig
bb5b8c48ed lm32-softmmu.mak: express dependencies with Kconfig
47a8eb3fca hppa-softmmu.mak: express dependencies with Kconfig
e37a3f607d cris-softmmu.mak: express dependencies with Kconfig
54b33245e9 alpha-softmmu.mak: express dependencies with Kconfig
8c3918f633 ppc: Express dependencies of the embedded machines with kconfig
3be3c9af37 ppc: Express dependencies of the Sam460EX machines with kconfig
19c005fbac ppc: Express dependencies of the Mac machines with kconfig
ebd7936f63 ppc: Express dependencies of the 'prep' and '40p' machines with kconfig
72b67a6b72 ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig
8abc3ebf15 i386-softmmu.mak: remove all CONFIG_* except boards definitions
fcea2b455a ipmi: express dependencies with kconfig
aa72187aaf sd: express dependencies with kconfig
a8c95c0992 ssi: express dependencies with kconfig
d9777923da isa: express SuperIO dependencies with Kconfig
0541b47928 tpm: express dependencies with Kconfig
4ba345db98 virtio: express virtio dependencies with Kconfig
bffc349b2c vfio: express vfio dependencies with Kconfig
905e23c6c3 hyperv: express dependencies with kconfig
ac6ba4de7d display: express dependencies with kconfig
c20f81c354 ptimer: express dependencies with Kconfig
0d7ab9a784 i2c: express dependencies with Kconfig
93dfb44abb i386: express dependencies with Kconfig
5ce435607c isa: express dependencies with kconfig
5aeac2faf1 scsi: express dependencies with Kconfig
3f49df6864 block: fix recursion in hw/block/dataplane
2dae6c9a73 build: convert usb.mak to Kconfig
c41b2385df build: convert sound.mak to Kconfig
d207ac71cd build: convert pci.mak to Kconfig
332759d72e hw/pci/Makefile.objs: make pcie configurable
964747cd17 ide: express dependencies with Kconfig
4ba9b1e195 kconfig: introduce CONFIG_TEST_DEVICES
857d8ddaa2 minikconfig: implement allnoconfig and defconfig modes
adbcf89201 build: switch to Kconfig
4705a32c99 kconfig: introduce kconfig files
c261ec8294 hw/display: make edid configurable
1abaa5246a minikconfig: add semantic analysis
81983df1c9 minikconfig: add AST
439b9a844f minikconfig: add parser skeleton

=== OUTPUT BEGIN ===
1/51 Checking commit 439b9a844f55 (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

WARNING: line over 80 characters
#259: FILE: scripts/minikconf.py:220:
+                           'Expected identifier starting with "CONFIG_"', TOK_NONE)

WARNING: line over 80 characters
#358: FILE: scripts/minikconf.py:319:
+            raise KconfigParserError(self, 'expected "source", "config", identifier, '

WARNING: line over 80 characters
#384: FILE: scripts/minikconf.py:345:
+            raise KconfigParserError(self, 'expected "source", "config" or identifier')

ERROR: line over 90 characters
#409: FILE: scripts/minikconf.py:370:
+        if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '|':

WARNING: line over 80 characters
#464: FILE: scripts/minikconf.py:425:
+            while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_':

total: 1 errors, 5 warnings, 441 lines checked

Patch 1/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/51 Checking commit 81983df1c912 (minikconfig: add AST)
WARNING: line over 80 characters
#89: FILE: scripts/minikconf.py:90:
+                return "config %s default %s if %s" % (self.dest, value, self.cond)

total: 0 errors, 1 warnings, 177 lines checked

Patch 2/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/51 Checking commit 1abaa5246a66 (minikconfig: add semantic analysis)
ERROR: line over 90 characters
#112: FILE: scripts/minikconf.py:106:
+                raise KconfigParserError('contradiction between clauses when setting %s' % self)

WARNING: line over 80 characters
#215: FILE: scripts/minikconf.py:218:
+            debug_print(i, "->", [str(x) for x in self.referenced_vars[i].outgoing])

total: 1 errors, 1 warnings, 235 lines checked

Patch 3/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/51 Checking commit c261ec829410 (hw/display: make edid configurable)
5/51 Checking commit 4705a32c99d7 (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44: 
new file mode 100644

WARNING: line over 80 characters
#1753: FILE: scripts/minikconf.py:653:
+        print ("%s: at least one argument is required" % argv[0], file=sys.stderr)

total: 0 errors, 2 warnings, 1354 lines checked

Patch 5/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/51 Checking commit adbcf89201ae (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#504: 
deleted file mode 100644

total: 0 errors, 1 warnings, 346 lines checked

Patch 6/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/51 Checking commit 857d8ddaa222 (minikconfig: implement allnoconfig and defconfig modes)
8/51 Checking commit 4ba9b1e19593 (kconfig: introduce CONFIG_TEST_DEVICES)
9/51 Checking commit 964747cd173c (ide: express dependencies with Kconfig)
10/51 Checking commit 332759d72e52 (hw/pci/Makefile.objs: make pcie configurable)
11/51 Checking commit d207ac71cd9b (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#145: 
deleted file mode 100644

total: 0 errors, 1 warnings, 490 lines checked

Patch 11/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/51 Checking commit c41b2385df3d (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#68: 
deleted file mode 100644

total: 0 errors, 1 warnings, 49 lines checked

Patch 12/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/51 Checking commit 2dae6c9a738c (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#158: 
deleted file mode 100644

total: 0 errors, 1 warnings, 165 lines checked

Patch 13/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/51 Checking commit 3f49df6864b2 (block: fix recursion in hw/block/dataplane)
15/51 Checking commit 5aeac2faf1bf (scsi: express dependencies with Kconfig)
16/51 Checking commit 5ce435607c6b (isa: express dependencies with kconfig)
17/51 Checking commit 93dfb44abb9b (i386: express dependencies with Kconfig)
18/51 Checking commit 0d7ab9a7842d (i2c: express dependencies with Kconfig)
19/51 Checking commit c20f81c35457 (ptimer: express dependencies with Kconfig)
20/51 Checking commit ac6ba4de7df3 (display: express dependencies with kconfig)
21/51 Checking commit 905e23c6c3a2 (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
deleted file mode 100644

total: 0 errors, 1 warnings, 21 lines checked

Patch 21/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/51 Checking commit bffc349b2c0f (vfio: express vfio dependencies with Kconfig)
23/51 Checking commit 4ba345db983e (virtio: express virtio dependencies with Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
deleted file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 23/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/51 Checking commit 0541b479283c (tpm: express dependencies with Kconfig)
25/51 Checking commit d9777923da08 (isa: express SuperIO dependencies with Kconfig)
26/51 Checking commit a8c95c0992f8 (ssi: express dependencies with kconfig)
27/51 Checking commit aa72187aaf99 (sd: express dependencies with kconfig)
28/51 Checking commit fcea2b455a6b (ipmi: express dependencies with kconfig)
29/51 Checking commit 8abc3ebf15b4 (i386-softmmu.mak: remove all CONFIG_* except boards definitions)
30/51 Checking commit 72b67a6b72a6 (ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig)
31/51 Checking commit ebd7936f6328 (ppc: Express dependencies of the 'prep' and '40p' machines with kconfig)
32/51 Checking commit 19c005fbac41 (ppc: Express dependencies of the Mac machines with kconfig)
33/51 Checking commit 3be3c9af3716 (ppc: Express dependencies of the Sam460EX machines with kconfig)
34/51 Checking commit 8c3918f63317 (ppc: Express dependencies of the embedded machines with kconfig)
35/51 Checking commit 54b33245e960 (alpha-softmmu.mak: express dependencies with Kconfig)
36/51 Checking commit e37a3f607d8e (cris-softmmu.mak: express dependencies with Kconfig)
37/51 Checking commit 47a8eb3fca4a (hppa-softmmu.mak: express dependencies with Kconfig)
38/51 Checking commit bb5b8c48ed9f (lm32-softmmu.mak: express dependencies with Kconfig)
39/51 Checking commit 8630d296858c (m68k-softmmu.mak: express dependencies with Kconfig)
40/51 Checking commit 11ac6fe9d46c (microblaze-softmmu.mak: express dependencies with Kconfig)
41/51 Checking commit 271e994332e0 (moxie-softmmu.mak: express dependencies with Kconfig)
42/51 Checking commit e4cf0b120e83 (nios2-softmmu.mak: express dependencies with Kconfig)
43/51 Checking commit 666c38d4f18d (or1k-softmmu.mak: express dependencies with Kconfig)
44/51 Checking commit 3f8d9dac4fb7 (s390x: express dependencies with Kconfig)
45/51 Checking commit f06759a86b89 (sh4-softmmu.mak: express dependencies with Kconfig)
46/51 Checking commit 18a4c0d9850d (sparc-softmmu.mak: express dependencies with Kconfig)
47/51 Checking commit d9ad090d4a13 (sparc64-softmmu.mak: express dependencies with Kconfig)
48/51 Checking commit be618b0b435d (unicore32-softmmu.mak: express dependencies with Kconfig)
49/51 Checking commit 9a0a2fe4903c (xtensa-softmmu.mak: express dependencies with Kconfig)
50/51 Checking commit 1a1c76cc663f (.travis.yml: test that no-default-device builds do not regress)
51/51 Checking commit 7200ddfa38df (FIXME vhost: add more stubs)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1549562254-41157-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

Posted by no-reply@patchew.org 28 weeks ago
Patchew URL: https://patchew.org/QEMU/1549562254-41157-1-git-send-email-pbonzini@redhat.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=14
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/1549562254-41157-1-git-send-email-pbonzini@redhat.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

Posted by no-reply@patchew.org 28 weeks ago
Patchew URL: https://patchew.org/QEMU/1549562254-41157-1-git-send-email-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU
Message-id: 1549562254-41157-1-git-send-email-pbonzini@redhat.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/1549562254-41157-1-git-send-email-pbonzini@redhat.com -> patchew/1549562254-41157-1-git-send-email-pbonzini@redhat.com
 - [tag update]      patchew/20190206112729.37761-1-sgarzare@redhat.com -> patchew/20190206112729.37761-1-sgarzare@redhat.com
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '441a84d3a642a10b948369c63f32367e8ff6395b'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
93b682d FIXME vhost: add more stubs
a680cbc .travis.yml: test that no-default-device builds do not regress
cc20b7d xtensa-softmmu.mak: express dependencies with Kconfig
4c76d60 unicore32-softmmu.mak: express dependencies with Kconfig
8b1a2a0 sparc64-softmmu.mak: express dependencies with Kconfig
f793fdb sparc-softmmu.mak: express dependencies with Kconfig
7818fa3 sh4-softmmu.mak: express dependencies with Kconfig
3c21174 s390x: express dependencies with Kconfig
5fec60a or1k-softmmu.mak: express dependencies with Kconfig
8935c96 nios2-softmmu.mak: express dependencies with Kconfig
1d6c5fc moxie-softmmu.mak: express dependencies with Kconfig
11526a8 microblaze-softmmu.mak: express dependencies with Kconfig
6df43a7 m68k-softmmu.mak: express dependencies with Kconfig
cd79031 lm32-softmmu.mak: express dependencies with Kconfig
590c6d7 hppa-softmmu.mak: express dependencies with Kconfig
36cbe45 cris-softmmu.mak: express dependencies with Kconfig
c0cd646 alpha-softmmu.mak: express dependencies with Kconfig
6e35550 ppc: Express dependencies of the embedded machines with kconfig
ae2bd5b ppc: Express dependencies of the Sam460EX machines with kconfig
60bb2e0 ppc: Express dependencies of the Mac machines with kconfig
cf8ea0c ppc: Express dependencies of the 'prep' and '40p' machines with kconfig
93a603f ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig
2822ebf i386-softmmu.mak: remove all CONFIG_* except boards definitions
db3747c ipmi: express dependencies with kconfig
ca1cfdc sd: express dependencies with kconfig
82ee5e5 ssi: express dependencies with kconfig
0d5d1a4 isa: express SuperIO dependencies with Kconfig
544527c tpm: express dependencies with Kconfig
cb5c04b virtio: express virtio dependencies with Kconfig
e4395d9 vfio: express vfio dependencies with Kconfig
7fabf6c hyperv: express dependencies with kconfig
43c36b4 display: express dependencies with kconfig
c5adaaa ptimer: express dependencies with Kconfig
140aadc i2c: express dependencies with Kconfig
192e864 i386: express dependencies with Kconfig
85489ef isa: express dependencies with kconfig
99b3ea3 scsi: express dependencies with Kconfig
b0e9cf2 block: fix recursion in hw/block/dataplane
c68b073 build: convert usb.mak to Kconfig
8b145f0 build: convert sound.mak to Kconfig
1b95de0 build: convert pci.mak to Kconfig
4af86cc hw/pci/Makefile.objs: make pcie configurable
2e3edb8 ide: express dependencies with Kconfig
f7bef1a kconfig: introduce CONFIG_TEST_DEVICES
07a8e88 minikconfig: implement allnoconfig and defconfig modes
fb806e7 build: switch to Kconfig
a95f7d7 kconfig: introduce kconfig files
1a214f8 hw/display: make edid configurable
5a8f973 minikconfig: add semantic analysis
b5c153b minikconfig: add AST
bff5450 minikconfig: add parser skeleton

=== OUTPUT BEGIN ===
1/51 Checking commit bff54501a325 (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

WARNING: line over 80 characters
#260: FILE: scripts/minikconf.py:220:
+                           'Expected identifier starting with "CONFIG_"', TOK_NONE)

WARNING: line over 80 characters
#359: FILE: scripts/minikconf.py:319:
+            raise KconfigParserError(self, 'expected "source", "config", identifier, '

WARNING: line over 80 characters
#385: FILE: scripts/minikconf.py:345:
+            raise KconfigParserError(self, 'expected "source", "config" or identifier')

ERROR: line over 90 characters
#410: FILE: scripts/minikconf.py:370:
+        if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '|':

WARNING: line over 80 characters
#465: FILE: scripts/minikconf.py:425:
+            while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_':

total: 1 errors, 5 warnings, 441 lines checked

Patch 1/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/51 Checking commit b5c153b336bc (minikconfig: add AST)
WARNING: line over 80 characters
#90: FILE: scripts/minikconf.py:90:
+                return "config %s default %s if %s" % (self.dest, value, self.cond)

total: 0 errors, 1 warnings, 177 lines checked

Patch 2/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/51 Checking commit 5a8f973a474b (minikconfig: add semantic analysis)
ERROR: line over 90 characters
#113: FILE: scripts/minikconf.py:106:
+                raise KconfigParserError('contradiction between clauses when setting %s' % self)

WARNING: line over 80 characters
#216: FILE: scripts/minikconf.py:218:
+            debug_print(i, "->", [str(x) for x in self.referenced_vars[i].outgoing])

total: 1 errors, 1 warnings, 235 lines checked

Patch 3/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/51 Checking commit 1a214f85cdc5 (hw/display: make edid configurable)
5/51 Checking commit a95f7d77eaa6 (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
new file mode 100644

WARNING: line over 80 characters
#1754: FILE: scripts/minikconf.py:653:
+        print ("%s: at least one argument is required" % argv[0], file=sys.stderr)

total: 0 errors, 2 warnings, 1354 lines checked

Patch 5/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/51 Checking commit fb806e7b4c22 (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#505: 
deleted file mode 100644

total: 0 errors, 1 warnings, 346 lines checked

Patch 6/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/51 Checking commit 07a8e8887f8f (minikconfig: implement allnoconfig and defconfig modes)
8/51 Checking commit f7bef1a4465c (kconfig: introduce CONFIG_TEST_DEVICES)
9/51 Checking commit 2e3edb87047c (ide: express dependencies with Kconfig)
10/51 Checking commit 4af86cca3ac9 (hw/pci/Makefile.objs: make pcie configurable)
11/51 Checking commit 1b95de09b99d (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#146: 
deleted file mode 100644

total: 0 errors, 1 warnings, 490 lines checked

Patch 11/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/51 Checking commit 8b145f086b06 (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
deleted file mode 100644

total: 0 errors, 1 warnings, 49 lines checked

Patch 12/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/51 Checking commit c68b0736c930 (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#159: 
deleted file mode 100644

total: 0 errors, 1 warnings, 165 lines checked

Patch 13/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/51 Checking commit b0e9cf200479 (block: fix recursion in hw/block/dataplane)
15/51 Checking commit 99b3ea362b48 (scsi: express dependencies with Kconfig)
16/51 Checking commit 85489ef70ed6 (isa: express dependencies with kconfig)
17/51 Checking commit 192e864c272e (i386: express dependencies with Kconfig)
18/51 Checking commit 140aadc9a3b0 (i2c: express dependencies with Kconfig)
19/51 Checking commit c5adaaac9bf3 (ptimer: express dependencies with Kconfig)
20/51 Checking commit 43c36b4f580c (display: express dependencies with kconfig)
21/51 Checking commit 7fabf6c407db (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
deleted file mode 100644

total: 0 errors, 1 warnings, 21 lines checked

Patch 21/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/51 Checking commit e4395d9fa320 (vfio: express vfio dependencies with Kconfig)
23/51 Checking commit cb5c04b9b9a6 (virtio: express virtio dependencies with Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
deleted file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 23/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/51 Checking commit 544527ca12b3 (tpm: express dependencies with Kconfig)
25/51 Checking commit 0d5d1a45050c (isa: express SuperIO dependencies with Kconfig)
26/51 Checking commit 82ee5e5ac54f (ssi: express dependencies with kconfig)
27/51 Checking commit ca1cfdc1c94d (sd: express dependencies with kconfig)
28/51 Checking commit db3747cb76b5 (ipmi: express dependencies with kconfig)
29/51 Checking commit 2822ebf95eae (i386-softmmu.mak: remove all CONFIG_* except boards definitions)
30/51 Checking commit 93a603ffb1f9 (ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig)
31/51 Checking commit cf8ea0c0e8bb (ppc: Express dependencies of the 'prep' and '40p' machines with kconfig)
32/51 Checking commit 60bb2e0d9b9d (ppc: Express dependencies of the Mac machines with kconfig)
33/51 Checking commit ae2bd5b51dc8 (ppc: Express dependencies of the Sam460EX machines with kconfig)
34/51 Checking commit 6e35550c423c (ppc: Express dependencies of the embedded machines with kconfig)
35/51 Checking commit c0cd646ca528 (alpha-softmmu.mak: express dependencies with Kconfig)
36/51 Checking commit 36cbe4512aa8 (cris-softmmu.mak: express dependencies with Kconfig)
37/51 Checking commit 590c6d7ee0a4 (hppa-softmmu.mak: express dependencies with Kconfig)
38/51 Checking commit cd790311a0a8 (lm32-softmmu.mak: express dependencies with Kconfig)
39/51 Checking commit 6df43a796440 (m68k-softmmu.mak: express dependencies with Kconfig)
40/51 Checking commit 11526a8d824c (microblaze-softmmu.mak: express dependencies with Kconfig)
41/51 Checking commit 1d6c5fce702d (moxie-softmmu.mak: express dependencies with Kconfig)
42/51 Checking commit 8935c96d830f (nios2-softmmu.mak: express dependencies with Kconfig)
43/51 Checking commit 5fec60ab4271 (or1k-softmmu.mak: express dependencies with Kconfig)
44/51 Checking commit 3c211749036b (s390x: express dependencies with Kconfig)
45/51 Checking commit 7818fa31aef9 (sh4-softmmu.mak: express dependencies with Kconfig)
46/51 Checking commit f793fdb00094 (sparc-softmmu.mak: express dependencies with Kconfig)
47/51 Checking commit 8b1a2a062a57 (sparc64-softmmu.mak: express dependencies with Kconfig)
48/51 Checking commit 4c76d60e7289 (unicore32-softmmu.mak: express dependencies with Kconfig)
49/51 Checking commit cc20b7d742e3 (xtensa-softmmu.mak: express dependencies with Kconfig)
50/51 Checking commit a680cbcdd4e2 (.travis.yml: test that no-default-device builds do not regress)
51/51 Checking commit 93b682d47aba (FIXME vhost: add more stubs)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1549562254-41157-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

Posted by no-reply@patchew.org 28 weeks ago
Patchew URL: https://patchew.org/QEMU/1549562254-41157-1-git-send-email-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU
Type: series
Message-id: 1549562254-41157-1-git-send-email-pbonzini@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
93b682d47a FIXME vhost: add more stubs
a680cbcdd4 .travis.yml: test that no-default-device builds do not regress
cc20b7d742 xtensa-softmmu.mak: express dependencies with Kconfig
4c76d60e72 unicore32-softmmu.mak: express dependencies with Kconfig
8b1a2a062a sparc64-softmmu.mak: express dependencies with Kconfig
f793fdb000 sparc-softmmu.mak: express dependencies with Kconfig
7818fa31ae sh4-softmmu.mak: express dependencies with Kconfig
3c21174903 s390x: express dependencies with Kconfig
5fec60ab42 or1k-softmmu.mak: express dependencies with Kconfig
8935c96d83 nios2-softmmu.mak: express dependencies with Kconfig
1d6c5fce70 moxie-softmmu.mak: express dependencies with Kconfig
11526a8d82 microblaze-softmmu.mak: express dependencies with Kconfig
6df43a7964 m68k-softmmu.mak: express dependencies with Kconfig
cd790311a0 lm32-softmmu.mak: express dependencies with Kconfig
590c6d7ee0 hppa-softmmu.mak: express dependencies with Kconfig
36cbe4512a cris-softmmu.mak: express dependencies with Kconfig
c0cd646ca5 alpha-softmmu.mak: express dependencies with Kconfig
6e35550c42 ppc: Express dependencies of the embedded machines with kconfig
ae2bd5b51d ppc: Express dependencies of the Sam460EX machines with kconfig
60bb2e0d9b ppc: Express dependencies of the Mac machines with kconfig
cf8ea0c0e8 ppc: Express dependencies of the 'prep' and '40p' machines with kconfig
93a603ffb1 ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig
2822ebf95e i386-softmmu.mak: remove all CONFIG_* except boards definitions
db3747cb76 ipmi: express dependencies with kconfig
ca1cfdc1c9 sd: express dependencies with kconfig
82ee5e5ac5 ssi: express dependencies with kconfig
0d5d1a4505 isa: express SuperIO dependencies with Kconfig
544527ca12 tpm: express dependencies with Kconfig
cb5c04b9b9 virtio: express virtio dependencies with Kconfig
e4395d9fa3 vfio: express vfio dependencies with Kconfig
7fabf6c407 hyperv: express dependencies with kconfig
43c36b4f58 display: express dependencies with kconfig
c5adaaac9b ptimer: express dependencies with Kconfig
140aadc9a3 i2c: express dependencies with Kconfig
192e864c27 i386: express dependencies with Kconfig
85489ef70e isa: express dependencies with kconfig
99b3ea362b scsi: express dependencies with Kconfig
b0e9cf2004 block: fix recursion in hw/block/dataplane
c68b0736c9 build: convert usb.mak to Kconfig
8b145f086b build: convert sound.mak to Kconfig
1b95de09b9 build: convert pci.mak to Kconfig
4af86cca3a hw/pci/Makefile.objs: make pcie configurable
2e3edb8704 ide: express dependencies with Kconfig
f7bef1a446 kconfig: introduce CONFIG_TEST_DEVICES
07a8e8887f minikconfig: implement allnoconfig and defconfig modes
fb806e7b4c build: switch to Kconfig
a95f7d77ea kconfig: introduce kconfig files
1a214f85cd hw/display: make edid configurable
5a8f973a47 minikconfig: add semantic analysis
b5c153b336 minikconfig: add AST
bff54501a3 minikconfig: add parser skeleton

=== OUTPUT BEGIN ===
1/51 Checking commit bff54501a325 (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

WARNING: line over 80 characters
#260: FILE: scripts/minikconf.py:220:
+                           'Expected identifier starting with "CONFIG_"', TOK_NONE)

WARNING: line over 80 characters
#359: FILE: scripts/minikconf.py:319:
+            raise KconfigParserError(self, 'expected "source", "config", identifier, '

WARNING: line over 80 characters
#385: FILE: scripts/minikconf.py:345:
+            raise KconfigParserError(self, 'expected "source", "config" or identifier')

ERROR: line over 90 characters
#410: FILE: scripts/minikconf.py:370:
+        if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '|':

WARNING: line over 80 characters
#465: FILE: scripts/minikconf.py:425:
+            while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_':

total: 1 errors, 5 warnings, 441 lines checked

Patch 1/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/51 Checking commit b5c153b336bc (minikconfig: add AST)
WARNING: line over 80 characters
#90: FILE: scripts/minikconf.py:90:
+                return "config %s default %s if %s" % (self.dest, value, self.cond)

total: 0 errors, 1 warnings, 177 lines checked

Patch 2/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/51 Checking commit 5a8f973a474b (minikconfig: add semantic analysis)
ERROR: line over 90 characters
#113: FILE: scripts/minikconf.py:106:
+                raise KconfigParserError('contradiction between clauses when setting %s' % self)

WARNING: line over 80 characters
#216: FILE: scripts/minikconf.py:218:
+            debug_print(i, "->", [str(x) for x in self.referenced_vars[i].outgoing])

total: 1 errors, 1 warnings, 235 lines checked

Patch 3/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/51 Checking commit 1a214f85cdc5 (hw/display: make edid configurable)
5/51 Checking commit a95f7d77eaa6 (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
new file mode 100644

WARNING: line over 80 characters
#1754: FILE: scripts/minikconf.py:653:
+        print ("%s: at least one argument is required" % argv[0], file=sys.stderr)

total: 0 errors, 2 warnings, 1354 lines checked

Patch 5/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/51 Checking commit fb806e7b4c22 (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#505: 
deleted file mode 100644

total: 0 errors, 1 warnings, 346 lines checked

Patch 6/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/51 Checking commit 07a8e8887f8f (minikconfig: implement allnoconfig and defconfig modes)
8/51 Checking commit f7bef1a4465c (kconfig: introduce CONFIG_TEST_DEVICES)
9/51 Checking commit 2e3edb87047c (ide: express dependencies with Kconfig)
10/51 Checking commit 4af86cca3ac9 (hw/pci/Makefile.objs: make pcie configurable)
11/51 Checking commit 1b95de09b99d (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#146: 
deleted file mode 100644

total: 0 errors, 1 warnings, 490 lines checked

Patch 11/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/51 Checking commit 8b145f086b06 (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
deleted file mode 100644

total: 0 errors, 1 warnings, 49 lines checked

Patch 12/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/51 Checking commit c68b0736c930 (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#159: 
deleted file mode 100644

total: 0 errors, 1 warnings, 165 lines checked

Patch 13/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/51 Checking commit b0e9cf200479 (block: fix recursion in hw/block/dataplane)
15/51 Checking commit 99b3ea362b48 (scsi: express dependencies with Kconfig)
16/51 Checking commit 85489ef70ed6 (isa: express dependencies with kconfig)
17/51 Checking commit 192e864c272e (i386: express dependencies with Kconfig)
18/51 Checking commit 140aadc9a3b0 (i2c: express dependencies with Kconfig)
19/51 Checking commit c5adaaac9bf3 (ptimer: express dependencies with Kconfig)
20/51 Checking commit 43c36b4f580c (display: express dependencies with kconfig)
21/51 Checking commit 7fabf6c407db (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
deleted file mode 100644

total: 0 errors, 1 warnings, 21 lines checked

Patch 21/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/51 Checking commit e4395d9fa320 (vfio: express vfio dependencies with Kconfig)
23/51 Checking commit cb5c04b9b9a6 (virtio: express virtio dependencies with Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
deleted file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 23/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/51 Checking commit 544527ca12b3 (tpm: express dependencies with Kconfig)
25/51 Checking commit 0d5d1a45050c (isa: express SuperIO dependencies with Kconfig)
26/51 Checking commit 82ee5e5ac54f (ssi: express dependencies with kconfig)
27/51 Checking commit ca1cfdc1c94d (sd: express dependencies with kconfig)
28/51 Checking commit db3747cb76b5 (ipmi: express dependencies with kconfig)
29/51 Checking commit 2822ebf95eae (i386-softmmu.mak: remove all CONFIG_* except boards definitions)
30/51 Checking commit 93a603ffb1f9 (ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig)
31/51 Checking commit cf8ea0c0e8bb (ppc: Express dependencies of the 'prep' and '40p' machines with kconfig)
32/51 Checking commit 60bb2e0d9b9d (ppc: Express dependencies of the Mac machines with kconfig)
33/51 Checking commit ae2bd5b51dc8 (ppc: Express dependencies of the Sam460EX machines with kconfig)
34/51 Checking commit 6e35550c423c (ppc: Express dependencies of the embedded machines with kconfig)
35/51 Checking commit c0cd646ca528 (alpha-softmmu.mak: express dependencies with Kconfig)
36/51 Checking commit 36cbe4512aa8 (cris-softmmu.mak: express dependencies with Kconfig)
37/51 Checking commit 590c6d7ee0a4 (hppa-softmmu.mak: express dependencies with Kconfig)
38/51 Checking commit cd790311a0a8 (lm32-softmmu.mak: express dependencies with Kconfig)
39/51 Checking commit 6df43a796440 (m68k-softmmu.mak: express dependencies with Kconfig)
40/51 Checking commit 11526a8d824c (microblaze-softmmu.mak: express dependencies with Kconfig)
41/51 Checking commit 1d6c5fce702d (moxie-softmmu.mak: express dependencies with Kconfig)
42/51 Checking commit 8935c96d830f (nios2-softmmu.mak: express dependencies with Kconfig)
43/51 Checking commit 5fec60ab4271 (or1k-softmmu.mak: express dependencies with Kconfig)
44/51 Checking commit 3c211749036b (s390x: express dependencies with Kconfig)
45/51 Checking commit 7818fa31aef9 (sh4-softmmu.mak: express dependencies with Kconfig)
46/51 Checking commit f793fdb00094 (sparc-softmmu.mak: express dependencies with Kconfig)
47/51 Checking commit 8b1a2a062a57 (sparc64-softmmu.mak: express dependencies with Kconfig)
48/51 Checking commit 4c76d60e7289 (unicore32-softmmu.mak: express dependencies with Kconfig)
49/51 Checking commit cc20b7d742e3 (xtensa-softmmu.mak: express dependencies with Kconfig)
50/51 Checking commit a680cbcdd4e2 (.travis.yml: test that no-default-device builds do not regress)
51/51 Checking commit 93b682d47aba (FIXME vhost: add more stubs)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1549562254-41157-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

Posted by Michael S. Tsirkin 28 weeks ago
On Thu, Feb 07, 2019 at 06:56:43PM +0100, Paolo Bonzini wrote:
> Now dropping RFC... Documentation is still lacking, but all targets except
> ARM and MIPS are converted.  I'll let the respective maintainers decide what
> timeframe they prefer.
> 
> defconfig and allnoconfig are supported as configure options, respectively
> --with-default-devices (the default) and --without-default-devices.
> Optional devices are listed in .mak files as commented-out "#CONFIG_FOO=n"
> lines and marked as "imply" directives in Kconfig files.  ("Imply" is
> new in this iteration).

I would much appreciate it if you change your patch posting
scripts to include the version on all patches.

That can be done using --subject-prefix or -vX flags of
git-format-patch rather than tweaking the cover letter only.

The issue is that if someone is only copied on a specific
patch in the set, absence of version makes it hard to
reason about the history.

It also makes it hard to map patches to series if one
jumps between mailboxes.


> For the previous discussions on the Kconfig design, see
> http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg02827.html
> 
> The first part, with the Makefile changes, has already been committed.
> This is only the second part therefore, with the conversion.
> 
> The last patch is needed for now to support --without-default-devices
> builds, but it will go away with the other pending patches to revamp
> vhost configuration.

patchset itself:

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>



> Summary of changes from v5:
> - new directive "imply" for soft dependencies (really a "reverse
>   default y if ..." that is placed under the condition symbol,
>   used for PCI_DEVICES and TEST_DEVICES
> - conversion of various boards
> - TEST_DEVICES patch moved earlier
> - new patches for various subsystems and boards
> - tested Xen
> 
> I still have _not_ procesed Philippe's review though.
> 
> Paolo
> 
> Paolo Bonzini (39):
>   minikconfig: add parser skeleton
>   minikconfig: add AST
>   minikconfig: add semantic analysis
>   kconfig: introduce kconfig files
>   build: switch to Kconfig
>   minikconfig: implement allnoconfig and defconfig modes
>   kconfig: introduce CONFIG_TEST_DEVICES
>   ide: express dependencies with Kconfig
>   build: convert pci.mak to Kconfig
>   build: convert sound.mak to Kconfig
>   build: convert usb.mak to Kconfig
>   block: fix recursion in hw/block/dataplane
>   scsi: express dependencies with Kconfig
>   isa: express dependencies with kconfig
>   i386: express dependencies with Kconfig
>   i2c: express dependencies with Kconfig
>   ptimer: express dependencies with Kconfig
>   vfio: express vfio dependencies with Kconfig
>   tpm: express dependencies with Kconfig
>   isa: express SuperIO dependencies with Kconfig
>   ssi: express dependencies with kconfig
>   sd: express dependencies with kconfig
>   ipmi: express dependencies with kconfig
>   alpha-softmmu.mak: express dependencies with Kconfig
>   cris-softmmu.mak: express dependencies with Kconfig
>   hppa-softmmu.mak: express dependencies with Kconfig
>   lm32-softmmu.mak: express dependencies with Kconfig
>   m68k-softmmu.mak: express dependencies with Kconfig
>   microblaze-softmmu.mak: express dependencies with Kconfig
>   moxie-softmmu.mak: express dependencies with Kconfig
>   nios2-softmmu.mak: express dependencies with Kconfig
>   or1k-softmmu.mak: express dependencies with Kconfig
>   sh4-softmmu.mak: express dependencies with Kconfig
>   sparc-softmmu.mak: express dependencies with Kconfig
>   sparc64-softmmu.mak: express dependencies with Kconfig
>   unicore32-softmmu.mak: express dependencies with Kconfig
>   xtensa-softmmu.mak: express dependencies with Kconfig
>   .travis.yml: test that no-default-device builds do not regress
>   FIXME vhost: add more stubs
> 
> Thomas Huth (6):
>   ppc64: Express dependencies of 'pseries' and 'powernv' machines with
>     kconfig
>   ppc: Express dependencies of the 'prep' and '40p' machines with
>     kconfig
>   ppc: Express dependencies of the Mac machines with kconfig
>   ppc: Express dependencies of the Sam460EX machines with kconfig
>   ppc: Express dependencies of the embedded machines with kconfig
>   s390x: express dependencies with Kconfig
> 
> Yang Zhong (6):
>   hw/display: make edid configurable
>   hw/pci/Makefile.objs: make pcie configurable
>   display: express dependencies with kconfig
>   hyperv: express dependencies with kconfig
>   virtio: express virtio dependencies with Kconfig
>   i386-softmmu.mak: remove all CONFIG_* except boards definitions
> 
>  .travis.yml                             |   6 +
>  Kconfig.host                            |  27 ++
>  Makefile                                |  25 +-
>  Makefile.target                         |   7 +-
>  configure                               |  18 +-
>  default-configs/alpha-softmmu.mak       |  26 +-
>  default-configs/arm-softmmu.mak         |  15 +-
>  default-configs/cris-softmmu.mak        |   6 +-
>  default-configs/hppa-softmmu.mak        |  20 +-
>  default-configs/hyperv.mak              |   2 -
>  default-configs/i386-softmmu.mak        |  93 ++---
>  default-configs/lm32-softmmu.mak        |  12 +-
>  default-configs/m68k-softmmu.mak        |   4 +-
>  default-configs/microblaze-softmmu.mak  |  12 +-
>  default-configs/mips-softmmu-common.mak |  10 +-
>  default-configs/mips64el-softmmu.mak    |   2 +
>  default-configs/moxie-softmmu.mak       |   7 +-
>  default-configs/nios2-softmmu.mak       |   6 +-
>  default-configs/or1k-softmmu.mak        |   5 +-
>  default-configs/pci.mak                 |  51 ---
>  default-configs/ppc-softmmu.mak         |  60 ---
>  default-configs/ppc64-softmmu.mak       |  13 -
>  default-configs/riscv32-softmmu.mak     |   6 +-
>  default-configs/riscv64-softmmu.mak     |   6 +-
>  default-configs/s390x-softmmu.mak       |  23 +-
>  default-configs/sh4-softmmu.mak         |  28 +-
>  default-configs/sh4eb-softmmu.mak       |  22 +-
>  default-configs/sound.mak               |   4 -
>  default-configs/sparc-softmmu.mak       |  24 +-
>  default-configs/sparc64-softmmu.mak     |  25 +-
>  default-configs/unicore32-softmmu.mak   |   6 +-
>  default-configs/usb.mak                 |  11 -
>  default-configs/virtio.mak              |  15 -
>  default-configs/xtensa-softmmu.mak      |   6 +-
>  default-configs/xtensaeb-softmmu.mak    |   7 +-
>  docs/devel/build-system.txt             |   1 -
>  hw/9pfs/Kconfig                         |   6 +
>  hw/Kconfig                              |  73 ++++
>  hw/Makefile.objs                        |   2 +-
>  hw/acpi/Kconfig                         |  29 ++
>  hw/adc/Kconfig                          |   2 +
>  hw/alpha/Kconfig                        |  12 +
>  hw/arm/Kconfig                          | 123 ++++++
>  hw/audio/Kconfig                        |  52 +++
>  hw/block/Kconfig                        |  39 ++
>  hw/block/Makefile.objs                  |   3 +-
>  hw/block/dataplane/Makefile.objs        |   2 +-
>  hw/bt/Kconfig                           |   2 +
>  hw/char/Kconfig                         |  42 ++
>  hw/core/Kconfig                         |  11 +
>  hw/cpu/Kconfig                          |   8 +
>  hw/cris/Kconfig                         |   9 +
>  hw/display/Kconfig                      | 108 +++++
>  hw/display/Makefile.objs                |   4 +-
>  hw/dma/Kconfig                          |  21 +
>  hw/gpio/Kconfig                         |   9 +
>  hw/hppa/Kconfig                         |  10 +
>  hw/hyperv/Kconfig                       |   8 +
>  hw/i2c/Kconfig                          |  27 ++
>  hw/i2c/Makefile.objs                    |   2 +-
>  hw/i386/Kconfig                         | 100 +++++
>  hw/i386/Makefile.objs                   |   5 +-
>  hw/ide/Kconfig                          |  54 +++
>  hw/input/Kconfig                        |  33 ++
>  hw/intc/Kconfig                         |  57 +++
>  hw/ipack/Kconfig                        |   4 +
>  hw/ipmi/Kconfig                         |  22 +
>  hw/isa/Kconfig                          |  53 +++
>  hw/lm32/Kconfig                         |  13 +
>  hw/m68k/Kconfig                         |   9 +
>  hw/mem/Kconfig                          |  11 +
>  hw/microblaze/Kconfig                   |  20 +
>  hw/mips/Kconfig                         |  21 +
>  hw/misc/Kconfig                         | 118 ++++++
>  hw/misc/macio/Kconfig                   |  11 +
>  hw/moxie/Kconfig                        |   3 +
>  hw/net/Kconfig                          | 125 ++++++
>  hw/nios2/Kconfig                        |   8 +
>  hw/nvram/Kconfig                        |   9 +
>  hw/openrisc/Kconfig                     |   5 +
>  hw/pci-bridge/Kconfig                   |  29 ++
>  hw/pci-host/Kconfig                     |  51 +++
>  hw/pci/Kconfig                          |   9 +
>  hw/pci/Makefile.objs                    |   9 +-
>  hw/pcmcia/Kconfig                       |   2 +
>  hw/ppc/Kconfig                          | 121 ++++++
>  hw/riscv/Kconfig                        |  20 +
>  hw/s390x/Kconfig                        |  11 +
>  hw/s390x/Makefile.objs                  |   4 +-
>  hw/scsi/Kconfig                         |  54 +++
>  hw/scsi/Makefile.objs                   |   2 +-
>  hw/sd/Kconfig                           |  17 +
>  hw/sh4/Kconfig                          |  23 ++
>  hw/smbios/Kconfig                       |   2 +
>  hw/sparc/Kconfig                        |  26 ++
>  hw/sparc64/Kconfig                      |  19 +
>  hw/ssi/Kconfig                          |  18 +
>  hw/timer/Kconfig                        |  63 +++
>  hw/tpm/Kconfig                          |  25 ++
>  hw/tricore/Kconfig                      |   2 +
>  hw/unicore32/Kconfig                    |   5 +
>  hw/usb/Kconfig                          |  91 +++++
>  hw/usb/Makefile.objs                    |   2 +-
>  hw/vfio/Kconfig                         |  36 ++
>  hw/virtio/Kconfig                       |  31 ++
>  hw/virtio/vhost-stub.c                  |  58 +++
>  hw/watchdog/Kconfig                     |  16 +
>  hw/xtensa/Kconfig                       |   8 +
>  rules.mak                               |   2 +-
>  scripts/make_device_config.sh           |  30 --
>  scripts/minikconf.py                    | 700 ++++++++++++++++++++++++++++++++
>  111 files changed, 2917 insertions(+), 465 deletions(-)
>  create mode 100644 Kconfig.host
>  delete mode 100644 default-configs/hyperv.mak
>  delete mode 100644 default-configs/pci.mak
>  delete mode 100644 default-configs/sound.mak
>  delete mode 100644 default-configs/usb.mak
>  delete mode 100644 default-configs/virtio.mak
>  create mode 100644 hw/9pfs/Kconfig
>  create mode 100644 hw/Kconfig
>  create mode 100644 hw/acpi/Kconfig
>  create mode 100644 hw/adc/Kconfig
>  create mode 100644 hw/alpha/Kconfig
>  create mode 100644 hw/arm/Kconfig
>  create mode 100644 hw/audio/Kconfig
>  create mode 100644 hw/block/Kconfig
>  create mode 100644 hw/bt/Kconfig
>  create mode 100644 hw/char/Kconfig
>  create mode 100644 hw/core/Kconfig
>  create mode 100644 hw/cpu/Kconfig
>  create mode 100644 hw/cris/Kconfig
>  create mode 100644 hw/display/Kconfig
>  create mode 100644 hw/dma/Kconfig
>  create mode 100644 hw/gpio/Kconfig
>  create mode 100644 hw/hppa/Kconfig
>  create mode 100644 hw/hyperv/Kconfig
>  create mode 100644 hw/i2c/Kconfig
>  create mode 100644 hw/i386/Kconfig
>  create mode 100644 hw/ide/Kconfig
>  create mode 100644 hw/input/Kconfig
>  create mode 100644 hw/intc/Kconfig
>  create mode 100644 hw/ipack/Kconfig
>  create mode 100644 hw/ipmi/Kconfig
>  create mode 100644 hw/isa/Kconfig
>  create mode 100644 hw/lm32/Kconfig
>  create mode 100644 hw/m68k/Kconfig
>  create mode 100644 hw/mem/Kconfig
>  create mode 100644 hw/microblaze/Kconfig
>  create mode 100644 hw/mips/Kconfig
>  create mode 100644 hw/misc/Kconfig
>  create mode 100644 hw/misc/macio/Kconfig
>  create mode 100644 hw/moxie/Kconfig
>  create mode 100644 hw/net/Kconfig
>  create mode 100644 hw/nios2/Kconfig
>  create mode 100644 hw/nvram/Kconfig
>  create mode 100644 hw/openrisc/Kconfig
>  create mode 100644 hw/pci-bridge/Kconfig
>  create mode 100644 hw/pci-host/Kconfig
>  create mode 100644 hw/pci/Kconfig
>  create mode 100644 hw/pcmcia/Kconfig
>  create mode 100644 hw/ppc/Kconfig
>  create mode 100644 hw/riscv/Kconfig
>  create mode 100644 hw/s390x/Kconfig
>  create mode 100644 hw/scsi/Kconfig
>  create mode 100644 hw/sd/Kconfig
>  create mode 100644 hw/sh4/Kconfig
>  create mode 100644 hw/smbios/Kconfig
>  create mode 100644 hw/sparc/Kconfig
>  create mode 100644 hw/sparc64/Kconfig
>  create mode 100644 hw/ssi/Kconfig
>  create mode 100644 hw/timer/Kconfig
>  create mode 100644 hw/tpm/Kconfig
>  create mode 100644 hw/tricore/Kconfig
>  create mode 100644 hw/unicore32/Kconfig
>  create mode 100644 hw/usb/Kconfig
>  create mode 100644 hw/vfio/Kconfig
>  create mode 100644 hw/virtio/Kconfig
>  create mode 100644 hw/watchdog/Kconfig
>  create mode 100644 hw/xtensa/Kconfig
>  delete mode 100644 scripts/make_device_config.sh
>  create mode 100644 scripts/minikconf.py
> 
> -- 
> 1.8.3.1
> 

Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

Posted by no-reply@patchew.org 28 weeks ago
Patchew URL: https://patchew.org/QEMU/1549562254-41157-1-git-send-email-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU
Message-id: 1549562254-41157-1-git-send-email-pbonzini@redhat.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   4f0444f..d55451d  master     -> master
 * [new tag]         patchew/1549562254-41157-1-git-send-email-pbonzini@redhat.com -> patchew/1549562254-41157-1-git-send-email-pbonzini@redhat.com
 * [new tag]         patchew/20190207180012.27303-1-crosa@redhat.com -> patchew/20190207180012.27303-1-crosa@redhat.com
 * [new tag]         patchew/20190207181422.4907-1-peter.maydell@linaro.org -> patchew/20190207181422.4907-1-peter.maydell@linaro.org
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '441a84d3a642a10b948369c63f32367e8ff6395b'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
7200ddf FIXME vhost: add more stubs
1a1c76c .travis.yml: test that no-default-device builds do not regress
9a0a2fe xtensa-softmmu.mak: express dependencies with Kconfig
be618b0 unicore32-softmmu.mak: express dependencies with Kconfig
d9ad090 sparc64-softmmu.mak: express dependencies with Kconfig
18a4c0d sparc-softmmu.mak: express dependencies with Kconfig
f06759a sh4-softmmu.mak: express dependencies with Kconfig
3f8d9da s390x: express dependencies with Kconfig
666c38d or1k-softmmu.mak: express dependencies with Kconfig
e4cf0b1 nios2-softmmu.mak: express dependencies with Kconfig
271e994 moxie-softmmu.mak: express dependencies with Kconfig
11ac6fe microblaze-softmmu.mak: express dependencies with Kconfig
8630d29 m68k-softmmu.mak: express dependencies with Kconfig
bb5b8c4 lm32-softmmu.mak: express dependencies with Kconfig
47a8eb3 hppa-softmmu.mak: express dependencies with Kconfig
e37a3f6 cris-softmmu.mak: express dependencies with Kconfig
54b3324 alpha-softmmu.mak: express dependencies with Kconfig
8c3918f ppc: Express dependencies of the embedded machines with kconfig
3be3c9a ppc: Express dependencies of the Sam460EX machines with kconfig
19c005f ppc: Express dependencies of the Mac machines with kconfig
ebd7936 ppc: Express dependencies of the 'prep' and '40p' machines with kconfig
72b67a6 ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig
8abc3eb i386-softmmu.mak: remove all CONFIG_* except boards definitions
fcea2b4 ipmi: express dependencies with kconfig
aa72187 sd: express dependencies with kconfig
a8c95c0 ssi: express dependencies with kconfig
d977792 isa: express SuperIO dependencies with Kconfig
0541b47 tpm: express dependencies with Kconfig
4ba345d virtio: express virtio dependencies with Kconfig
bffc349 vfio: express vfio dependencies with Kconfig
905e23c hyperv: express dependencies with kconfig
ac6ba4d display: express dependencies with kconfig
c20f81c ptimer: express dependencies with Kconfig
0d7ab9a i2c: express dependencies with Kconfig
93dfb44 i386: express dependencies with Kconfig
5ce4356 isa: express dependencies with kconfig
5aeac2f scsi: express dependencies with Kconfig
3f49df6 block: fix recursion in hw/block/dataplane
2dae6c9 build: convert usb.mak to Kconfig
c41b238 build: convert sound.mak to Kconfig
d207ac7 build: convert pci.mak to Kconfig
332759d hw/pci/Makefile.objs: make pcie configurable
964747c ide: express dependencies with Kconfig
4ba9b1e kconfig: introduce CONFIG_TEST_DEVICES
857d8dd minikconfig: implement allnoconfig and defconfig modes
adbcf89 build: switch to Kconfig
4705a32 kconfig: introduce kconfig files
c261ec8 hw/display: make edid configurable
1abaa52 minikconfig: add semantic analysis
81983df minikconfig: add AST
439b9a8 minikconfig: add parser skeleton

=== OUTPUT BEGIN ===
1/51 Checking commit 439b9a844f55 (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

WARNING: line over 80 characters
#259: FILE: scripts/minikconf.py:220:
+                           'Expected identifier starting with "CONFIG_"', TOK_NONE)

WARNING: line over 80 characters
#358: FILE: scripts/minikconf.py:319:
+            raise KconfigParserError(self, 'expected "source", "config", identifier, '

WARNING: line over 80 characters
#384: FILE: scripts/minikconf.py:345:
+            raise KconfigParserError(self, 'expected "source", "config" or identifier')

ERROR: line over 90 characters
#409: FILE: scripts/minikconf.py:370:
+        if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '|':

WARNING: line over 80 characters
#464: FILE: scripts/minikconf.py:425:
+            while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_':

total: 1 errors, 5 warnings, 441 lines checked

Patch 1/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/51 Checking commit 81983df1c912 (minikconfig: add AST)
WARNING: line over 80 characters
#89: FILE: scripts/minikconf.py:90:
+                return "config %s default %s if %s" % (self.dest, value, self.cond)

total: 0 errors, 1 warnings, 177 lines checked

Patch 2/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/51 Checking commit 1abaa5246a66 (minikconfig: add semantic analysis)
ERROR: line over 90 characters
#112: FILE: scripts/minikconf.py:106:
+                raise KconfigParserError('contradiction between clauses when setting %s' % self)

WARNING: line over 80 characters
#215: FILE: scripts/minikconf.py:218:
+            debug_print(i, "->", [str(x) for x in self.referenced_vars[i].outgoing])

total: 1 errors, 1 warnings, 235 lines checked

Patch 3/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/51 Checking commit c261ec829410 (hw/display: make edid configurable)
5/51 Checking commit 4705a32c99d7 (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44: 
new file mode 100644

WARNING: line over 80 characters
#1753: FILE: scripts/minikconf.py:653:
+        print ("%s: at least one argument is required" % argv[0], file=sys.stderr)

total: 0 errors, 2 warnings, 1354 lines checked

Patch 5/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/51 Checking commit adbcf89201ae (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#504: 
deleted file mode 100644

total: 0 errors, 1 warnings, 346 lines checked

Patch 6/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/51 Checking commit 857d8ddaa222 (minikconfig: implement allnoconfig and defconfig modes)
8/51 Checking commit 4ba9b1e19593 (kconfig: introduce CONFIG_TEST_DEVICES)
9/51 Checking commit 964747cd173c (ide: express dependencies with Kconfig)
10/51 Checking commit 332759d72e52 (hw/pci/Makefile.objs: make pcie configurable)
11/51 Checking commit d207ac71cd9b (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#145: 
deleted file mode 100644

total: 0 errors, 1 warnings, 490 lines checked

Patch 11/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/51 Checking commit c41b2385df3d (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#68: 
deleted file mode 100644

total: 0 errors, 1 warnings, 49 lines checked

Patch 12/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/51 Checking commit 2dae6c9a738c (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#158: 
deleted file mode 100644

total: 0 errors, 1 warnings, 165 lines checked

Patch 13/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/51 Checking commit 3f49df6864b2 (block: fix recursion in hw/block/dataplane)
15/51 Checking commit 5aeac2faf1bf (scsi: express dependencies with Kconfig)
16/51 Checking commit 5ce435607c6b (isa: express dependencies with kconfig)
17/51 Checking commit 93dfb44abb9b (i386: express dependencies with Kconfig)
18/51 Checking commit 0d7ab9a7842d (i2c: express dependencies with Kconfig)
19/51 Checking commit c20f81c35457 (ptimer: express dependencies with Kconfig)
20/51 Checking commit ac6ba4de7df3 (display: express dependencies with kconfig)
21/51 Checking commit 905e23c6c3a2 (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
deleted file mode 100644

total: 0 errors, 1 warnings, 21 lines checked

Patch 21/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/51 Checking commit bffc349b2c0f (vfio: express vfio dependencies with Kconfig)
23/51 Checking commit 4ba345db983e (virtio: express virtio dependencies with Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
deleted file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 23/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/51 Checking commit 0541b479283c (tpm: express dependencies with Kconfig)
25/51 Checking commit d9777923da08 (isa: express SuperIO dependencies with Kconfig)
26/51 Checking commit a8c95c0992f8 (ssi: express dependencies with kconfig)
27/51 Checking commit aa72187aaf99 (sd: express dependencies with kconfig)
28/51 Checking commit fcea2b455a6b (ipmi: express dependencies with kconfig)
29/51 Checking commit 8abc3ebf15b4 (i386-softmmu.mak: remove all CONFIG_* except boards definitions)
30/51 Checking commit 72b67a6b72a6 (ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig)
31/51 Checking commit ebd7936f6328 (ppc: Express dependencies of the 'prep' and '40p' machines with kconfig)
32/51 Checking commit 19c005fbac41 (ppc: Express dependencies of the Mac machines with kconfig)
33/51 Checking commit 3be3c9af3716 (ppc: Express dependencies of the Sam460EX machines with kconfig)
34/51 Checking commit 8c3918f63317 (ppc: Express dependencies of the embedded machines with kconfig)
35/51 Checking commit 54b33245e960 (alpha-softmmu.mak: express dependencies with Kconfig)
36/51 Checking commit e37a3f607d8e (cris-softmmu.mak: express dependencies with Kconfig)
37/51 Checking commit 47a8eb3fca4a (hppa-softmmu.mak: express dependencies with Kconfig)
38/51 Checking commit bb5b8c48ed9f (lm32-softmmu.mak: express dependencies with Kconfig)
39/51 Checking commit 8630d296858c (m68k-softmmu.mak: express dependencies with Kconfig)
40/51 Checking commit 11ac6fe9d46c (microblaze-softmmu.mak: express dependencies with Kconfig)
41/51 Checking commit 271e994332e0 (moxie-softmmu.mak: express dependencies with Kconfig)
42/51 Checking commit e4cf0b120e83 (nios2-softmmu.mak: express dependencies with Kconfig)
43/51 Checking commit 666c38d4f18d (or1k-softmmu.mak: express dependencies with Kconfig)
44/51 Checking commit 3f8d9dac4fb7 (s390x: express dependencies with Kconfig)
45/51 Checking commit f06759a86b89 (sh4-softmmu.mak: express dependencies with Kconfig)
46/51 Checking commit 18a4c0d9850d (sparc-softmmu.mak: express dependencies with Kconfig)
47/51 Checking commit d9ad090d4a13 (sparc64-softmmu.mak: express dependencies with Kconfig)
48/51 Checking commit be618b0b435d (unicore32-softmmu.mak: express dependencies with Kconfig)
49/51 Checking commit 9a0a2fe4903c (xtensa-softmmu.mak: express dependencies with Kconfig)
50/51 Checking commit 1a1c76cc663f (.travis.yml: test that no-default-device builds do not regress)
51/51 Checking commit 7200ddfa38df (FIXME vhost: add more stubs)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1549562254-41157-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com