[Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes

Michael Clark posted 3 patches 7 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1525810060-36690-1-git-send-email-mjc@sifive.com
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
configure             |  2 +-
hw/riscv/riscv_htif.c | 12 ++++++++----
2 files changed, 9 insertions(+), 5 deletions(-)
[Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes
Posted by Michael Clark 7 years, 5 months ago
The following changes since commit c8b7e627b4269a3bc3ae41d9f420547a47e6d9b9:

  Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-05-04' into staging (2018-05-04 14:42:46 +0100)

are available in the git repository at:

  https://github.com/riscv/riscv-qemu.git tags/riscv-qemu-2.13-minor-fixes-2

for you to fetch changes up to fc28db142ea9331d24d08a6418efa93e258a6876:

  riscv: requires libfdt (2018-05-09 07:57:57 +1200)

----------------------------------------------------------------
RISC-V: QEMU 2.13 Minor Fixes

* Require libfdt when configuring for 'riscv*-softmmu'
* Increase HTIF priority and allow zero base address

Consider backporting to stable branch for 2.12.1

----------------------------------------------------------------
KONRAD Frederic (3):
      riscv: spike: allow base == 0
      riscv: htif: increase the priority of the htif subregion
      riscv: requires libfdt

 configure             |  2 +-
 hw/riscv/riscv_htif.c | 12 ++++++++----
 2 files changed, 9 insertions(+), 5 deletions(-)

-- 
2.7.0


Re: [Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes
Posted by Peter Maydell 7 years, 5 months ago
On 8 May 2018 at 21:07, Michael Clark <mjc@sifive.com> wrote:
> The following changes since commit c8b7e627b4269a3bc3ae41d9f420547a47e6d9b9:
>
>   Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-05-04' into staging (2018-05-04 14:42:46 +0100)
>
> are available in the git repository at:
>
>   https://github.com/riscv/riscv-qemu.git tags/riscv-qemu-2.13-minor-fixes-2
>
> for you to fetch changes up to fc28db142ea9331d24d08a6418efa93e258a6876:
>
>   riscv: requires libfdt (2018-05-09 07:57:57 +1200)
>
> ----------------------------------------------------------------
> RISC-V: QEMU 2.13 Minor Fixes
>
> * Require libfdt when configuring for 'riscv*-softmmu'
> * Increase HTIF priority and allow zero base address
>
> Consider backporting to stable branch for 2.12.1

Ah, if you want something flagged to be backported to
the stable branch, the way to do that is to include
the line "Cc: qemu-stable@nongnu.org" in the commit
message. We use the same approach for flagging things
for stable as the Linux kernel. (Individual submaintainers
are generally in the best position to decide whether
something should go into stable, and this system leaves
that choice up to them. A patch submitter can also suggest
something for stable when you submit the initial patch for
review by adding the Cc: line and cc'ing qemu-stable on the
patchmail.)

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes
Posted by Michael Clark 7 years, 5 months ago
On Wed, May 9, 2018 at 8:49 AM, Peter Maydell <peter.maydell@linaro.org>
wrote:

> On 8 May 2018 at 21:07, Michael Clark <mjc@sifive.com> wrote:
> > The following changes since commit c8b7e627b4269a3bc3ae41d9f42054
> 7a47e6d9b9:
> >
> >   Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-05-04'
> into staging (2018-05-04 14:42:46 +0100)
> >
> > are available in the git repository at:
> >
> >   https://github.com/riscv/riscv-qemu.git tags/riscv-qemu-2.13-minor-
> fixes-2
> >
> > for you to fetch changes up to fc28db142ea9331d24d08a6418efa93e258a6876:
> >
> >   riscv: requires libfdt (2018-05-09 07:57:57 +1200)
> >
> > ----------------------------------------------------------------
> > RISC-V: QEMU 2.13 Minor Fixes
> >
> > * Require libfdt when configuring for 'riscv*-softmmu'
> > * Increase HTIF priority and allow zero base address
> >
> > Consider backporting to stable branch for 2.12.1
>
> Ah, if you want something flagged to be backported to
> the stable branch, the way to do that is to include
> the line "Cc: qemu-stable@nongnu.org" in the commit
> message. We use the same approach for flagging things
> for stable as the Linux kernel. (Individual submaintainers
> are generally in the best position to decide whether
> something should go into stable, and this system leaves
> that choice up to them. A patch submitter can also suggest
> something for stable when you submit the initial patch for
> review by adding the Cc: line and cc'ing qemu-stable on the
> patchmail.)
>

Okay. Given the 'Cc is missing in the commit (only on the cover) I could
send a separate patch.

Or I can respin with the 'Cc on the configure libfdt dependency fix commit
and remove the backport message from the tag...
Re: [Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes
Posted by Peter Maydell 7 years, 5 months ago
On 8 May 2018 at 23:05, Michael Clark <mjc@sifive.com> wrote:
>
>
> On Wed, May 9, 2018 at 8:49 AM, Peter Maydell <peter.maydell@linaro.org>
> wrote:
>>
>> On 8 May 2018 at 21:07, Michael Clark <mjc@sifive.com> wrote:
>> > The following changes since commit
>> > c8b7e627b4269a3bc3ae41d9f420547a47e6d9b9:
>> >
>> >   Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-05-04'
>> > into staging (2018-05-04 14:42:46 +0100)
>> >
>> > are available in the git repository at:
>> >
>> >   https://github.com/riscv/riscv-qemu.git
>> > tags/riscv-qemu-2.13-minor-fixes-2
>> >
>> > for you to fetch changes up to fc28db142ea9331d24d08a6418efa93e258a6876:
>> >
>> >   riscv: requires libfdt (2018-05-09 07:57:57 +1200)
>> >
>> > ----------------------------------------------------------------
>> > RISC-V: QEMU 2.13 Minor Fixes
>> >
>> > * Require libfdt when configuring for 'riscv*-softmmu'
>> > * Increase HTIF priority and allow zero base address
>> >
>> > Consider backporting to stable branch for 2.12.1
>>
>> Ah, if you want something flagged to be backported to
>> the stable branch, the way to do that is to include
>> the line "Cc: qemu-stable@nongnu.org" in the commit
>> message. We use the same approach for flagging things
>> for stable as the Linux kernel. (Individual submaintainers
>> are generally in the best position to decide whether
>> something should go into stable, and this system leaves
>> that choice up to them. A patch submitter can also suggest
>> something for stable when you submit the initial patch for
>> review by adding the Cc: line and cc'ing qemu-stable on the
>> patchmail.)
>
>
> Okay. Given the 'Cc is missing in the commit (only on the cover) I could
> send a separate patch.
>
> Or I can respin with the 'Cc on the configure libfdt dependency fix commit
> and remove the backport message from the tag...

Tag messages are just informational (we use them to help
in writing up the changelog for releases), mostly. So I
would recommend respinning the pullreq with the Cc: line
in the relevant commit(s).

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes
Posted by Michael Clark 7 years, 5 months ago
On Wed, 9 May 2018 at 11:14 PM, Peter Maydell <peter.maydell@linaro.org>
wrote:

> On 8 May 2018 at 23:05, Michael Clark <mjc@sifive.com> wrote:
> >
> >
> > On Wed, May 9, 2018 at 8:49 AM, Peter Maydell <peter.maydell@linaro.org>
> > wrote:
> >>
> >> On 8 May 2018 at 21:07, Michael Clark <mjc@sifive.com> wrote:
> >> > The following changes since commit
> >> > c8b7e627b4269a3bc3ae41d9f420547a47e6d9b9:
> >> >
> >> >   Merge remote-tracking branch
> 'remotes/ericb/tags/pull-nbd-2018-05-04'
> >> > into staging (2018-05-04 14:42:46 +0100)
> >> >
> >> > are available in the git repository at:
> >> >
> >> >   https://github.com/riscv/riscv-qemu.git
> >> > tags/riscv-qemu-2.13-minor-fixes-2
> >> >
> >> > for you to fetch changes up to
> fc28db142ea9331d24d08a6418efa93e258a6876:
> >> >
> >> >   riscv: requires libfdt (2018-05-09 07:57:57 +1200)
> >> >
> >> > ----------------------------------------------------------------
> >> > RISC-V: QEMU 2.13 Minor Fixes
> >> >
> >> > * Require libfdt when configuring for 'riscv*-softmmu'
> >> > * Increase HTIF priority and allow zero base address
> >> >
> >> > Consider backporting to stable branch for 2.12.1
> >>
> >> Ah, if you want something flagged to be backported to
> >> the stable branch, the way to do that is to include
> >> the line "Cc: qemu-stable@nongnu.org" in the commit
> >> message. We use the same approach for flagging things
> >> for stable as the Linux kernel. (Individual submaintainers
> >> are generally in the best position to decide whether
> >> something should go into stable, and this system leaves
> >> that choice up to them. A patch submitter can also suggest
> >> something for stable when you submit the initial patch for
> >> review by adding the Cc: line and cc'ing qemu-stable on the
> >> patchmail.)
> >
> >
> > Okay. Given the 'Cc is missing in the commit (only on the cover) I could
> > send a separate patch.
> >
> > Or I can respin with the 'Cc on the configure libfdt dependency fix
> commit
> > and remove the backport message from the tag...
>
> Tag messages are just informational (we use them to help
> in writing up the changelog for releases), mostly. So I
> would recommend respinning the pullreq with the Cc: line
> in the relevant commit(s).


I respun the PR with a Cc: qemu-stable in the configure libfdt dependency
patch. You should have received a PR with the tag
‘riscv-qemu-2.13-minor-fixes-3’

Thanks,
Michael

>
>