From nobody Wed Oct 29 20:29:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525810289930557.5230060330355; Tue, 8 May 2018 13:11:29 -0700 (PDT) Received: from localhost ([::1]:53178 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG8xN-0005j8-53 for importer@patchew.org; Tue, 08 May 2018 16:11:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG8vE-0003jm-Eg for qemu-devel@nongnu.org; Tue, 08 May 2018 16:09:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fG8vD-0004wN-1j for qemu-devel@nongnu.org; Tue, 08 May 2018 16:09:16 -0400 Received: from mail-pl0-x242.google.com ([2607:f8b0:400e:c01::242]:39276) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fG8vC-0004w4-Re for qemu-devel@nongnu.org; Tue, 08 May 2018 16:09:14 -0400 Received: by mail-pl0-x242.google.com with SMTP id c19-v6so49914pls.6 for ; Tue, 08 May 2018 13:09:14 -0700 (PDT) Received: from localhost.localdomain (122-58-167-38-fibre.bb.spark.co.nz. [122.58.167.38]) by smtp.gmail.com with ESMTPSA id g16-v6sm205171pgn.51.2018.05.08.13.09.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 08 May 2018 13:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=47yxZp5RQJisSZM6EmazIPkrCG4NFFd5tAx3HJkDg/8=; b=bVBnty1YzqQfTT85g8TzsNH/hCjdyOt543HdzDzyq6/utbybzxfuyscbQZMR5t1yNp J6lX5mCaVDttgpTG5XGE+24G4QLZgauFhtTGtvbcRZzy8Jm5zHOaFzWtVhvtCYMsSceO o+7BdoRSu99vJ3pW6cleC1mvhxXc5oqoHyZiVUwnfThDZO0gQQfWhv0ZWdFGPMO5R5Ig 9tmvWK/E04+DDXstdC4ltZk0KKZsl9vTrKW6ZNk8R5frCUz4gNx8kbJIe/76hnDZP08a uRvyQO6LZLlVlEAZA8wgPEa/FQjDD3+sX5JXbdG/6pFsnGTqhPBJqxyF1HIOF7mL411Y zmLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=47yxZp5RQJisSZM6EmazIPkrCG4NFFd5tAx3HJkDg/8=; b=mi29P8tTRrZU3uVaW+zKJZhZGcWgsXtJcN/AoHmWfkQ+KEQZc0ynxcDqK6OXbbWAJd aLh7Y5DRBLm7SPWgYoYYzjo7IaIu6ZijR0Nynz1ghgWIHxtAg0BHxMc2Mpe7LYz7t7e4 cHSh29L/CAggZGyeOJggZwiMgSEAYxSDsJWpHgWXpDjm0GzIk8pbNshDjyVDbkWqItYB NSZZDzJznL9G8ECLh3JythFYy1EK4InX1ieMEsWlXPaQn08vHFTmbcg3Qx+7wtc+zhfY wcWfrv1ntjGTzW6yJvwAvDAb1HwH1XIiM4ySKyPFkeDOt396Kc4o351py7bioivhxQDQ +Sxg== X-Gm-Message-State: ALQs6tBOXPr93DzAb4C8LBhKqobQK6m2yPgDhoopPSKTbnO6NkXWJFrT UsvNsFbsgrehX/sUIEN646H+vx1LVH0= X-Google-Smtp-Source: AB8JxZqf2bXSmEM5fXD9ynGKnbx2j2gFJyhSxI8UxfxyjlIGTwZI91zfktJp2tTL36ULNoBY4PpCIw== X-Received: by 2002:a17:902:5597:: with SMTP id g23-v6mr42944055pli.347.1525810153908; Tue, 08 May 2018 13:09:13 -0700 (PDT) From: Michael Clark To: qemu-devel@nongnu.org Date: Wed, 9 May 2018 08:07:38 +1200 Message-Id: <1525810060-36690-2-git-send-email-mjc@sifive.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1525810060-36690-1-git-send-email-mjc@sifive.com> References: <1525810060-36690-1-git-send-email-mjc@sifive.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::242 Subject: [Qemu-devel] [PULL 1/3] riscv: spike: allow base == 0 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@groups.riscv.org, KONRAD Frederic , Michael Clark Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: KONRAD Frederic The sanity check on base doesn't allow htif to be mapped @0. Check if the symbol exists instead so we can map it where we want. Reviewed-by: Michael Clark Signed-off-by: KONRAD Frederic Signed-off-by: Michael Clark Message-Id: <1525360636-18229-2-git-send-email-frederic.konrad@adacore.com> --- hw/riscv/riscv_htif.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/riscv/riscv_htif.c b/hw/riscv/riscv_htif.c index 3e17f3025106..be252ec8cce9 100644 --- a/hw/riscv/riscv_htif.c +++ b/hw/riscv/riscv_htif.c @@ -41,17 +41,20 @@ } while (0) =20 static uint64_t fromhost_addr, tohost_addr; +static int address_symbol_set; =20 void htif_symbol_callback(const char *st_name, int st_info, uint64_t st_va= lue, - uint64_t st_size) + uint64_t st_size) { if (strcmp("fromhost", st_name) =3D=3D 0) { + address_symbol_set |=3D 1; fromhost_addr =3D st_value; if (st_size !=3D 8) { error_report("HTIF fromhost must be 8 bytes"); exit(1); } } else if (strcmp("tohost", st_name) =3D=3D 0) { + address_symbol_set |=3D 2; tohost_addr =3D st_value; if (st_size !=3D 8) { error_report("HTIF tohost must be 8 bytes"); @@ -248,7 +251,7 @@ HTIFState *htif_mm_init(MemoryRegion *address_space, Me= moryRegion *main_mem, qemu_chr_fe_init(&s->chr, chr, &error_abort); qemu_chr_fe_set_handlers(&s->chr, htif_can_recv, htif_recv, htif_event, htif_be_change, s, NULL, true); - if (base) { + if (address_symbol_set =3D=3D 3) { memory_region_init_io(&s->mmio, NULL, &htif_mm_ops, s, TYPE_HTIF_UART, size); memory_region_add_subregion(address_space, base, &s->mmio); --=20 2.7.0 From nobody Wed Oct 29 20:29:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525810379402605.1063659051902; Tue, 8 May 2018 13:12:59 -0700 (PDT) Received: from localhost ([::1]:53184 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG8yo-0006jj-NK for importer@patchew.org; Tue, 08 May 2018 16:12:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG8vH-0003oH-BZ for qemu-devel@nongnu.org; Tue, 08 May 2018 16:09:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fG8vG-0004yL-AJ for qemu-devel@nongnu.org; Tue, 08 May 2018 16:09:19 -0400 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:37628) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fG8vG-0004xm-3s for qemu-devel@nongnu.org; Tue, 08 May 2018 16:09:18 -0400 Received: by mail-pf0-x241.google.com with SMTP id e9so20473692pfi.4 for ; Tue, 08 May 2018 13:09:18 -0700 (PDT) Received: from localhost.localdomain (122-58-167-38-fibre.bb.spark.co.nz. [122.58.167.38]) by smtp.gmail.com with ESMTPSA id g16-v6sm205171pgn.51.2018.05.08.13.09.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 08 May 2018 13:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=A6e+Oc96R/yne0h81eqyS2dKTfKs0vOv/Aj+HUAk7AM=; b=fE5478ipg1gqCxKVBJqvcIdoi7K3TJYpw9FTpdpxu6ewmFOY5hj+vMc7Tt0UiYSESV gPpM9bCtRE84E4Wmrv0Ahf95UkxZHklHGlBIT/Q7mhMw7csvC2rPk3gSn1kBcAx+6zA8 bT6DxlT7ElquFVyynqsb8Pn5gU6uPahzyUOeucoTJRNjVnfdfyahkQ4UcYkxR0OmnVXw XubItlHtbesOhiM1Da171S/OH+XP3Ex3+k98/HR83LfvKDe8/0Ysng/0pC/zV4v8Ixo5 mL85dhyuaSrOTqLq3QZF0XrKpR9mMdWdLMGTPlH7Hoil4n9r4TkqEx6nlUqx0ZFo/GVV UAjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=A6e+Oc96R/yne0h81eqyS2dKTfKs0vOv/Aj+HUAk7AM=; b=KiQPvacT7qaSRo+Ci6Mbn+n4CTbx8SlNtClfJb7V2Pt+PyFyTEIaHqplx2tgrTO0Rf JgDY3lBU8pLGOu/RZLc4FK5zi6bsbgPMeYNwSYz1fvMtHV4jQ9vwhQXzyf/EVyxhjSkv 4ZykUty4U/dC98s6ztm9sEKcyb/jAD907lWcRYhrz3eKTHiIgK7c6jjr7I5sxzNoQlA1 pDU+8v5UdOVPsm+pZp77PScF/p+y6VpRiGg144v2TcQ7KmwjyYRiMicJUwn3Eq4pTrPd 9JY4hvygV9Av1EqqRC+2wa4GJ51DQwya5i+t098g3iZhwPTBjz7GeMBJJzOVpBcK4/lZ JpkA== X-Gm-Message-State: ALQs6tAoeOT/U/rCeBzOh4atEmLviIgDjCnTRMkYe/+lpXcYHfwrCHAV nOXzgi4R/rG7jAb50NNOSyzbMiu/bW4= X-Google-Smtp-Source: AB8JxZpkSnAtTTgTwP34e1mHwrfuXDbk7Ba3YrrHdwDG0M2v+ffOLhJZaDxzZfAsHV6ZI7oqCVEHGg== X-Received: by 10.98.7.140 with SMTP id 12mr29928893pfh.178.1525810157045; Tue, 08 May 2018 13:09:17 -0700 (PDT) From: Michael Clark To: qemu-devel@nongnu.org Date: Wed, 9 May 2018 08:07:39 +1200 Message-Id: <1525810060-36690-3-git-send-email-mjc@sifive.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1525810060-36690-1-git-send-email-mjc@sifive.com> References: <1525810060-36690-1-git-send-email-mjc@sifive.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::241 Subject: [Qemu-devel] [PULL 2/3] riscv: htif: increase the priority of the htif subregion X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@groups.riscv.org, KONRAD Frederic , Michael Clark Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: KONRAD Frederic The htif device is supposed to be mapped over an other subregion. So increa= se its priority to one to avoid any conflict. Here is the output of info mtree: Before: (qemu) info mtree address-space: memory 0000000000000000-ffffffffffffffff (prio 0, i/o): system 0000000000000000-000000000000000f (prio 0, i/o): riscv.htif.uart 0000000000000000-0000000000011fff (prio 0, ram): riscv.spike.bootrom 0000000002000000-000000000200ffff (prio 0, i/o): riscv.sifive.clint 0000000080000000-0000000087ffffff (prio 0, ram): riscv.spike.ram address-space: I/O 0000000000000000-000000000000ffff (prio 0, i/o): io address-space: cpu-memory-0 0000000000000000-ffffffffffffffff (prio 0, i/o): system 0000000000000000-000000000000000f (prio 0, i/o): riscv.htif.uart 0000000000000000-0000000000011fff (prio 0, ram): riscv.spike.bootrom 0000000002000000-000000000200ffff (prio 0, i/o): riscv.sifive.clint 0000000080000000-0000000087ffffff (prio 0, ram): riscv.spike.ram After: (qemu) info mtree address-space: memory 0000000000000000-ffffffffffffffff (prio 0, i/o): system 0000000000000000-000000000000000f (prio 1, i/o): riscv.htif.uart 0000000000000000-0000000000011fff (prio 0, ram): riscv.spike.bootrom 0000000002000000-000000000200ffff (prio 0, i/o): riscv.sifive.clint 0000000080000000-0000000087ffffff (prio 0, ram): riscv.spike.ram address-space: I/O 0000000000000000-000000000000ffff (prio 0, i/o): io address-space: cpu-memory-0 0000000000000000-ffffffffffffffff (prio 0, i/o): system 0000000000000000-000000000000000f (prio 1, i/o): riscv.htif.uart 0000000000000000-0000000000011fff (prio 0, ram): riscv.spike.bootrom 0000000002000000-000000000200ffff (prio 0, i/o): riscv.sifive.clint 0000000080000000-0000000087ffffff (prio 0, ram): riscv.spike.ram Reviewed-by: Michael Clark Signed-off-by: KONRAD Frederic Signed-off-by: Michael Clark Message-Id: <1525360636-18229-3-git-send-email-frederic.konrad@adacore.com> --- hw/riscv/riscv_htif.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/riscv/riscv_htif.c b/hw/riscv/riscv_htif.c index be252ec8cce9..f73512941fb6 100644 --- a/hw/riscv/riscv_htif.c +++ b/hw/riscv/riscv_htif.c @@ -253,8 +253,9 @@ HTIFState *htif_mm_init(MemoryRegion *address_space, Me= moryRegion *main_mem, htif_be_change, s, NULL, true); if (address_symbol_set =3D=3D 3) { memory_region_init_io(&s->mmio, NULL, &htif_mm_ops, s, - TYPE_HTIF_UART, size); - memory_region_add_subregion(address_space, base, &s->mmio); + TYPE_HTIF_UART, size); + memory_region_add_subregion_overlap(address_space, base, + &s->mmio, 1); } =20 return s; --=20 2.7.0 From nobody Wed Oct 29 20:29:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 152581026866976.73781373475413; Tue, 8 May 2018 13:11:08 -0700 (PDT) Received: from localhost ([::1]:53177 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG8wy-0005QX-Sq for importer@patchew.org; Tue, 08 May 2018 16:11:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG8vK-0003tv-2u for qemu-devel@nongnu.org; Tue, 08 May 2018 16:09:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fG8vJ-0004z8-1n for qemu-devel@nongnu.org; Tue, 08 May 2018 16:09:22 -0400 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:38035) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fG8vI-0004z0-QM for qemu-devel@nongnu.org; Tue, 08 May 2018 16:09:20 -0400 Received: by mail-pf0-x243.google.com with SMTP id o76so24474681pfi.5 for ; Tue, 08 May 2018 13:09:20 -0700 (PDT) Received: from localhost.localdomain (122-58-167-38-fibre.bb.spark.co.nz. [122.58.167.38]) by smtp.gmail.com with ESMTPSA id g16-v6sm205171pgn.51.2018.05.08.13.09.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 08 May 2018 13:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d8vGgQ2oEwhhaiNtir+Jqb/btuYqdp9h0m8TRKn8Kfw=; b=fQEYNRPywfIprp+xOQKnwzu8MZIeCeiRt5XBInEzlb0NpeJrIhFjKQ5egUw6Ts52/J /p5HGByKyYKVGsf5KYkFWAZ/IxmqSRgu8qz3bMANgKB4OrjeZQCxaXJhXUz+b5YXJSSA 1L54iPhbtHwZV3EsdWLelqyDCmPtXS5eoudOAdbH6RtW31crnWL022WRS6vRNIEhUaXu fZscYtPZFx6gcLkDl5GdJEpi5DFvcgH0QefaH07XT4xwThVDFA1RBBxogXubT38/jjvJ 9cfo6wEnAKTnOVSpqnB+k3A7QtxMiaGxp7M94G5ANSNFKYZBccaBL968uDaoyxYG0sl+ du7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d8vGgQ2oEwhhaiNtir+Jqb/btuYqdp9h0m8TRKn8Kfw=; b=Hap1Lfl9HXbFF/86MT3vEBB+DC0Q7IabjaAWdqjm/OiOsJS8SACtCymlaKB0YQoaSM P6ho13i/pRdJjJ/x9B2oVrxrQWhfc2pZXWw8XhLl2cOdMHLAkRD7A089TRyFxrvVXqeV 5sUMnpO+UvlGJiX0taYlgCch3Ut0ymtlIyg7EBpPk0Ka1lF18p8oUP3mJoUcE52Q5VBv +BxaoQacl17H2xchjyEeIA4n79gd6IDWm+rGPasMLtgUH6L8obnKFOLBXvuphOfgpXvc O5QQsdMYpe3CdSIx+Qpbi9Lo9Bp8vrThyKvnzpVEyQb71N9LQm6g4meAeQ6nRCM8kbi8 sz3Q== X-Gm-Message-State: ALQs6tBKXbyHOjOQNlBLd3bYhCCzx1ZlEbofblUfLMiGkJkLr1wARLn9 SuVYnK4Ld86cyiB9m1tunW3XxeHWH8c= X-Google-Smtp-Source: AB8JxZpNCC84m0zS+9mQF8yB0LONx0GgbeypkN01oQFaWMVt8v9vFOzR0XwdO1VSHek4wozClToa7g== X-Received: by 2002:a63:b908:: with SMTP id z8-v6mr33714683pge.436.1525810159785; Tue, 08 May 2018 13:09:19 -0700 (PDT) From: Michael Clark To: qemu-devel@nongnu.org Date: Wed, 9 May 2018 08:07:40 +1200 Message-Id: <1525810060-36690-4-git-send-email-mjc@sifive.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1525810060-36690-1-git-send-email-mjc@sifive.com> References: <1525810060-36690-1-git-send-email-mjc@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [PULL 3/3] riscv: requires libfdt X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@groups.riscv.org, KONRAD Frederic , Michael Clark Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: KONRAD Frederic When compiling on a machine without libfdt installed the configure script should try to get libfdt from the git or should die because otherwise CONFIG_LIBFDT is not set and the build process end in an error in the link phase.. eg: hw/riscv/virt.o: In function `riscv_virt_board_init': qemu/src/hw/riscv/virt.c:317: undefined reference to `qemu_fdt_setprop_cell' qemu/src/hw/riscv/virt.c:319: undefined reference to `qemu_fdt_setprop_cell' qemu/src/hw/riscv/virt.c:345: undefined reference to `qemu_fdt_dumpdtb' collect2: error: ld returned 1 exit status make[1]: *** [qemu-system-riscv64] Error 1 make: *** [subdir-riscv64-softmmu] Error 2 Reviewed-by: Bastian Koppelmann Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Michael Clark Signed-off-by: KONRAD Frederic Signed-off-by: Michael Clark Message-Id: <1525360636-18229-4-git-send-email-frederic.konrad@adacore.com> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1443422e83f1..479e9a787e6e 100755 --- a/configure +++ b/configure @@ -3761,7 +3761,7 @@ fi fdt_required=3Dno for target in $target_list; do case $target in - aarch64*-softmmu|arm*-softmmu|ppc*-softmmu|microblaze*-softmmu|mips64e= l-softmmu) + aarch64*-softmmu|arm*-softmmu|ppc*-softmmu|microblaze*-softmmu|mips64e= l-softmmu|riscv*-softmmu) fdt_required=3Dyes ;; esac --=20 2.7.0