[Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes

Michael Clark posted 3 patches 7 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1525734893-10299-1-git-send-email-mjc@sifive.com
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
configure             |  2 +-
hw/riscv/riscv_htif.c | 12 ++++++++----
2 files changed, 9 insertions(+), 5 deletions(-)
[Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes
Posted by Michael Clark 7 years, 5 months ago
The following changes since commit c8b7e627b4269a3bc3ae41d9f420547a47e6d9b9:

  Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-05-04' into staging (2018-05-04 14:42:46 +0100)

are available in the git repository at:

  https://github.com/riscv/riscv-qemu.git tags/riscv-qemu-2.13-minor-fixes-1

for you to fetch changes up to d4a63373c0e6349c6f36f56a6290ad639bfa20cb:

  riscv: requires libfdt (2018-05-08 10:57:21 +1200)

----------------------------------------------------------------
RISC-V: QEMU 2.13 Minor Fixes

* Require libfdt when configuring for 'riscv*-softmmu'
* Increase HTIF priority and allow zero address

----------------------------------------------------------------
KONRAD Frederic (3):
      riscv: spike: allow base == 0
      riscv: htif: increase the priority of the htif subregion
      riscv: requires libfdt

 configure             |  2 +-
 hw/riscv/riscv_htif.c | 12 ++++++++----
 2 files changed, 9 insertions(+), 5 deletions(-)

-- 
2.7.0


Re: [Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes
Posted by Peter Maydell 7 years, 5 months ago
On 8 May 2018 at 00:14, Michael Clark <mjc@sifive.com> wrote:
> The following changes since commit c8b7e627b4269a3bc3ae41d9f420547a47e6d9b9:
>
>   Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-05-04' into staging (2018-05-04 14:42:46 +0100)
>
> are available in the git repository at:
>
>   https://github.com/riscv/riscv-qemu.git tags/riscv-qemu-2.13-minor-fixes-1
>
> for you to fetch changes up to d4a63373c0e6349c6f36f56a6290ad639bfa20cb:
>
>   riscv: requires libfdt (2018-05-08 10:57:21 +1200)
>
> ----------------------------------------------------------------
> RISC-V: QEMU 2.13 Minor Fixes
>
> * Require libfdt when configuring for 'riscv*-softmmu'
> * Increase HTIF priority and allow zero address
>
> ----------------------------------------------------------------
> KONRAD Frederic (3):
>       riscv: spike: allow base == 0
>       riscv: htif: increase the priority of the htif subregion
>       riscv: requires libfdt

Hi Michael -- these patches from Fred need your Signed-off-by:
line in the commit messages as well as his. (This indicates that
they've passed through your hands to get to master; see item 3
in https://wiki.qemu.org/Contribute/SubmitAPullRequest )

I did a build test and they passed that fine, so if you can just
respin this pullreq with the signoff lines added to each commit
message I should be able to apply it.

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/3] RISC-V: QEMU 2.13 Minor Fixes
Posted by Michael Clark 7 years, 5 months ago
On Wed, May 9, 2018 at 4:05 AM, Peter Maydell <peter.maydell@linaro.org>
wrote:

> On 8 May 2018 at 00:14, Michael Clark <mjc@sifive.com> wrote:
> > The following changes since commit c8b7e627b4269a3bc3ae41d9f42054
> 7a47e6d9b9:
> >
> >   Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-05-04'
> into staging (2018-05-04 14:42:46 +0100)
> >
> > are available in the git repository at:
> >
> >   https://github.com/riscv/riscv-qemu.git tags/riscv-qemu-2.13-minor-
> fixes-1
> >
> > for you to fetch changes up to d4a63373c0e6349c6f36f56a6290ad639bfa20cb:
> >
> >   riscv: requires libfdt (2018-05-08 10:57:21 +1200)
> >
> > ----------------------------------------------------------------
> > RISC-V: QEMU 2.13 Minor Fixes
> >
> > * Require libfdt when configuring for 'riscv*-softmmu'
> > * Increase HTIF priority and allow zero address
> >
> > ----------------------------------------------------------------
> > KONRAD Frederic (3):
> >       riscv: spike: allow base == 0
> >       riscv: htif: increase the priority of the htif subregion
> >       riscv: requires libfdt
>
> Hi Michael -- these patches from Fred need your Signed-off-by:
> line in the commit messages as well as his. (This indicates that
> they've passed through your hands to get to master; see item 3
> in https://wiki.qemu.org/Contribute/SubmitAPullRequest )
>

I was thinking about that but was not sure. This is my first pull with
changes that originated outside the riscv tree.


> I did a build test and they passed that fine, so if you can just
> respin this pullreq with the signoff lines added to each commit
> message I should be able to apply it.
>

Okay, thanks. I've boot tested Linux kernel in the 'spike' machines. These
changes are very low risk. I'll respin with my "Signed-off-by" added.

The configure libfdt patch is the main one to cherry-pick for 2.12.1,
however, the other changes are innocuous enough if you want to merge the
whole PR to stable, as there are 3 commits. BTW I still need to test 'sifive_u'
in stable 2.12.0 to figure out the changes that need to be cherry-picked or
I can backport changes if necessary.