From nobody Wed Oct 29 20:29:40 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525735123375773.724865366515; Mon, 7 May 2018 16:18:43 -0700 (PDT) Received: from localhost ([::1]:48502 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFpOw-0000lV-Pm for importer@patchew.org; Mon, 07 May 2018 19:18:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFpMy-0008AR-I2 for qemu-devel@nongnu.org; Mon, 07 May 2018 19:16:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFpMw-0006mf-2F for qemu-devel@nongnu.org; Mon, 07 May 2018 19:16:36 -0400 Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]:35651) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fFpMv-0006m0-Ry for qemu-devel@nongnu.org; Mon, 07 May 2018 19:16:33 -0400 Received: by mail-pg0-x243.google.com with SMTP id j11-v6so20313821pgf.2 for ; Mon, 07 May 2018 16:16:33 -0700 (PDT) Received: from localhost.localdomain (122-58-167-38-fibre.bb.spark.co.nz. [122.58.167.38]) by smtp.gmail.com with ESMTPSA id q64sm42659569pfg.180.2018.05.07.16.16.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 07 May 2018 16:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=uAZp5rdj6Yi45P9mm0e2gcV0m+8SDt3+UxMHEzLv/ks=; b=ghUsPV7NAtwqjH1V7NhlJiJTsMleMXce97/+BXf14BHyFDgZh7v/uU8t0OvfDE7mzw xHqXGc8xyb7rfFK+T6/q5rekkIbc8IvT5XRO4WtO4V03UjlBE8rfxMqLyZwu6iW/DC/2 zPnPGnlUoWj7jcrqovgrX+d/cMG/1ZLuGshoCXU3lOm+tSfF/bq37EupSGehauU7N2We zXYUu0v/T1QZ1er4cjsHyyM0d1bkGOKsfoil/tVji6TCQ6aG4KzQ2D3fR0xWawUFQ2QD fzwR38k3PEYxnx/mBAxAh1h8xYGtEVWrbOYJiHvFw9iUQHSp4EvXMzUqOis8UMwqX3jI 6org== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uAZp5rdj6Yi45P9mm0e2gcV0m+8SDt3+UxMHEzLv/ks=; b=fbf+ldQDPC9ck5vWGGNaVNa4BxzOG+B/DnS6pGAbU/k9cPqI5MsnQGcw55Zwx2/6VS vwkpQIrUQ6LUkfsFiVj3UvrExH7Kr0iZQxBS+EKoBKeM0mKlumQp4AvntHp86GtrLCst cvjOzcs78qDziLeQNa/Hj2TiCmgaTMjw1N2JIE11GJkGXpq5Gyi4GLF1I7f3RU62rocq 3ZqSF58CPfQgUzK0DgqAsTQddBoWOSVoe47PhBHl428fBggh+5pAhdfZBkGKPHC70n/u 9CIML4ypVMk6Bu/SYyPkkElaXRxFzWLB8HZ9qyOw0Y4haDk5qcyWzBw0CrpqVy4rTg4A JrmQ== X-Gm-Message-State: ALQs6tDrRh249ZETCqAnaIhy1is+v9Xf33pKsa2y3+wGcHuJ9CyuACDS ZN/Eu7OIYisjX9Ke29xtHMwrJlN4qu8= X-Google-Smtp-Source: AB8JxZpMMaqIpXmWLyWddzLRuGUQr+zkueh4vKrWd7jzKb/mHQwSFHqoTEEOgkctSSXXcu6GKzmikw== X-Received: by 2002:a63:618b:: with SMTP id v133-v6mr30149616pgb.285.1525734992849; Mon, 07 May 2018 16:16:32 -0700 (PDT) From: Michael Clark To: qemu-devel@nongnu.org Date: Tue, 8 May 2018 11:14:51 +1200 Message-Id: <1525734893-10299-2-git-send-email-mjc@sifive.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1525734893-10299-1-git-send-email-mjc@sifive.com> References: <1525734893-10299-1-git-send-email-mjc@sifive.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::243 Subject: [Qemu-devel] [PULL 1/3] riscv: spike: allow base == 0 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@groups.riscv.org, KONRAD Frederic Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: KONRAD Frederic The sanity check on base doesn't allow htif to be mapped @0. Check if the symbol exists instead so we can map it where we want. Reviewed-by: Michael Clark Signed-off-by: KONRAD Frederic Message-Id: <1525360636-18229-2-git-send-email-frederic.konrad@adacore.com> --- hw/riscv/riscv_htif.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/riscv/riscv_htif.c b/hw/riscv/riscv_htif.c index 3e17f3025106..be252ec8cce9 100644 --- a/hw/riscv/riscv_htif.c +++ b/hw/riscv/riscv_htif.c @@ -41,17 +41,20 @@ } while (0) =20 static uint64_t fromhost_addr, tohost_addr; +static int address_symbol_set; =20 void htif_symbol_callback(const char *st_name, int st_info, uint64_t st_va= lue, - uint64_t st_size) + uint64_t st_size) { if (strcmp("fromhost", st_name) =3D=3D 0) { + address_symbol_set |=3D 1; fromhost_addr =3D st_value; if (st_size !=3D 8) { error_report("HTIF fromhost must be 8 bytes"); exit(1); } } else if (strcmp("tohost", st_name) =3D=3D 0) { + address_symbol_set |=3D 2; tohost_addr =3D st_value; if (st_size !=3D 8) { error_report("HTIF tohost must be 8 bytes"); @@ -248,7 +251,7 @@ HTIFState *htif_mm_init(MemoryRegion *address_space, Me= moryRegion *main_mem, qemu_chr_fe_init(&s->chr, chr, &error_abort); qemu_chr_fe_set_handlers(&s->chr, htif_can_recv, htif_recv, htif_event, htif_be_change, s, NULL, true); - if (base) { + if (address_symbol_set =3D=3D 3) { memory_region_init_io(&s->mmio, NULL, &htif_mm_ops, s, TYPE_HTIF_UART, size); memory_region_add_subregion(address_space, base, &s->mmio); --=20 2.7.0 From nobody Wed Oct 29 20:29:40 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525735125283170.8610091924985; Mon, 7 May 2018 16:18:45 -0700 (PDT) Received: from localhost ([::1]:48504 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFpOy-0000mt-97 for importer@patchew.org; Mon, 07 May 2018 19:18:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFpMz-0008Aa-8M for qemu-devel@nongnu.org; Mon, 07 May 2018 19:16:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFpMy-0006qv-Cs for qemu-devel@nongnu.org; Mon, 07 May 2018 19:16:37 -0400 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:37500) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fFpMy-0006pu-6s for qemu-devel@nongnu.org; Mon, 07 May 2018 19:16:36 -0400 Received: by mail-pg0-x244.google.com with SMTP id a13-v6so20315976pgu.4 for ; Mon, 07 May 2018 16:16:36 -0700 (PDT) Received: from localhost.localdomain (122-58-167-38-fibre.bb.spark.co.nz. [122.58.167.38]) by smtp.gmail.com with ESMTPSA id q64sm42659569pfg.180.2018.05.07.16.16.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 07 May 2018 16:16:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+K2jQ3Rp/bNYQPXaJWnWfc1pAr09kFhcGdRAX1d+hcw=; b=VaCE3p9QXHykk8BY6xAHQ5SxRvIaPBkzO9eSUrhyJ2mQXab9DCrGFMyLUBxurtODDz bIYe66PNuDVYGPAz6DfFAoAph/L3FT/TjjKfCuaj4M5tf4p8XWxGMC6E6g3t10/Hgrc3 FoFzGqJBv3orUSR6kEwtHFCWDBTT2ExUU80J4Q4XXC+TbmffNzfqEf/Ur1e+MTpZGK8U RhKGrGzyg2sGvYc6CPZSA8WK75rNKkEPNrY2iDelGNJNqCkIPLGKKvZ+ekWqBl33kqGJ OVvXkglIn+8TVhQa5/2qrvCw0/gCIlT/S/3xLYkDGvsQgisUw6MOVDiHvZlaxKi+0ZmY OJpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+K2jQ3Rp/bNYQPXaJWnWfc1pAr09kFhcGdRAX1d+hcw=; b=jB5cn90bmUY7/bM66VzkuEbi17Rfahvsj2+9Xv263mByJ3etPrMROJzSzAxI7+0JTm NawntFq55Wdi9paHHaFzGYAfX//J4z7mKCUdxcATBKSYzUYxWLLhBfchAABgt+iNuGF+ CRN11sXwLTRq39LwP/01Js5KcMqA4exxGcB2OVMSVrycMx9L9nao7iUbjb6cmg9Km2Lj oBB1PWPcLjxCJmrNbAkVmS5U8vS3JbDH984DOlF5UTPTVECJF47hRFBCRqqAizeAvshh AXsHIovunChitICkKFhXDy71u5G9PEStDFUEPm3hcgORyH2/ZYhndqox4/SUX0FCcrqx yJQQ== X-Gm-Message-State: ALQs6tBl2rnS3b2ZkHrx3Y2taMae/+/OlsYy/NGmXoyiM1/kc/zFXkBo 7y7P+upJ3HG4cz3CFpQ7upGXE4oUGdM= X-Google-Smtp-Source: AB8JxZozzPm0ZUgP5F0NB90WNatu37sb1STRXUyaIjkxK0kIBhGNKLauT8dJeVpI5Kfh329OkHTTwQ== X-Received: by 10.167.134.20 with SMTP id p20mr37810406pfn.159.1525734995267; Mon, 07 May 2018 16:16:35 -0700 (PDT) From: Michael Clark To: qemu-devel@nongnu.org Date: Tue, 8 May 2018 11:14:52 +1200 Message-Id: <1525734893-10299-3-git-send-email-mjc@sifive.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1525734893-10299-1-git-send-email-mjc@sifive.com> References: <1525734893-10299-1-git-send-email-mjc@sifive.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 Subject: [Qemu-devel] [PULL 2/3] riscv: htif: increase the priority of the htif subregion X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@groups.riscv.org, KONRAD Frederic Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: KONRAD Frederic The htif device is supposed to be mapped over an other subregion. So increa= se its priority to one to avoid any conflict. Here is the output of info mtree: Before: (qemu) info mtree address-space: memory 0000000000000000-ffffffffffffffff (prio 0, i/o): system 0000000000000000-000000000000000f (prio 0, i/o): riscv.htif.uart 0000000000000000-0000000000011fff (prio 0, ram): riscv.spike.bootrom 0000000002000000-000000000200ffff (prio 0, i/o): riscv.sifive.clint 0000000080000000-0000000087ffffff (prio 0, ram): riscv.spike.ram address-space: I/O 0000000000000000-000000000000ffff (prio 0, i/o): io address-space: cpu-memory-0 0000000000000000-ffffffffffffffff (prio 0, i/o): system 0000000000000000-000000000000000f (prio 0, i/o): riscv.htif.uart 0000000000000000-0000000000011fff (prio 0, ram): riscv.spike.bootrom 0000000002000000-000000000200ffff (prio 0, i/o): riscv.sifive.clint 0000000080000000-0000000087ffffff (prio 0, ram): riscv.spike.ram After: (qemu) info mtree address-space: memory 0000000000000000-ffffffffffffffff (prio 0, i/o): system 0000000000000000-000000000000000f (prio 1, i/o): riscv.htif.uart 0000000000000000-0000000000011fff (prio 0, ram): riscv.spike.bootrom 0000000002000000-000000000200ffff (prio 0, i/o): riscv.sifive.clint 0000000080000000-0000000087ffffff (prio 0, ram): riscv.spike.ram address-space: I/O 0000000000000000-000000000000ffff (prio 0, i/o): io address-space: cpu-memory-0 0000000000000000-ffffffffffffffff (prio 0, i/o): system 0000000000000000-000000000000000f (prio 1, i/o): riscv.htif.uart 0000000000000000-0000000000011fff (prio 0, ram): riscv.spike.bootrom 0000000002000000-000000000200ffff (prio 0, i/o): riscv.sifive.clint 0000000080000000-0000000087ffffff (prio 0, ram): riscv.spike.ram Reviewed-by: Michael Clark Signed-off-by: KONRAD Frederic Message-Id: <1525360636-18229-3-git-send-email-frederic.konrad@adacore.com> --- hw/riscv/riscv_htif.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/riscv/riscv_htif.c b/hw/riscv/riscv_htif.c index be252ec8cce9..f73512941fb6 100644 --- a/hw/riscv/riscv_htif.c +++ b/hw/riscv/riscv_htif.c @@ -253,8 +253,9 @@ HTIFState *htif_mm_init(MemoryRegion *address_space, Me= moryRegion *main_mem, htif_be_change, s, NULL, true); if (address_symbol_set =3D=3D 3) { memory_region_init_io(&s->mmio, NULL, &htif_mm_ops, s, - TYPE_HTIF_UART, size); - memory_region_add_subregion(address_space, base, &s->mmio); + TYPE_HTIF_UART, size); + memory_region_add_subregion_overlap(address_space, base, + &s->mmio, 1); } =20 return s; --=20 2.7.0 From nobody Wed Oct 29 20:29:40 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 152573522625568.32387788743449; Mon, 7 May 2018 16:20:26 -0700 (PDT) Received: from localhost ([::1]:48514 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFpQf-0002CG-HP for importer@patchew.org; Mon, 07 May 2018 19:20:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFpN1-0008Br-Om for qemu-devel@nongnu.org; Mon, 07 May 2018 19:16:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFpN0-0006vs-Pb for qemu-devel@nongnu.org; Mon, 07 May 2018 19:16:39 -0400 Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:44366) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fFpN0-0006uP-K4 for qemu-devel@nongnu.org; Mon, 07 May 2018 19:16:38 -0400 Received: by mail-pg0-x241.google.com with SMTP id x145-v6so46513pgx.11 for ; Mon, 07 May 2018 16:16:38 -0700 (PDT) Received: from localhost.localdomain (122-58-167-38-fibre.bb.spark.co.nz. [122.58.167.38]) by smtp.gmail.com with ESMTPSA id q64sm42659569pfg.180.2018.05.07.16.16.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 07 May 2018 16:16:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H6YcbqGyXzr0ieHFG/ERs4rOKLJiTZSQx4o9D4Gq7+s=; b=VgtVeQLEpYkSZC5MWvuYpIcJ1p3e6DvAQUZJ2Pgo5glsmhRPG74FLZ1w48hab1ZPra D/+f9jlOE+2T6Jr5xxOTuYnPW7DfxSJJG1VQA19NNmw/HGVwyBwur6Q5P6qiHmQJU0Jn 0LQqOsiKKNIGZPQc6po3jcd0Lj6qvsz1NqBELpx84hEkTt92YlDgQc5N9tcWG5iSBkAZ MGwVllgz4+zQCjZ9Wlmo4R4Cbgh4lGZHYu7n/+BoOkryiZ1BU2P0cWdUYi9/XkPPkbtc vp2u7pzsQQWaITT3rytYtw03HdyxBEnI1PIY+LMUTVvalC8V1t/F2jUhuiuLvsvgd8a+ 3svw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H6YcbqGyXzr0ieHFG/ERs4rOKLJiTZSQx4o9D4Gq7+s=; b=eOeKfRQfaiZ9s1FdOp6KQhuoaz19DBwSlKrubgobkrcqRSRFKTCZP0YbvkbFHz9sPh OmdkZn80mnv8//MNJ71DMB010lyLsSdlx2KSLdZPo4kg9GzdpztlVuOpsd3rbPqLAyXB whzp+S2ZjO9MGFgQPTZHAWtqqDle5VqI6VaPuaYaiqdDeavr1E5TdkgttRWyVyn0qWQl efHo3Jwse9PUCy7MTDrjY8EWErvGvJ/r13Yoj48mkW0nIPH/oF/GboqOia0gVPojsTHU 8aS1CKppPLF9SM4Mnj57fklO1MWARrq6ONRrAnLDAMKrx/nR4OeAXYqx6+KxNXm8YwSu usNA== X-Gm-Message-State: ALQs6tCl5efUnGjQY24DUbv9tLiKIQ2QGh8UF3ZKirO+G84A6BuL1061 DEv6Ovyj440Q7aRPc98747qOhnQr2ys= X-Google-Smtp-Source: AB8JxZqDRQYVk9Pg+flGdA8FzhnDDN5D+ADstWuuxgyvpmPwmLzB8ti1hx9jJe4wDJwdeTR62eNnew== X-Received: by 10.98.160.68 with SMTP id r65mr36880900pfe.235.1525734997675; Mon, 07 May 2018 16:16:37 -0700 (PDT) From: Michael Clark To: qemu-devel@nongnu.org Date: Tue, 8 May 2018 11:14:53 +1200 Message-Id: <1525734893-10299-4-git-send-email-mjc@sifive.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1525734893-10299-1-git-send-email-mjc@sifive.com> References: <1525734893-10299-1-git-send-email-mjc@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::241 Subject: [Qemu-devel] [PULL 3/3] riscv: requires libfdt X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@groups.riscv.org, KONRAD Frederic Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: KONRAD Frederic When compiling on a machine without libfdt installed the configure script should try to get libfdt from the git or should die because otherwise CONFIG_LIBFDT is not set and the build process end in an error in the link phase.. eg: hw/riscv/virt.o: In function `riscv_virt_board_init': qemu/src/hw/riscv/virt.c:317: undefined reference to `qemu_fdt_setprop_cell' qemu/src/hw/riscv/virt.c:319: undefined reference to `qemu_fdt_setprop_cell' qemu/src/hw/riscv/virt.c:345: undefined reference to `qemu_fdt_dumpdtb' collect2: error: ld returned 1 exit status make[1]: *** [qemu-system-riscv64] Error 1 make: *** [subdir-riscv64-softmmu] Error 2 Reviewed-by: Bastian Koppelmann Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Michael Clark Signed-off-by: KONRAD Frederic Message-Id: <1525360636-18229-4-git-send-email-frederic.konrad@adacore.com> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1443422e83f1..479e9a787e6e 100755 --- a/configure +++ b/configure @@ -3761,7 +3761,7 @@ fi fdt_required=3Dno for target in $target_list; do case $target in - aarch64*-softmmu|arm*-softmmu|ppc*-softmmu|microblaze*-softmmu|mips64e= l-softmmu) + aarch64*-softmmu|arm*-softmmu|ppc*-softmmu|microblaze*-softmmu|mips64e= l-softmmu|riscv*-softmmu) fdt_required=3Dyes ;; esac --=20 2.7.0