[Qemu-devel] [PATCH v2] Issue a deprecation warning if the user specifies the "-hdachs" option.

Thomas Huth posted 1 patch 6 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1493191019-32442-1-git-send-email-thuth@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
There is a newer version of this series
vl.c | 2 ++
1 file changed, 2 insertions(+)
[Qemu-devel] [PATCH v2] Issue a deprecation warning if the user specifies the "-hdachs" option.
Posted by Thomas Huth 6 years, 11 months ago
If the user needs to specify the disk geometry, the corresponding
parameters of the "-drive" option should be used instead. "-hdachs"
is considered as deprecated and might be removed soon.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 v2: Removed the trailing dot from the string as suggested by Eric

 vl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/vl.c b/vl.c
index 0b4ed52..478cfdd 100644
--- a/vl.c
+++ b/vl.c
@@ -3230,6 +3230,8 @@ int main(int argc, char **argv, char **envp)
                         }
                     }
                 }
+                error_report("'-hdachs' is deprecated, please use '-drive"
+                             " ...,cyls=c,heads=h,secs=s,trans=t' instead");
                 break;
             case QEMU_OPTION_numa:
                 opts = qemu_opts_parse_noisily(qemu_find_opts("numa"),
-- 
1.8.3.1