[Qemu-devel] [PATCH v3] Issue a deprecation warning if the user specifies the "-hdachs" option.

Thomas Huth posted 1 patch 147 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1493270454-1448-1-git-send-email-thuth@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
qemu-options.hx | 4 ++--
vl.c            | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v3] Issue a deprecation warning if the user specifies the "-hdachs" option.

Posted by Thomas Huth 147 weeks ago
If the user needs to specify the disk geometry, the corresponding
parameters of the "-device ide-hd" option should be used instead.
"-hdachs" is considered as deprecated and might be removed soon.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 v3:
 - Recommend to use the parameters of -device ide-hd instead
 - Also add the deprecation warning to the documentation

 qemu-options.hx | 4 ++--
 vl.c            | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 787b9c3..f68829f 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -803,8 +803,8 @@ STEXI
 Force hard disk 0 physical geometry (1 <= @var{c} <= 16383, 1 <=
 @var{h} <= 16, 1 <= @var{s} <= 63) and optionally force the BIOS
 translation mode (@var{t}=none, lba or auto). Usually QEMU can guess
-all those parameters. This option is useful for old MS-DOS disk
-images.
+all those parameters. This option is deprecated, please use
+@code{-device ide-hd,cyls=c,heads=h,secs=s,...} instead.
 ETEXI
 
 DEF("fsdev", HAS_ARG, QEMU_OPTION_fsdev,
diff --git a/vl.c b/vl.c
index f46e070..42d4bce 100644
--- a/vl.c
+++ b/vl.c
@@ -3231,6 +3231,8 @@ int main(int argc, char **argv, char **envp)
                         }
                     }
                 }
+                error_report("'-hdachs' is deprecated, please use '-device"
+                             " ide-hd,cyls=c,heads=h,secs=s,...' instead");
                 break;
             case QEMU_OPTION_numa:
                 opts = qemu_opts_parse_noisily(qemu_find_opts("numa"),
-- 
1.8.3.1


Re: [Qemu-devel] [PATCH v3] Issue a deprecation warning if the user specifies the "-hdachs" option.

Posted by Eric Blake 147 weeks ago
On 04/27/2017 12:20 AM, Thomas Huth wrote:
> If the user needs to specify the disk geometry, the corresponding
> parameters of the "-device ide-hd" option should be used instead.
> "-hdachs" is considered as deprecated and might be removed soon.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  v3:
>  - Recommend to use the parameters of -device ide-hd instead
>  - Also add the deprecation warning to the documentation
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH v3] Issue a deprecation warning if the user specifies the "-hdachs" option.

Posted by Kevin Wolf 147 weeks ago
Am 27.04.2017 um 07:20 hat Thomas Huth geschrieben:
> If the user needs to specify the disk geometry, the corresponding
> parameters of the "-device ide-hd" option should be used instead.
> "-hdachs" is considered as deprecated and might be removed soon.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Thanks, applied to block-next.

Kevin