vl.c | 2 ++ 1 file changed, 2 insertions(+)
If the user needs to specify the disk geometry, the corresponding
parameters of the "-drive" option should be used instead. "-hdachs"
is considered as deprecated and might be removed soon.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
vl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/vl.c b/vl.c
index 0b4ed52..0980213 100644
--- a/vl.c
+++ b/vl.c
@@ -3230,6 +3230,8 @@ int main(int argc, char **argv, char **envp)
}
}
}
+ error_report("'-hdachs' is deprecated. Please use '-drive"
+ " ...,cyls=c,heads=h,secs=s,trans=t' instead.");
break;
case QEMU_OPTION_numa:
opts = qemu_opts_parse_noisily(qemu_find_opts("numa"),
--
1.8.3.1
On 04/25/2017 03:08 AM, Thomas Huth wrote: > If the user needs to specify the disk geometry, the corresponding > parameters of the "-drive" option should be used instead. "-hdachs" > is considered as deprecated and might be removed soon. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > vl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/vl.c b/vl.c > index 0b4ed52..0980213 100644 > --- a/vl.c > +++ b/vl.c > @@ -3230,6 +3230,8 @@ int main(int argc, char **argv, char **envp) > } > } > } > + error_report("'-hdachs' is deprecated. Please use '-drive" > + " ...,cyls=c,heads=h,secs=s,trans=t' instead."); No trailing dot. With that fixed, Reviewed-by: Eric Blake <eblake@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
On 25/04/2017 10:08, Thomas Huth wrote: > If the user needs to specify the disk geometry, the corresponding > parameters of the "-drive" option should be used instead. "-hdachs" > is considered as deprecated and might be removed soon. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > vl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/vl.c b/vl.c > index 0b4ed52..0980213 100644 > --- a/vl.c > +++ b/vl.c > @@ -3230,6 +3230,8 @@ int main(int argc, char **argv, char **envp) > } > } > } > + error_report("'-hdachs' is deprecated. Please use '-drive" > + " ...,cyls=c,heads=h,secs=s,trans=t' instead."); > break; > case QEMU_OPTION_numa: > opts = qemu_opts_parse_noisily(qemu_find_opts("numa"), > Not even this, which should also be deprecated; please suggest using "-device ide-hd" instead. Paolo
On 26.04.2017 15:44, Paolo Bonzini wrote: > > > On 25/04/2017 10:08, Thomas Huth wrote: >> If the user needs to specify the disk geometry, the corresponding >> parameters of the "-drive" option should be used instead. "-hdachs" >> is considered as deprecated and might be removed soon. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> >> --- >> vl.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/vl.c b/vl.c >> index 0b4ed52..0980213 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -3230,6 +3230,8 @@ int main(int argc, char **argv, char **envp) >> } >> } >> } >> + error_report("'-hdachs' is deprecated. Please use '-drive" >> + " ...,cyls=c,heads=h,secs=s,trans=t' instead."); >> break; >> case QEMU_OPTION_numa: >> opts = qemu_opts_parse_noisily(qemu_find_opts("numa"), >> > > Not even this, which should also be deprecated; please suggest using > "-device ide-hd" instead. D'oh, you're right, of course ... I'll send a v3 ... Thomas
© 2016 - 2024 Red Hat, Inc.