[Qemu-devel] [PATCH for-2.9 2/6] qapi2texi: Fix to actually fail when 'doc-required' is false

Markus Armbruster posted 6 patches 8 years, 10 months ago
[Qemu-devel] [PATCH for-2.9 2/6] qapi2texi: Fix to actually fail when 'doc-required' is false
Posted by Markus Armbruster 8 years, 10 months ago
Messed up in commit bc52d03.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 scripts/qapi2texi.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/qapi2texi.py b/scripts/qapi2texi.py
index 8eed11a..5c4db78 100755
--- a/scripts/qapi2texi.py
+++ b/scripts/qapi2texi.py
@@ -292,6 +292,7 @@ def main(argv):
     if not qapi.doc_required:
         print >>sys.stderr, ("%s: need pragma 'doc-required' "
                              "to generate documentation" % argv[0])
+        sys.exit(1)
     print texi_schema(schema)
 
 
-- 
2.7.4


Re: [Qemu-devel] [PATCH for-2.9 2/6] qapi2texi: Fix to actually fail when 'doc-required' is false
Posted by Marc-André Lureau 8 years, 10 months ago

----- Original Message -----
> Messed up in commit bc52d03.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  scripts/qapi2texi.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/qapi2texi.py b/scripts/qapi2texi.py
> index 8eed11a..5c4db78 100755
> --- a/scripts/qapi2texi.py
> +++ b/scripts/qapi2texi.py
> @@ -292,6 +292,7 @@ def main(argv):
>      if not qapi.doc_required:
>          print >>sys.stderr, ("%s: need pragma 'doc-required' "
>                               "to generate documentation" % argv[0])
> +        sys.exit(1)
>      print texi_schema(schema)
>  
>  
> --
> 2.7.4
> 
>