[Qemu-devel] [PATCH for-2.9 0/6] qapi: Small qapi2texi fixes and addition tests

Markus Armbruster posted 6 patches 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1490015515-25851-1-git-send-email-armbru@redhat.com
Test checkpatch failed
Test docker passed
Test s390x passed
Makefile                        |   7 +-
scripts/qapi.py                 |   1 -
scripts/qapi2texi.py            |   5 +-
tests/Makefile.include          |  13 ++-
tests/qapi-schema/doc-good.err  |   0
tests/qapi-schema/doc-good.exit |   1 +
tests/qapi-schema/doc-good.json | 136 ++++++++++++++++++++++
tests/qapi-schema/doc-good.out  | 148 ++++++++++++++++++++++++
tests/qapi-schema/doc-good.texi | 243 ++++++++++++++++++++++++++++++++++++++++
tests/qapi-schema/test-qapi.py  |  11 ++
10 files changed, 555 insertions(+), 10 deletions(-)
create mode 100644 tests/qapi-schema/doc-good.err
create mode 100644 tests/qapi-schema/doc-good.exit
create mode 100644 tests/qapi-schema/doc-good.json
create mode 100644 tests/qapi-schema/doc-good.out
create mode 100644 tests/qapi-schema/doc-good.texi
[Qemu-devel] [PATCH for-2.9 0/6] qapi: Small qapi2texi fixes and addition tests
Posted by Markus Armbruster 7 years ago
Code changes only in QAPI generator scripts and tests.  Generated code
is identical.  Generated documentation is improved slightly.

Markus Armbruster (6):
  qapi: Drop excessive Make dependencies on qapi2texi.py
  qapi2texi: Fix to actually fail when 'doc-required' is false
  qapi: Drop unused QAPIDoc member optional
  tests/qapi-schema: Make test-qapi.py print docs again
  tests/qapi-schema: Systematic positive doc comment tests
  qapi2texi: Fix translation of *strong* and _emphasized_

 Makefile                        |   7 +-
 scripts/qapi.py                 |   1 -
 scripts/qapi2texi.py            |   5 +-
 tests/Makefile.include          |  13 ++-
 tests/qapi-schema/doc-good.err  |   0
 tests/qapi-schema/doc-good.exit |   1 +
 tests/qapi-schema/doc-good.json | 136 ++++++++++++++++++++++
 tests/qapi-schema/doc-good.out  | 148 ++++++++++++++++++++++++
 tests/qapi-schema/doc-good.texi | 243 ++++++++++++++++++++++++++++++++++++++++
 tests/qapi-schema/test-qapi.py  |  11 ++
 10 files changed, 555 insertions(+), 10 deletions(-)
 create mode 100644 tests/qapi-schema/doc-good.err
 create mode 100644 tests/qapi-schema/doc-good.exit
 create mode 100644 tests/qapi-schema/doc-good.json
 create mode 100644 tests/qapi-schema/doc-good.out
 create mode 100644 tests/qapi-schema/doc-good.texi

-- 
2.7.4


Re: [Qemu-devel] [PATCH for-2.9 0/6] qapi: Small qapi2texi fixes and addition tests
Posted by no-reply@patchew.org 7 years ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH for-2.9 0/6] qapi: Small qapi2texi fixes and addition tests
Message-id: 1490015515-25851-1-git-send-email-armbru@redhat.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
4fea5b2 qapi2texi: Fix translation of *strong* and _emphasized_
824c22b tests/qapi-schema: Systematic positive doc comment tests
369016b tests/qapi-schema: Make test-qapi.py print docs again
8040557 qapi: Drop unused QAPIDoc member optional
78edd92 qapi2texi: Fix to actually fail when 'doc-required' is false
f64e5ff qapi: Drop excessive Make dependencies on qapi2texi.py

=== OUTPUT BEGIN ===
Checking PATCH 1/6: qapi: Drop excessive Make dependencies on qapi2texi.py...
Checking PATCH 2/6: qapi2texi: Fix to actually fail when 'doc-required' is false...
Checking PATCH 3/6: qapi: Drop unused QAPIDoc member optional...
Checking PATCH 4/6: tests/qapi-schema: Make test-qapi.py print docs again...
Checking PATCH 5/6: tests/qapi-schema: Systematic positive doc comment tests...
ERROR: trailing whitespace
#380: FILE: tests/qapi-schema/doc-good.texi:5:
+@emph{strong}  @emph{with emphasis} $

total: 1 errors, 0 warnings, 568 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/6: qapi2texi: Fix translation of *strong* and _emphasized_...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org