From: Geliang Tang <tanggeliang@kylinos.cn>
If "setup_ns ns" is used in diag.sh, it fails with errors:
./mptcp_lib.sh: line 289: local: ns: readonly variable
13 ....chk 2 cestab [ OK ]
14 ....chk 2->0 msk in use after flush [ OK ]
That is because "ns" is also a local variable in mptcp_lib_get_counter.
To solve this, this patch renames it as "_ns".
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
---
tools/testing/selftests/net/mptcp/mptcp_lib.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_lib.sh b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
index ad2ebda5cb64..16aa080c8229 100644
--- a/tools/testing/selftests/net/mptcp/mptcp_lib.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
@@ -286,11 +286,11 @@ mptcp_lib_is_v6() {
# $1: ns, $2: MIB counter
mptcp_lib_get_counter() {
- local ns="${1}"
+ local _ns="${1}"
local counter="${2}"
local count
- count=$(ip netns exec "${ns}" nstat -asz "${counter}" |
+ count=$(ip netns exec "${_ns}" nstat -asz "${counter}" |
awk 'NR==1 {next} {print $2}')
if [ -z "${count}" ]; then
mptcp_lib_fail_if_expected_feature "${counter} counter"
--
2.43.0