On Mon, 2024-05-27 at 12:58 +0200, Matthieu Baerts (NGI0) wrote:
> (This is a new version for the series created by Geliang. @Geliang: I
> hope that's OK for you like that, it was easier to describing the
> modifications by email. I validated my changes by running MPTCP
> selftests only)
>
> This set uses the public helpers defined in net selftests to replace
> helpers in mptcp_lib.sh.
>
> v6:
> - Replace "rename ns in setup_ns" by "remove 'ns' var in setup_ns":
> we
> don't need it, avoid extra conflicts.
>
> v5: (Matt)
> - New patches: 1-6: some unrelated fixes, some modifications to
> avoid
> adding workaround on our side (changing variable names, trap,
> etc.)
> - "rename ns in setup_ns": drop the modifications in cleanup_ns,
> exit
> in case of error, and updated commit message.
> - Drop patches 2, 4, 5/6 from v4.
>
> v4:
> - two more fixes added
> - exit when setup_ns fails in mptcp_lib_ns_init
>
> v3:
> - address Matt's comments in v2 (thanks, it's very useful.)
> - don't rename ns in diag.sh, but in lib.sh
> - ns in get_counter needs to be renamed too
> - add a ns_name valid check in setup_ns
> - drop $NS_LIST in mptcp_lib_ns_init
> - don't drop mptcp_lib_ns_init, use cleanup_ns in it
> - don't use cleanup_all_ns, still use mptcp_lib_ns_init
>
> v2:
> - only patch 3 updated, mptcp_join.sh, move cleanup_all_ns from
> cleanup_partial to cleanup, setup_ns will delete existing
> namespaces automatically.
> - update commit logs.
>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Thanks Matt, please add my tag:
Reviewed-by: Geliang Tang <geliang@kernel.org>
> ---
> Changes in v6:
> - Link to v5:
> https://lore.kernel.org/r/20240524-selftests-net-lib-fixes-v5-0-b9e0968571a3@kernel.org
>
> ---
> Geliang Tang (3):
> selftests: net: lib: remove 'ns' var in setup_ns
> selftests: mptcp: lib: use setup/cleanup_ns helpers
> selftests: mptcp: lib: use wait_local_port_listen helper
>
> Matthieu Baerts (NGI0) (6):
> selftests: net: lib: set 'i' as local
> selftests: net: lib: support errexit with busywait
> selftests: net: lib: avoid error removing empty netns name
> selftests: net: lib: ignore possible error
> selftests: net: lib: remove ns from list after clean-up
> selftests: net: lib: do not set ns var as readonly
>
> tools/testing/selftests/net/lib.sh | 71 +++++++++++++++-
> ----------
> tools/testing/selftests/net/mptcp/mptcp_lib.sh | 33 ++++--------
> 2 files changed, 50 insertions(+), 54 deletions(-)
> ---
> base-commit: 55aceb609c1baec3e762e938e2028df7ecd545e1
> change-id: 20240524-selftests-net-lib-fixes-5a70b8d3b828
>
> Best regards,