From: Geliang Tang <tanggeliang@kylinos.cn>

v3:
 - use check_output in pm_nl_check_endpoint.
 - split #2 and #7 patches in v2.
 - put "selftests: mptcp: join: fix dev in check_endpoint" into this
   series too.

v2:
 - address every Matt's commends in v1.
 - depends on "selftests: mptcp: join: fix dev in check_endpoint"

This is the last part for "add helpers and vars in mptcp_lib.sh" series,
add endpoint operation helpers into mptcp_lib.sh.

Geliang Tang (12):
  selftests: mptcp: join: fix dev in check_endpoint
  selftests: mptcp: export ip_mptcp to mptcp_lib
  selftests: mptcp: format limits outputs
  selftests: mptcp: add get_limits helper
  selftests: mptcp: export set_limits helper
  selftests: mptcp: format endpoints outputs
  selftests: mptcp: add get_endpoint helper
  selftests: mptcp: add change_address helper
  selftests: mptcp: join: update endpoint ops
  selftests: mptcp: export more endpoint ops
  selftests: mptcp: ip_mptcp option for more scripts
  selftests: mptcp: netlink: drop disable=SC2086

 .../testing/selftests/net/mptcp/mptcp_join.sh | 149 ++---------
 .../testing/selftests/net/mptcp/mptcp_lib.sh  | 163 ++++++++++++
 .../selftests/net/mptcp/mptcp_sockopt.sh      |  34 ++-
 .../testing/selftests/net/mptcp/pm_netlink.sh | 240 ++++++++++--------
 .../selftests/net/mptcp/simult_flows.sh       |  14 +-
 5 files changed, 349 insertions(+), 251 deletions(-)

-- 
2.40.1

Hi Geliang,

On 17/03/2024 01:57, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v3:
>  - use check_output in pm_nl_check_endpoint.
>  - split #2 and #7 patches in v2.
>  - put "selftests: mptcp: join: fix dev in check_endpoint" into this
>    series too.
> 
> v2:
>  - address every Matt's commends in v1.
>  - depends on "selftests: mptcp: join: fix dev in check_endpoint"

Thank you for the new version!

I already applied patch 1/12.

I have some suggestions, please see my other replies.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Unstable: 1 failed test(s): packetdrill_mp_join 🔴
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/8311895129

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/e8e27b9f1f07
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=835874


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)