From: Geliang Tang <tanggeliang@kylinos.cn>

v4:
 - address every Matt's commends in v3.

v3:
 - use check_output in pm_nl_check_endpoint.
 - split #2 and #7 patches in v2.
 - put "selftests: mptcp: join: fix dev in check_endpoint" into this
   series too.

v2:
 - address every Matt's commends in v1.
 - depends on "selftests: mptcp: join: fix dev in check_endpoint"

This is the last part for "add helpers and vars in mptcp_lib.sh" series,
add endpoint operation helpers into mptcp_lib.sh.

Geliang Tang (9):
  selftests: mptcp: export ip_mptcp to mptcp_lib
  selftests: mptcp: add get_limits helper
  selftests: mptcp: add get_endpoint helper
  selftests: mptcp: add change_address helper
  selftests: mptcp: join: update endpoint ops
  selftests: mptcp: export pm_nl endpoint ops
  selftests: mptcp: use pm_nl endpoint ops
  selftests: mptcp: ip_mptcp option for more scripts
  selftests: mptcp: netlink: drop disable=SC2086

 .../testing/selftests/net/mptcp/mptcp_join.sh | 147 ++-------
 .../testing/selftests/net/mptcp/mptcp_lib.sh  | 128 ++++++++
 .../selftests/net/mptcp/mptcp_sockopt.sh      |  34 +-
 .../testing/selftests/net/mptcp/pm_netlink.sh | 294 +++++++++++-------
 .../selftests/net/mptcp/simult_flows.sh       |  14 +-
 5 files changed, 366 insertions(+), 251 deletions(-)

-- 
2.40.1

Hi Geliang,

On 19/03/2024 08:16, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v4:
>  - address every Matt's commends in v3.

Thank you for the new version. It looks good to me, just some details,
mostly inconsistencies in the commit messages, I can fix that when
applying the patches.

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Hi Geliang,

On 19/03/2024 17:58, Matthieu Baerts wrote:
> Hi Geliang,
> 
> On 19/03/2024 08:16, Geliang Tang wrote:
>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>
>> v4:
>>  - address every Matt's commends in v3.
> 
> Thank you for the new version. It looks good to me, just some details,
> mostly inconsistencies in the commit messages, I can fix that when
> applying the patches.
> 
> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

Now in our tree (feat. for net-next):

New patches for t/upstream:
- 75006cfc55e1: selftests: mptcp: export ip_mptcp to mptcp_lib
- 47256e561ff7: selftests: mptcp: netlink: add 'limits' helpers
- 7b7877974627: selftests: mptcp: add {get,format}_endpoint(s) helpers
- d4812471cbd3: selftests: mptcp: netlink: add change_address helper
- a0e3a3cbcc44: selftests: mptcp: join: update endpoint ops
- 9affad23c8fb: selftests: mptcp: export pm_nl endpoint ops
- 6686695dd7c4: selftests: mptcp: use pm_nl endpoint ops
- 39b7f217cd25: selftests: mptcp: ip_mptcp option for more scripts
- 68e20b601685: selftests: mptcp: netlink: drop disable=SC2086
- Results: 2066a03d696e..eeea8900a12e (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/2a74a8d35e784648fb7c4851019456f4d6c432b1/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/8339177200

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/3de9bfb424e6
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=836322


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)