[v4] run sched tests in a dedicated ns

[PATCH mptcp-next v4 0/6] run sched tests in a dedicated ns

Geliang Tang posted 6 patches 11 months, 1 week ago

Diff against v1 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1684362296.git.geliang.tang@suse.com

Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, Mat Martineau <martineau@kernel.org>, Andrii Nakryiko <andrii@kernel.org>, Mykola Lysenko <mykolal@fb.com>, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Martin KaFai Lau <martin.lau@linux.dev>, Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>, John Fastabend <john.fastabend@gmail.com>, KP Singh <kpsingh@kernel.org>, Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>, Hangbin Liu <liuhangbin@gmail.com>

.../testing/selftests/bpf/prog_tests/mptcp.c  | 109 +++++++++++-------
1 file changed, 68 insertions(+), 41 deletions(-)

Expand all Fold all

[PATCH mptcp-next v4 0/6] run sched tests in a dedicated ns

Posted by Geliang Tang 11 months, 1 week ago

v4:
 - patch #1 could be merged before "mptcp: refactor push_pending logic"
   as a single fix.
 - patch #2 should be merged between "selftests/bpf: Add mptcp sched
   structs" and "selftests/bpf: Add bpf_first scheduler".

v3:
 - add two helpers.
 - drop sched_cleanup().

Geliang Tang (6):
  selftests/bpf: use random netns name for mptcp
  selftests/bpf: add two mptcp netns helpers
  Squash to "selftests/bpf: Add bpf_first test"
  Squash to "selftests/bpf: Add bpf_bkup test"
  Squash to "selftests/bpf: Add bpf_rr test"
  Squash to "selftests/bpf: Add bpf_red test"

 .../testing/selftests/bpf/prog_tests/mptcp.c  | 109 +++++++++++-------
 1 file changed, 68 insertions(+), 41 deletions(-)

-- 
2.35.3

Re: [PATCH mptcp-next v4 0/6] run sched tests in a dedicated ns

Posted by Matthieu Baerts 11 months, 1 week ago

Hi Geliang,

On 18/05/2023 00:29, Geliang Tang wrote:
> v4:
>  - patch #1 could be merged before "mptcp: refactor push_pending logic"
>    as a single fix.
>  - patch #2 should be merged between "selftests/bpf: Add mptcp sched
>    structs" and "selftests/bpf: Add bpf_first scheduler".

Thank you for the new version and for the explanations!

I suggest to apply the first patch also between "selftests/bpf: Add
mptcp sched structs" and "selftests/bpf: Add bpf_first scheduler" as it
seems not needed before (see my comment on this patch).

Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

Re: [PATCH mptcp-next v4 0/6] run sched tests in a dedicated ns

Posted by Geliang Tang 11 months, 1 week ago

Matthieu Baerts <matthieu.baerts@tessares.net> 于2023年5月19日周五 17:36写道：
>
> Hi Geliang,
>
> On 18/05/2023 00:29, Geliang Tang wrote:
> > v4:
> >  - patch #1 could be merged before "mptcp: refactor push_pending logic"
> >    as a single fix.
> >  - patch #2 should be merged between "selftests/bpf: Add mptcp sched
> >    structs" and "selftests/bpf: Add bpf_first scheduler".
>
> Thank you for the new version and for the explanations!
>
> I suggest to apply the first patch also between "selftests/bpf: Add
> mptcp sched structs" and "selftests/bpf: Add bpf_first scheduler" as it
> seems not needed before (see my comment on this patch).

I agree. Please update the commit logs for me when merging them.

Thanks,
-Geliang

>
> Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
>
> Cheers,
> Matt
> --
> Tessares | Belgium | Hybrid Access Solutions
> www.tessares.net
>

Re: [PATCH mptcp-next v4 0/6] run sched tests in a dedicated ns

Posted by Matthieu Baerts 11 months, 1 week ago

Hi Geliang,

On 19/05/2023 11:58, Geliang Tang wrote:
> Matthieu Baerts <matthieu.baerts@tessares.net> 于2023年5月19日周五 17:36写道：
>>
>> Hi Geliang,
>>
>> On 18/05/2023 00:29, Geliang Tang wrote:
>>> v4:
>>>  - patch #1 could be merged before "mptcp: refactor push_pending logic"
>>>    as a single fix.
>>>  - patch #2 should be merged between "selftests/bpf: Add mptcp sched
>>>    structs" and "selftests/bpf: Add bpf_first scheduler".
>>
>> Thank you for the new version and for the explanations!
>>
>> I suggest to apply the first patch also between "selftests/bpf: Add
>> mptcp sched structs" and "selftests/bpf: Add bpf_first scheduler" as it
>> seems not needed before (see my comment on this patch).
> 
> I agree. Please update the commit logs for me when merging them.

Great, just did, hopefully as expected.

New patches for t/upstream:
- 022ddca0dd31: selftests/bpf: use random netns name for mptcp
- fa066ce14aa8: selftests/bpf: add two mptcp netns helpers
- 90d56a205185: "squashed" patch 3/6 in "selftests/bpf: Add bpf_first test"
- e17099987f21: "squashed" patch 4/6 in "selftests/bpf: Add bpf_bkup test"
- 8c10fe1b6365: "squashed" patch 5/6 in "selftests/bpf: Add bpf_rr test"
- 4101020d41c3: "squashed" patch 6/6 in "selftests/bpf: Add bpf_red test"
- Results: c20d0380b999..577d6a7db2fb (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20230519T120144

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net