[v9] update userspace pm mptcp_info fields, pt 1

[PATCH mptcp-next v9 0/6] update userspace pm mptcp_info fields, pt 1

Geliang Tang posted 6 patches 1 year, 5 months ago

Diff against v8 v10
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1682409247.git.geliang.tang@suse.com

Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, Mat Martineau <martineau@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>, Kishen Maloor <kishen.maloor@intel.com>, Geliang Tang <geliang.tang@suse.com>

There is a newer version of this series

net/mptcp/pm_netlink.c                        | 24 +++++++++--
net/mptcp/pm_userspace.c                      | 42 ++++++++++++++++++-
net/mptcp/protocol.h                          |  3 ++
.../testing/selftests/net/mptcp/mptcp_join.sh | 11 ++++-
4 files changed, 74 insertions(+), 6 deletions(-)

Expand all Fold all

[PATCH mptcp-next v9 0/6] update userspace pm mptcp_info fields, pt 1

Posted by Geliang Tang 1 year, 5 months ago

v9:
 - address Matt's commets in v8.

v8:
 - address Matt's comments.
 - split into two series, pt 2 will send later.

v7:
 - fix userspace_pm.sh errors reported by CI.
 - only remove addrs in mptcp_nl_cmd_remove().

v6:
 - send a RM ADDR from userspace.

v5:
 - fix a memleak error reported by CI.
 - add more delay for userspace pm tests.

v4:
 - add more patches
 - add selftests

v3:
 - update local_addr_used and add_addr_signaled

v2:
 - hold pm locks

Geliang Tang (6):
  mptcp: only send RM_ADDR in nl_cmd_remove
  selftests: mptcp: update userspace pm addr tests
  mptcp: add addr into userspace pm list
  mptcp: export remove_anno_list_by_saddr
  mptcp: add addr into pm anno_list
  selftests: mptcp: update userspace pm subflow tests

 net/mptcp/pm_netlink.c                        | 24 +++++++++--
 net/mptcp/pm_userspace.c                      | 42 ++++++++++++++++++-
 net/mptcp/protocol.h                          |  3 ++
 .../testing/selftests/net/mptcp/mptcp_join.sh | 11 ++++-
 4 files changed, 74 insertions(+), 6 deletions(-)

-- 
2.35.3

Re: [PATCH mptcp-next v9 0/6] update userspace pm mptcp_info fields, pt 1

Posted by Matthieu Baerts 1 year, 5 months ago

Hi Geliang,

On 25/04/2023 09:55, Geliang Tang wrote:
> v9:
>  - address Matt's commets in v8.

Thank you for this v9. It looks better!

It looks like the CI spot some issues with the userspace_pm selftest:

> - KVM Validation: normal (except selftest_mptcp_join):
>   - Unstable: 1 failed test(s): selftest_userspace_pm 🔴:
>   - Task: https://cirrus-ci.com/task/6754937204375552
>   - Summary: https://api.cirrus-ci.com/v1/artifact/task/6754937204375552/summary/summary.txt
> 
> - KVM Validation: debug (except selftest_mptcp_join):
>   - Unstable: 1 failed test(s): selftest_userspace_pm 🔴:
>   - Task: https://cirrus-ci.com/task/5629861931253760
>   - Summary: https://api.cirrus-ci.com/v1/artifact/task/5629861931253760/summary/summary.txt

I have a few comments and ideas, I'm going to share that in each
individual patch.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net