[PATCH mptcp-next v10 0/6] update userspace pm mptcp_info fields, pt 1

Geliang Tang posted 6 patches 1 year, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1682499136.git.geliang.tang@suse.com
Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, Mat Martineau <martineau@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>, Kishen Maloor <kishen.maloor@intel.com>, Geliang Tang <geliang.tang@suse.com>
net/mptcp/pm_netlink.c                        | 26 +++++++++--
net/mptcp/pm_userspace.c                      | 45 ++++++++++++++++++-
net/mptcp/protocol.h                          |  3 ++
.../testing/selftests/net/mptcp/mptcp_join.sh | 11 ++++-
4 files changed, 79 insertions(+), 6 deletions(-)
[PATCH mptcp-next v10 0/6] update userspace pm mptcp_info fields, pt 1
Posted by Geliang Tang 1 year, 1 month ago
v10:
 - fix userspace_pm.sh errors reported by CI.
 - fix the bug in mptcp_pm_remove_addrs in patch 1.
 - drop msk->pm.subflow == 1 in mptcp_userspace_pm_delete_local_addr in
   patch 3.
 - exchange the order of "pm_nl_ctl rem" and "pm_nl_ctl dsf" in patch 2
   and 6.
 - update the commit logs.

v9:
 - address Matt's commets in v8.

v8:
 - address Matt's comments.
 - split into two series, pt 2 will send later.

v7:
 - fix userspace_pm.sh errors reported by CI.
 - only remove addrs in mptcp_nl_cmd_remove().

v6:
 - send a RM ADDR from userspace.

v5:
 - fix a memleak error reported by CI.
 - add more delay for userspace pm tests.

v4:
 - add more patches
 - add selftests

v3:
 - update local_addr_used and add_addr_signaled

v2:
 - hold pm locks

Geliang Tang (6):
  mptcp: only send RM_ADDR in nl_cmd_remove
  selftests: mptcp: update userspace pm addr tests
  mptcp: add addr into userspace pm list
  mptcp: export remove_anno_list_by_saddr
  mptcp: add addr into pm anno_list
  selftests: mptcp: update userspace pm subflow tests

 net/mptcp/pm_netlink.c                        | 26 +++++++++--
 net/mptcp/pm_userspace.c                      | 45 ++++++++++++++++++-
 net/mptcp/protocol.h                          |  3 ++
 .../testing/selftests/net/mptcp/mptcp_join.sh | 11 ++++-
 4 files changed, 79 insertions(+), 6 deletions(-)

-- 
2.35.3
Re: [PATCH mptcp-next v10 0/6] update userspace pm mptcp_info fields, pt 1
Posted by Matthieu Baerts 1 year, 1 month ago
Hi Geliang,

On 26/04/2023 10:56, Geliang Tang wrote:
> v10:
>  - fix userspace_pm.sh errors reported by CI.
>  - fix the bug in mptcp_pm_remove_addrs in patch 1.
>  - drop msk->pm.subflow == 1 in mptcp_userspace_pm_delete_local_addr in
>    patch 3.
>  - exchange the order of "pm_nl_ctl rem" and "pm_nl_ctl dsf" in patch 2
>    and 6.
>  - update the commit logs.
Thank you for this v10 and sorry for the delay!

The code looks good to me, I just have some questions for you in the
individual patches: do you mind replying to these questions please?

Maybe all we need is to add a TODO comment/ticket and re-order/squash
patches? Or maybe not, I will see your replies!

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net