mptcp_connect.sh can be executed manually with "-m <MODE>" and "-C".

These modes should be validated, but they are not when the selftests are
executed via the kselftest helpers. To fix that, new test programs have
been added, simply calling mptcp_connect.sh with the right parameters.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Matthieu Baerts (NGI0) (2):
      selftests: mptcp: connect: also cover alt modes
      selftests: mptcp: connect: also cover checksum

 tools/testing/selftests/net/mptcp/Makefile                  | 3 ++-
 tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh | 4 ++++
 tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh     | 4 ++++
 tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh | 4 ++++
 4 files changed, 14 insertions(+), 1 deletion(-)
---
base-commit: df15676c95d593e64720b86babe913924c3d5649
change-id: 20250708-selftests-mptcp-connect-modes-5d7aa9e1158d

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>

Hi Matt,

On Tue, 2025-07-08 at 19:37 +0200, Matthieu Baerts (NGI0) wrote:
> mptcp_connect.sh can be executed manually with "-m <MODE>" and "-C".
> 
> These modes should be validated, but they are not when the selftests
> are
> executed via the kselftest helpers. To fix that, new test programs
> have
> been added, simply calling mptcp_connect.sh with the right
> parameters.
> 
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

LGTM!

Reviewed-by: Geliang Tang <geliang@kernel.org>

Thanks,
-Geliang

> ---
> Matthieu Baerts (NGI0) (2):
>       selftests: mptcp: connect: also cover alt modes
>       selftests: mptcp: connect: also cover checksum
> 
>  tools/testing/selftests/net/mptcp/Makefile                  | 3 ++-
>  tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh | 4 ++++
>  tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh     | 4 ++++
>  tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh | 4 ++++
>  4 files changed, 14 insertions(+), 1 deletion(-)
> ---
> base-commit: df15676c95d593e64720b86babe913924c3d5649
> change-id: 20250708-selftests-mptcp-connect-modes-5d7aa9e1158d
> 
> Best regards,

Hi Geliang,

On 09/07/2025 09:36, Geliang Tang wrote:
> Hi Matt,
> 
> On Tue, 2025-07-08 at 19:37 +0200, Matthieu Baerts (NGI0) wrote:
>> mptcp_connect.sh can be executed manually with "-m <MODE>" and "-C".
>>
>> These modes should be validated, but they are not when the selftests
>> are
>> executed via the kselftest helpers. To fix that, new test programs
>> have
>> been added, simply calling mptcp_connect.sh with the right
>> parameters.
>>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> LGTM!
> 
> Reviewed-by: Geliang Tang <geliang@kernel.org>

Thank you, applied!

New patches for t/upstream-net and t/upstream:
- 6d62c20d77d9: selftests: mptcp: connect: also cover alt modes
- c3fbf767eb3b: selftests: mptcp: connect: also cover checksum
- Results: 6bd3385eb1f8..e8a7c6b2c828 (export-net)
- Results: 5cdb68fbc7ee..0f11bd74a704 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/8cc3145e7535dd60f02cad008912e1b513adecdd/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/f0042bb4116cfe555f220715588193479b841dbc/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.