From nobody Mon Feb 9 07:35:03 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 658AE14A60D for ; Tue, 8 Jul 2025 17:38:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751996308; cv=none; b=VYbYAwRJ/prVvuqTe8T0i8K7tVbKKVPBl+RPYo5DT34FAWemjRJEi3eVik9BpZ19AvgABqO22u33uTjyZ7LlJkjLmp2CUtQRtfDVLwvQfFc2r9YOJaPCRAX5pB+g7gp4d7U3kHRc/GCS2XsXuRX+F02nun8i3HKD3urOtilzSRY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751996308; c=relaxed/simple; bh=S404SSDy/WrS6OFGfOpE1Xtb5KvT9yyfcojrz0fUEF4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Fu5C6Us1pz/ZEVizfD8Dk3a4Wk1toYg53KERLznmbb37plhnJyt9lL7J8o/TqdI/97Zx9M+8ADxrELAfYTHcbxcMnnSiDiWkv3d+avac00vK0NIlioggtZu29BEROxw5wl2fmXsqG23w7kzMlOYH1/SuKNzkQ09kCcAbSvBpv0c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P7lLdHT8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P7lLdHT8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CFF1C4CEF5; Tue, 8 Jul 2025 17:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751996307; bh=S404SSDy/WrS6OFGfOpE1Xtb5KvT9yyfcojrz0fUEF4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=P7lLdHT8B82hn881FNc2PosciXbpZJji5L+KRsqTPs5HjGRejpH6ai6/+eBWzu41Z THDjhajoeNDxAlFxGjQ0fC17AESpw8/XDuPD+Dbxht1uv5/6IQTgH3GvaqO7EsjIc3 JDfYNd7vAstr/6uvhXcyTfI7dXP/S8ICYaj5gxpZ/eYsfDaEGSxR4SsV7bmCyO20LV Hk6KG73C+JbB1HN5R9FpwSBZFWvHFxYUyuhvkL1JEULVOC6voCOVoJRz3sLja1Wi0J gjpkT/1QMRI6UpkkzP9F19mNpywwNJZhaJD32o77ltcHkDxaS37NCrF/EEVNeAWLav Fh+oBeVYlsEYw== From: "Matthieu Baerts (NGI0)" Date: Tue, 08 Jul 2025 19:37:59 +0200 Subject: [PATCH mptcp-net 1/2] selftests: mptcp: connect: also cover alt modes Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250708-selftests-mptcp-connect-modes-v1-1-f8e6f9828fd8@kernel.org> References: <20250708-selftests-mptcp-connect-modes-v1-0-f8e6f9828fd8@kernel.org> In-Reply-To: <20250708-selftests-mptcp-connect-modes-v1-0-f8e6f9828fd8@kernel.org> To: mptcp@lists.linux.dev Cc: Geliang Tang , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2655; i=matttbe@kernel.org; h=from:subject:message-id; bh=S404SSDy/WrS6OFGfOpE1Xtb5KvT9yyfcojrz0fUEF4=; b=owGbwMvMwCVWo/Th0Gd3rumMp9WSGDJywydkeoUfO5jqnsuzSeBuasSx1Pf+qe2nw1gPrzKeu p5t7yuvjlIWBjEuBlkxRRbptsj8mc+reEu8/Cxg5rAygQxh4OIUgIkY9DIy9L2c07Mv4haLrWT4 jFnHRH3nK53g3/D4w/IlAbMvebdyLGL4Z9Uzr7z2yZec36xvwyutbjZM/DjzeN9SadEL5WuWLn7 DxgoA X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 The "mmap" and "sendfile" alternate modes for mptcp_connect.sh/.c are available from the beginning, but only tested when mptcp_connect.sh is manually launched with "-m mmap" or "-m sendfile", not via the kselftests helpers. The MPTCP CI was manually running "mptcp_connect.sh -m mmap", but not "-m sendfile". Plus other CIs, especially the ones validating the stable releases, were not validating these alternate modes. To make sure these modes are validated by these CIs, add two new test programs executing mptcp_connect.sh with the alternate modes. Fixes: 048d19d444be ("mptcp: add basic kselftest for mptcp") Signed-off-by: Matthieu Baerts (NGI0) Reviewed-by: Geliang Tang --- tools/testing/selftests/net/mptcp/Makefile | 3 ++- tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh | 4 ++++ tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh | 4 ++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/Makefile b/tools/testing/sel= ftests/net/mptcp/Makefile index e47788bfa671313f21d5ba95821121cdc3e5d2c7..c6b030babba8cf888101d6af44f= 3e56fe5ab831b 100644 --- a/tools/testing/selftests/net/mptcp/Makefile +++ b/tools/testing/selftests/net/mptcp/Makefile @@ -4,7 +4,8 @@ top_srcdir =3D ../../../../.. =20 CFLAGS +=3D -Wall -Wl,--no-as-needed -O2 -g -I$(top_srcdir)/usr/include $(= KHDR_INCLUDES) =20 -TEST_PROGS :=3D mptcp_connect.sh pm_netlink.sh mptcp_join.sh diag.sh \ +TEST_PROGS :=3D mptcp_connect.sh mptcp_connect_mmap.sh mptcp_connect_sendf= ile.sh \ + pm_netlink.sh mptcp_join.sh diag.sh \ simult_flows.sh mptcp_sockopt.sh userspace_pm.sh =20 TEST_GEN_FILES =3D mptcp_connect pm_nl_ctl mptcp_sockopt mptcp_inq mptcp_d= iag diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh b/tool= s/testing/selftests/net/mptcp/mptcp_connect_mmap.sh new file mode 100755 index 0000000000000000000000000000000000000000..09bde1303bf79198fe9f7890cbe= 89901859d78e8 --- /dev/null +++ b/tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh @@ -0,0 +1,4 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 + +"$(dirname "${0}")/mptcp_connect.sh" -m mmap "${@}" diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh b/= tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh new file mode 100755 index 0000000000000000000000000000000000000000..c50d08481581f0f8997c6f4f217= 4d606150bfa6a --- /dev/null +++ b/tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh @@ -0,0 +1,4 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 + +"$(dirname "${0}")/mptcp_connect.sh" -m sendfile "${@}" --=20 2.48.1 From nobody Mon Feb 9 07:35:03 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67A4E14A60D for ; Tue, 8 Jul 2025 17:38:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751996309; cv=none; b=gyUHn3h2J8HsnV6hMsox4RAnUeWwbSPt33yXfNhiZZddHI0VZm6BVjz8cV+0jrh0U7kFQvNjOWFUZ4Z5TwjGlTYkkqn6/OsmennrXjHR+rx8XoRXfw0ShJGyp3OuX9jaoLxuP5amfp+jz8CvPI8O5MPoVJ8CB6Bc4RqhQRRcKMg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751996309; c=relaxed/simple; bh=HzxR7hVoBbwUIp+tGuMaE6/9JvJFmiC6G2/cqNxHwQI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ABE2FUNd4VFWzDB95rZLsd316XsWjVVFVDl+DtP10cn9hbQwOYNahEbPrQpgHVhVSP0QcBBswJh/CBTbyGYUKTIqvmYiKLFx4iuHS6VuXu1sIiMoLg/mYteMmdbwQbiOkRPTWrS5/yQQYqxrxX8to/rmloPn6E0LhJmYEH8S6PY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iQX4nvZb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iQX4nvZb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C256C4CEF0; Tue, 8 Jul 2025 17:38:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751996308; bh=HzxR7hVoBbwUIp+tGuMaE6/9JvJFmiC6G2/cqNxHwQI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=iQX4nvZbU1PhJAp+ulStNjchJM9NLE1y3hbi5LoAmXAfoBisrSL3ilhLCQNGc3Lpk RzBLagkGwlHoGyT7ws1rEjlT5BWHZgGb+sjB20XsSoERL9RoQIDthnjpEnbX9/Mv3o MxjbR1Z6fn4+ces6nJjKjsu+5pM2cS/c4OBeXmcBvbDNFxutXloN7ZTCNlHp5CDqK/ UnOP7fCeUcOHZhmDsnY+Xo/8Di0Mzvg7SYPLdIWQKPEWOKFnbutxOpmzxU0bl0CyPY CI/v9kKWbICn3XRzvNxJImqgOmUajnykXbXOCi6YDzbKdMVjaGmZpo4HHvW+qL1k1h /wf8xIuJq1e0g== From: "Matthieu Baerts (NGI0)" Date: Tue, 08 Jul 2025 19:38:00 +0200 Subject: [PATCH mptcp-net 2/2] selftests: mptcp: connect: also cover checksum Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250708-selftests-mptcp-connect-modes-v1-2-f8e6f9828fd8@kernel.org> References: <20250708-selftests-mptcp-connect-modes-v1-0-f8e6f9828fd8@kernel.org> In-Reply-To: <20250708-selftests-mptcp-connect-modes-v1-0-f8e6f9828fd8@kernel.org> To: mptcp@lists.linux.dev Cc: Geliang Tang , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1899; i=matttbe@kernel.org; h=from:subject:message-id; bh=HzxR7hVoBbwUIp+tGuMaE6/9JvJFmiC6G2/cqNxHwQI=; b=owGbwMvMwCVWo/Th0Gd3rumMp9WSGDJywyfqLPjNpmd26YTDCc145uNz+kXjH97xuqevbpKxr nvt46uFHaUsDGJcDLJiiizSbZH5M59X8ZZ4+VnAzGFlAhnCwMUpABO5uYaR4fauSZ/CG2x5109R 2Ma90Jb9dNRCsQVLA1LmVsvcWJ5rtYXhnw7PvIi7epw72vYZFn9jYL62TWDew9S7R2cKfv10V3/ 3YkYA X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 The checksum mode has been added a while ago, but it is only validated when manually launching mptcp_connect.sh with "-C". The different CIs were then not validating these MPTCP Connect tests with checksum enabled. To make sure they do, add a new test program executing mptcp_connect.sh with the checksum mode. Fixes: 94d66ba1d8e4 ("selftests: mptcp: enable checksum in mptcp_connect.sh= ") Signed-off-by: Matthieu Baerts (NGI0) Reviewed-by: Geliang Tang --- tools/testing/selftests/net/mptcp/Makefile | 2 +- tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/Makefile b/tools/testing/sel= ftests/net/mptcp/Makefile index c6b030babba8cf888101d6af44f3e56fe5ab831b..4c7e51336ab25c662f02719f163= 2fa2d27d148f1 100644 --- a/tools/testing/selftests/net/mptcp/Makefile +++ b/tools/testing/selftests/net/mptcp/Makefile @@ -5,7 +5,7 @@ top_srcdir =3D ../../../../.. CFLAGS +=3D -Wall -Wl,--no-as-needed -O2 -g -I$(top_srcdir)/usr/include $(= KHDR_INCLUDES) =20 TEST_PROGS :=3D mptcp_connect.sh mptcp_connect_mmap.sh mptcp_connect_sendf= ile.sh \ - pm_netlink.sh mptcp_join.sh diag.sh \ + mptcp_connect_checksum.sh pm_netlink.sh mptcp_join.sh diag.sh \ simult_flows.sh mptcp_sockopt.sh userspace_pm.sh =20 TEST_GEN_FILES =3D mptcp_connect pm_nl_ctl mptcp_sockopt mptcp_inq mptcp_d= iag diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh b/= tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh new file mode 100755 index 0000000000000000000000000000000000000000..569340d4f00ae2e4655b30220bc= fce695549a686 --- /dev/null +++ b/tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh @@ -0,0 +1,4 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 + +"$(dirname "${0}")/mptcp_connect.sh" -C "${@}" --=20 2.48.1