[PATCH mptcp-next v3 00/12] Refactor mptcp_join.sh

Matthieu Baerts posted 12 patches 2 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20220224135619.2523272-1-matthieu.baerts@tessares.net
Maintainers: "David S. Miller" <davem@davemloft.net>, Mat Martineau <mathew.j.martineau@linux.intel.com>, Shuah Khan <shuah@kernel.org>, Jakub Kicinski <kuba@kernel.org>, Matthieu Baerts <matthieu.baerts@tessares.net>
There is a newer version of this series
.../testing/selftests/net/mptcp/mptcp_join.sh | 2435 +++++++++--------
1 file changed, 1297 insertions(+), 1138 deletions(-)
[PATCH mptcp-next v3 00/12] Refactor mptcp_join.sh
Posted by Matthieu Baerts 2 years, 2 months ago
It is very similar to the v2 but rebased and with 3 new patches.

The new patches:

- patch 1/12: 'ip mptcp' wrappers were missing in a patch which is in
  the export branch for a bit of time now. While at it, a new helper has
  been added to avoid long 'ip netns exec' commands as suggested by
  Paolo.

- patch 3/12: just to move an helper with the other ones

- patch 12/12: add new helpers to avoid long 'ip netns exec' commands,
  also suggested by Paolo.

The rest is less interesting. There are some modification in patches
6-8/12 because there are new tests in our tree: it was needed to modify
more code around the new usage of 'reset' and 'ret=1' but nothing
complex there.

In patch 6/12, I removed a new long comment that is probably not needed:
with the indentation, it looked even harder to read. If we need the
comment, probably best to create a dedicated function, use variables
with a clear name or use words instead of just a series of numbers.

Also in patch 13/14, there was a new shellcheck issue ("Useless cat.":
@Paolo: did you introduce this ShellCheck rule???).

Matthieu Baerts (12):
  Squash to "selftests: mptcp: Add tests for userspace PM type"
  Squash to "selftests: mptcp: join: allow running -cCi"
  Squash to "selftests: mptcp: add implicit endpoint test case"
  selftests: mptcp: join: define tests groups once
  selftests: mptcp: join: reset failing links
  selftests: mptcp: join: option to execute specific tests
  selftests: mptcp: join: alt. to exec specific tests
  selftests: mptcp: join: list failure at the end
  selftests: mptcp: join: clarify local/global vars
  selftests: mptcp: join: avoid backquotes
  selftests: mptcp: join: make it shellcheck compliant
  selftests: mptcp: join: helper to filter TCP

 .../testing/selftests/net/mptcp/mptcp_join.sh | 2435 +++++++++--------
 1 file changed, 1297 insertions(+), 1138 deletions(-)

-- 
2.34.1