This fixes 3 issues introduced in v3:

- patch 3/12 reworks more the original patch not to increment the counter
  per subtest. See the commit message for more details.

- patch 7/12 modifies the new 'reset' functions recently added

- patch 12/12 fixes a typo reported by Geliang

I also move "helper to filter TCP" patch sooner, before the clean-up.

Matthieu Baerts (12):
  Squash to "selftests: mptcp: Add tests for userspace PM type"
  Squash to "selftests: mptcp: join: allow running -cCi"
  Squash to "selftests: mptcp: add implicit endpoint test case"
  selftests: mptcp: join: define tests groups once
  selftests: mptcp: join: reset failing links
  selftests: mptcp: join: option to execute specific tests
  selftests: mptcp: join: alt. to exec specific tests
  selftests: mptcp: join: list failure at the end
  selftests: mptcp: join: helper to filter TCP
  selftests: mptcp: join: clarify local/global vars
  selftests: mptcp: join: avoid backquotes
  selftests: mptcp: join: make it shellcheck compliant

 .../testing/selftests/net/mptcp/mptcp_join.sh | 2451 +++++++++--------
 1 file changed, 1307 insertions(+), 1144 deletions(-)

-- 
2.34.1

On Thu, 24 Feb 2022, Matthieu Baerts wrote:

> This fixes 3 issues introduced in v3:
>
> - patch 3/12 reworks more the original patch not to increment the counter
>  per subtest. See the commit message for more details.
>
> - patch 7/12 modifies the new 'reset' functions recently added
>
> - patch 12/12 fixes a typo reported by Geliang
>
> I also move "helper to filter TCP" patch sooner, before the clean-up.
>

Hi Matthieu -

Thanks for the update, you can add

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

to the commits that don't already have it. I looked through those just now 
and don't have more suggestions. Also runs fine in my test vm.

I'm looking at all the mptcp_join.sh patches queued up in the export... we 
might need to work together on some reordering to move the "not for 5.18" 
patches to the end of the queue.

-Mat


> Matthieu Baerts (12):
>  Squash to "selftests: mptcp: Add tests for userspace PM type"
>  Squash to "selftests: mptcp: join: allow running -cCi"
>  Squash to "selftests: mptcp: add implicit endpoint test case"
>  selftests: mptcp: join: define tests groups once
>  selftests: mptcp: join: reset failing links
>  selftests: mptcp: join: option to execute specific tests
>  selftests: mptcp: join: alt. to exec specific tests
>  selftests: mptcp: join: list failure at the end
>  selftests: mptcp: join: helper to filter TCP
>  selftests: mptcp: join: clarify local/global vars
>  selftests: mptcp: join: avoid backquotes
>  selftests: mptcp: join: make it shellcheck compliant
>
> .../testing/selftests/net/mptcp/mptcp_join.sh | 2451 +++++++++--------
> 1 file changed, 1307 insertions(+), 1144 deletions(-)
>
> -- 
> 2.34.1
>
>
>

--
Mat Martineau
Intel

Hi Mat,

On 24/02/2022 22:33, Matthieu Baerts wrote:
> This fixes 3 issues introduced in v3:
> 
> - patch 3/12 reworks more the original patch not to increment the counter
>   per subtest. See the commit message for more details.
> 
> - patch 7/12 modifies the new 'reset' functions recently added
> 
> - patch 12/12 fixes a typo reported by Geliang
> 
> I also move "helper to filter TCP" patch sooner, before the clean-up.

Thank you for the review!

Now in our tree with your RvB tags where it was missing:

Squash-to patches:

- 3cf781e00952: "squashed" patch 01/12 in "selftests: mptcp: Add tests
for userspace PM type"
- d2eea8383653: "Signed-off-by" + "Co-developed-by"
- Results: 8fe46ed11c27..258cadbd8399

- bdc0934aee32: "squashed" patch 02/12 in "selftests: mptcp: join: allow
running -cCi"
- 36f524524558: tg:msg: adapt 'selftests-mptcp-join-allow-running-cCi'
- 3380e67af5d9: conflict in
t/selftests-mptcp-add-implicit-endpoint-test-case
- Results: 258cadbd8399..35ba827a8b1e

- 66cc24cd88ee: "squashed" patch 03/12 in "selftests: mptcp: add
implicit endpoint test case"
- 5782c65ac1fa: "Signed-off-by" + "Co-developed-by"
- Results: 35ba827a8b1e..0c1c6c50d9dd

The other patches:

- aca1cdceb825: selftests: mptcp: join: define tests groups once
- b33b509b2f26: selftests: mptcp: join: reset failing links
- 87c975a5d421: selftests: mptcp: join: option to execute specific tests
- f5c2075414ae: selftests: mptcp: join: alt. to exec specific tests
- 78fb82cf3c8c: selftests: mptcp: join: list failure at the end
- ae1b2dd743aa: selftests: mptcp: join: helper to filter TCP
- 2d273f0e7eb6: selftests: mptcp: join: clarify local/global vars
- 96961994425b: selftests: mptcp: join: avoid backquotes
- 054ac453676a: selftests: mptcp: join: make it shellcheck compliant
- Results: 0c1c6c50d9dd..64843b43f8de

Builds and tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220225T133622
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net