qemu: Fix comment in qemuProcessSetupPid

[PATCH] qemu: Fix comment in qemuProcessSetupPid

Martin Kletzander posted 1 patch 3 years, 7 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/fc7d53edf48a7a29397f883c0106d6b7a7c3757f.1599392866.git.mkletzan@redhat.com

src/qemu/qemu_process.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH] qemu: Fix comment in qemuProcessSetupPid

Posted by Martin Kletzander 3 years, 7 months ago

This was supposed to be done in commit 3791f29b085c, but I missed a spot.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
Pushed as trivial, also suggested here:

  https://www.redhat.com/archives/libvir-list/2020-September/msg00275.html

 src/qemu/qemu_process.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 17d083d192a5..934fab98bc42 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -2751,9 +2751,8 @@ qemuProcessSetupPid(virDomainObjPtr vm,
          *  1) libvirtd does not have CAP_SYS_NICE
          *  2) libvirtd does not run on all CPUs
          *
-         * However since this scenario is very improbable, we rather skip
-         * reporting the error because it helps running libvirtd in a a scenario
-         * where pinning is handled by someone else.
+         * This scenario can easily occurr when libvirtd is run inside a
+         * container with restrictive permissions and CPU pinning.
          *
          * See also: https://bugzilla.redhat.com/1819801#c2
          */
-- 
2.28.0