From nobody Thu May 2 06:26:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599393000; cv=none; d=zohomail.com; s=zohoarc; b=cTlphKAdz5AGnCGdBzRkgDGp3JyyN7E5G/yj1ZtcFHla/VwUPPa+wGXBoK/IUpvcfdwx2bJkVq9scwuNWTS6KRFJslbJZpXUSOE7LSOyif832gAUBjQ28kkRQXCcPyMkoiP6bduuLLQl7k3t5+I99EsZ17vQvVMiEaZ83zuLnLY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599393000; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=JWIidfdq5wwRveAAoY0r0EPjALwg7S2KkO5nlCj/+YI=; b=jVydpymNyPPxkLrEM1HGjfjqs175sUj9eb+FCI4+iCV5JVeYqt54tb7pni8DT0dUBW/7G3ifQXidCpj6XLO694Q8AYfTHblZ4PS9mTcsyf91bG0JlQKKlGEYWqsKdb15cIzEme3+w+PWS8yJ9Ne70fF9YSqIhJjgRv7WOBvU8LI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 159939300067572.70852426285; Sun, 6 Sep 2020 04:50:00 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-fjodi30kPpufezlVCFv9NQ-1; Sun, 06 Sep 2020 07:49:57 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F19C61888A1A; Sun, 6 Sep 2020 11:49:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AB2BF6F142; Sun, 6 Sep 2020 11:49:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 661FF97309; Sun, 6 Sep 2020 11:49:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 086BmgbS014754 for ; Sun, 6 Sep 2020 07:48:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6D56C60C11; Sun, 6 Sep 2020 11:48:42 +0000 (UTC) Received: from caroline.localdomain (unknown [10.40.192.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4045860C0F for ; Sun, 6 Sep 2020 11:48:39 +0000 (UTC) Received: from caroline.redhat.com (caroline.k8r.cz [127.0.0.1]) by caroline.localdomain (Postfix) with ESMTP id 0801722C615A for ; Sun, 6 Sep 2020 13:48:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599392999; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=JWIidfdq5wwRveAAoY0r0EPjALwg7S2KkO5nlCj/+YI=; b=HV/OFJ33HeFR92xwz0NEByOgV8K5NAaYP3bmkuDmJ4nxk2kxn2O122tieQ1W0OpeA5/uUO litknGd5+Fd9Q2AIR81acZfK2N3/y1bGHtePr9YmncGEYYHJj605effqQMoj20AnBvIJ2V Lh23PfRgWUIq6tNELxkCrsq7PZWZrVY= X-MC-Unique: fjodi30kPpufezlVCFv9NQ-1 From: Martin Kletzander To: libvir-list@redhat.com Subject: [PATCH] qemu: Fix comment in qemuProcessSetupPid Date: Sun, 6 Sep 2020 13:48:34 +0200 Message-Id: MIME-Version: 1.0 X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" This was supposed to be done in commit 3791f29b085c, but I missed a spot. Signed-off-by: Martin Kletzander --- Pushed as trivial, also suggested here: https://www.redhat.com/archives/libvir-list/2020-September/msg00275.html src/qemu/qemu_process.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 17d083d192a5..934fab98bc42 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -2751,9 +2751,8 @@ qemuProcessSetupPid(virDomainObjPtr vm, * 1) libvirtd does not have CAP_SYS_NICE * 2) libvirtd does not run on all CPUs * - * However since this scenario is very improbable, we rather skip - * reporting the error because it helps running libvirtd in a a sc= enario - * where pinning is handled by someone else. + * This scenario can easily occurr when libvirtd is run inside a + * container with restrictive permissions and CPU pinning. * * See also: https://bugzilla.redhat.com/1819801#c2 */ --=20 2.28.0