[libvirt PATCH] vz: fix vzCapsAddGuestDomain

Ján Tomko posted 1 patch 2 years, 4 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/f6373579db837fcdee0ee249d9a4a11a1466e349.1638202561.git.jtomko@redhat.com
src/vz/vz_driver.c | 2 --
1 file changed, 2 deletions(-)
[libvirt PATCH] vz: fix vzCapsAddGuestDomain
Posted by Ján Tomko 2 years, 4 months ago
There is a stray 'return -1' executed on all code paths.

Fixes: c18d9e23fafabcfbb80481e0705931036b8e7331
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/vz/vz_driver.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index b47266290c..23b7795035 100644
--- a/src/vz/vz_driver.c
+++ b/src/vz/vz_driver.c
@@ -85,8 +85,6 @@ vzCapsAddGuestDomain(virCaps *caps,
 
     guest = virCapabilitiesAddGuest(caps, ostype, arch,
                                     emulator, NULL, 0, NULL);
-        return -1;
-
 
     virCapabilitiesAddGuestDomain(guest, virt_type, NULL, NULL, 0, NULL);
 
-- 
2.31.1

Re: [libvirt PATCH] vz: fix vzCapsAddGuestDomain
Posted by Michal Prívozník 2 years, 4 months ago
On 11/29/21 17:16, Ján Tomko wrote:
> There is a stray 'return -1' executed on all code paths.
> 
> Fixes: c18d9e23fafabcfbb80481e0705931036b8e7331
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/vz/vz_driver.c | 2 --
>  1 file changed, 2 deletions(-)
> 

Ooops.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal