From nobody Fri May 3 17:25:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1638202590; cv=none; d=zohomail.com; s=zohoarc; b=XyWY5vrPCXQjNLkrJudmxFTq+tYI+u/6NJw6RTFDK5CoE6iM8mjz1OdFiMQ2cYnyJQvSNH1hpz/tjcvC2cAe/SwozUTIFaZnjCgOr3iMzhzVfTxXdU5wVOWQf9LadNiQWamLtQdVsjAdekQmef39sV/HKKTacblGzefDPj8JRgQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1638202590; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=5PMgnZCDvekItygdF5yakUrgAJ4I77EJ3gRtJAFpfKQ=; b=iFy91P2CHuSUsBqKJIvT26n37DYi+xhG01WfrfhMG6h9lcilQLvnA7Ky+sIBfDxMcah0QHLQQ+n45JPCpLHaplS2Ab7OtBlISdSYdqdd0ZSBnGSoc128ZOh4246jZERJt47DCoKeTLA8+TkX2+nzNJKuWIt9hKD0KAsisf7nY/o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1638202590635110.3469782414478; Mon, 29 Nov 2021 08:16:30 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-458-O-hmoWDMOs2a-LqAEv92xw-1; Mon, 29 Nov 2021 11:16:26 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A898192FDA4; Mon, 29 Nov 2021 16:16:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4A5A85D9C0; Mon, 29 Nov 2021 16:16:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E88304BB7C; Mon, 29 Nov 2021 16:16:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1ATGGImS014840 for ; Mon, 29 Nov 2021 11:16:18 -0500 Received: by smtp.corp.redhat.com (Postfix) id B134D45D62; Mon, 29 Nov 2021 16:16:18 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.43.2.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id 399E345D61 for ; Mon, 29 Nov 2021 16:16:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638202589; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=5PMgnZCDvekItygdF5yakUrgAJ4I77EJ3gRtJAFpfKQ=; b=Nxo7wt1mCWXTyT4kf5Wn+S41StohmJwRnFmXndeHqH5JfPXFg9BprWqZMoLUtUlcMsgy+S wExH5MU/JIfwtLwoSzmV1YKF63jkto1SUfCeR9ReBIILEB+L3MAzL1KjycGpJYdcnsNKwN neGW2iX8egvNH5i3jj81sY0Hsd8wyDM= X-MC-Unique: O-hmoWDMOs2a-LqAEv92xw-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH] vz: fix vzCapsAddGuestDomain Date: Mon, 29 Nov 2021 17:16:05 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1638202591099100001 There is a stray 'return -1' executed on all code paths. Fixes: c18d9e23fafabcfbb80481e0705931036b8e7331 Signed-off-by: J=C3=A1n Tomko Reviewed-by: Michal Privoznik --- src/vz/vz_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index b47266290c..23b7795035 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -85,8 +85,6 @@ vzCapsAddGuestDomain(virCaps *caps, =20 guest =3D virCapabilitiesAddGuest(caps, ostype, arch, emulator, NULL, 0, NULL); - return -1; - =20 virCapabilitiesAddGuestDomain(guest, virt_type, NULL, NULL, 0, NULL); =20 --=20 2.31.1