bhyve: handle all enum values in switches

[libvirt PATCH] bhyve: handle all enum values in switches

Posted by Ján Tomko 2 years, 3 months ago

Recent commits switched some variables to enums but did not
fix the warnings in the bhyve driver.

Fixes: 0eb42087c7907f43c114cb57b5ff2cf2a52dfea4
Fixes: a1ce98061c9a3f9ced367b2b9a3fe4071930a128
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
Pushed as a build fix.

 src/bhyve/bhyve_command.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c
index af8ec30fe7..f0e47ce232 100644
--- a/src/bhyve/bhyve_command.c
+++ b/src/bhyve/bhyve_command.c
@@ -616,6 +616,7 @@ bhyveBuildFSArgStr(const virDomainDef *def G_GNUC_UNUSED,
         break;
     case VIR_DOMAIN_FS_ACCESSMODE_MAPPED:
     case VIR_DOMAIN_FS_ACCESSMODE_SQUASH:
+    case VIR_DOMAIN_FS_ACCESSMODE_DEFAULT:
     case VIR_DOMAIN_FS_ACCESSMODE_LAST:
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                        _("unsupported filesystem accessmode '%s'"),
@@ -1052,6 +1053,9 @@ virBhyveGetBootDisk(virDomainDef *def)
         case VIR_DOMAIN_BOOT_DISK:
             boot_dev = VIR_DOMAIN_DISK_DEVICE_DISK;
             break;
+        case VIR_DOMAIN_BOOT_FLOPPY:
+        case VIR_DOMAIN_BOOT_NET:
+        case VIR_DOMAIN_BOOT_LAST:
         default:
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                            _("Cannot boot from device %s"),
-- 
2.31.1

Re: [libvirt PATCH] bhyve: handle all enum values in switches

Posted by Tim Wiederhake 2 years, 3 months ago

On Fri, 2022-01-21 at 20:55 +0100, Ján Tomko wrote:
> Recent commits switched some variables to enums but did not
> fix the warnings in the bhyve driver.
> 
> Fixes: 0eb42087c7907f43c114cb57b5ff2cf2a52dfea4
> Fixes: a1ce98061c9a3f9ced367b2b9a3fe4071930a128
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
> Pushed as a build fix.
> 
>  src/bhyve/bhyve_command.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c
> index af8ec30fe7..f0e47ce232 100644
> --- a/src/bhyve/bhyve_command.c
> +++ b/src/bhyve/bhyve_command.c
> @@ -616,6 +616,7 @@ bhyveBuildFSArgStr(const virDomainDef *def
> G_GNUC_UNUSED,
>          break;
>      case VIR_DOMAIN_FS_ACCESSMODE_MAPPED:
>      case VIR_DOMAIN_FS_ACCESSMODE_SQUASH:
> +    case VIR_DOMAIN_FS_ACCESSMODE_DEFAULT:
>      case VIR_DOMAIN_FS_ACCESSMODE_LAST:
>          virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>                         _("unsupported filesystem accessmode '%s'"),
> @@ -1052,6 +1053,9 @@ virBhyveGetBootDisk(virDomainDef *def)
>          case VIR_DOMAIN_BOOT_DISK:
>              boot_dev = VIR_DOMAIN_DISK_DEVICE_DISK;
>              break;
> +        case VIR_DOMAIN_BOOT_FLOPPY:
> +        case VIR_DOMAIN_BOOT_NET:
> +        case VIR_DOMAIN_BOOT_LAST:
>          default:
>              virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>                             _("Cannot boot from device %s"),
Reviewed-by: Tim Wiederhake <twiederh@redhat.com>