From nobody Tue May 7 00:42:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1642794951; cv=none; d=zohomail.com; s=zohoarc; b=PTZpw+SBrtjcd2PrDhrboMwiUvpq3/6Kl5u0khuONywuvDrH9n3tf1lB9d/WzoJbAK6TGrE2RnOrFx/kFSss+qJ7ro3loR7iPaKAKP7IvuCQ5UETjKNBG2SM7izj5U535zATb3DLEDRIwNQjTgU2eByDDPpsoiJ9J5nozstNl2A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642794951; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=tnbxeu/bAwG6r30I5QGAkGm7HLn9oIIwCbq4CwnB+ZY=; b=fYtgTezT+4PqkD5YSny+cSc0obIkbA/E0SME+d8eLjkies+MgXS8ZoZWzXHzw2sTjimdnHPQshgu66mSioHDPqESuahMq8edVR0GhyUDidAH0fXFXLjfjHkN/ZN6IV4lMIBsDyj1sVeaBAoWF29VWYq2r+NJ5x+ga/LsCv1h/vU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1642794951092986.0413427924644; Fri, 21 Jan 2022 11:55:51 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-53-zDbSOoZ-NL-m-xhsOpO-uQ-1; Fri, 21 Jan 2022 14:55:47 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 971188189F9; Fri, 21 Jan 2022 19:55:41 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A05F545D8C; Fri, 21 Jan 2022 19:55:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D91C81809CB9; Fri, 21 Jan 2022 19:55:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20LJtW7n015156 for ; Fri, 21 Jan 2022 14:55:32 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5C6A0101F6D4; Fri, 21 Jan 2022 19:55:32 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.40.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id B5FDE101E819 for ; Fri, 21 Jan 2022 19:55:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642794950; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=tnbxeu/bAwG6r30I5QGAkGm7HLn9oIIwCbq4CwnB+ZY=; b=HscTV4HmDiVEbVUdNpK3ZgyctCzQ+TYC8qLIlZ4YimZ744Cp+X27Fdq4nWCoB4PG3VBYs/ zCKgd4hBqF9TPBXfqGnpfF4AkH4fyHLpIXtWBlK9vDqofpwiYtnJB+9OKBIhebiOtd4LoN nYuzf+jWUQ5npEMkkMSIB5cI8j5csKo= X-MC-Unique: zDbSOoZ-NL-m-xhsOpO-uQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH] bhyve: handle all enum values in switches Date: Fri, 21 Jan 2022 20:55:13 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1642794952893100001 Recent commits switched some variables to enums but did not fix the warnings in the bhyve driver. Fixes: 0eb42087c7907f43c114cb57b5ff2cf2a52dfea4 Fixes: a1ce98061c9a3f9ced367b2b9a3fe4071930a128 Signed-off-by: J=C3=A1n Tomko Reviewed-by: Tim Wiederhake --- Pushed as a build fix. src/bhyve/bhyve_command.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index af8ec30fe7..f0e47ce232 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -616,6 +616,7 @@ bhyveBuildFSArgStr(const virDomainDef *def G_GNUC_UNUSE= D, break; case VIR_DOMAIN_FS_ACCESSMODE_MAPPED: case VIR_DOMAIN_FS_ACCESSMODE_SQUASH: + case VIR_DOMAIN_FS_ACCESSMODE_DEFAULT: case VIR_DOMAIN_FS_ACCESSMODE_LAST: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("unsupported filesystem accessmode '%s'"), @@ -1052,6 +1053,9 @@ virBhyveGetBootDisk(virDomainDef *def) case VIR_DOMAIN_BOOT_DISK: boot_dev =3D VIR_DOMAIN_DISK_DEVICE_DISK; break; + case VIR_DOMAIN_BOOT_FLOPPY: + case VIR_DOMAIN_BOOT_NET: + case VIR_DOMAIN_BOOT_LAST: default: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Cannot boot from device %s"), --=20 2.31.1