build: src: fix libtool dependency issue

[libvirt] [PATCH] build: src: fix libtool dependency issue

Pavel Hrdina posted 1 patch 4 years, 5 months ago

Download mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/e51edcd664224281a69e0c1bbb61d41f7a98663a.1571912081.git.phrdina@redhat.com

src/Makefile.am | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

Expand all Fold all

[libvirt] [PATCH] build: src: fix libtool dependency issue

Posted by Pavel Hrdina 4 years, 5 months ago

Libtool gets a wrong order of arguments of libraries to install and it
fails when installing libvirt-admin.so that libvirt.so is not yet
installed.  Caused by commit <3097282d8668693eb4b7c3fb1b4fe5b474996b9c>.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 src/Makefile.am | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 34dfeeb9f9..ebc24610e2 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -100,6 +100,10 @@ COMMON_UNIT_VARS = \
 	-e 's|[@]sysconfdir[@]|$(sysconfdir)|g' \
 	$(NULL)
 
+# Set these variables before we include any of the subdirs as libvirt-admin.la
+# has to be installed after libvirt.la.
+lib_LTLIBRARIES += libvirt.la libvirt-qemu.la libvirt-lxc.la
+
 include util/Makefile.inc.am
 include conf/Makefile.inc.am
 include cpu/Makefile.inc.am
@@ -146,8 +150,6 @@ SECDRIVER_LIBS += $(APPARMOR_LIBS)
 endif WITH_SECDRIVER_APPARMOR
 
 
-lib_LTLIBRARIES += libvirt.la libvirt-qemu.la libvirt-lxc.la
-
 moddir = $(libdir)/libvirt/connection-driver
 
 confdir = $(sysconfdir)/libvirt
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] build: src: fix libtool dependency issue

Posted by Daniel P. Berrangé 4 years, 5 months ago

On Thu, Oct 24, 2019 at 12:33:20PM +0200, Pavel Hrdina wrote:
> Libtool gets a wrong order of arguments of libraries to install and it
> fails when installing libvirt-admin.so that libvirt.so is not yet
> installed.  Caused by commit <3097282d8668693eb4b7c3fb1b4fe5b474996b9c>.
> 
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  src/Makefile.am | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list