From nobody Fri Apr 26 12:05:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571913483; cv=none; d=zoho.com; s=zohoarc; b=DPKtEsg7e/Sm5EbkBMX+iYfZ/NfEd6mTqETUdpFD1Va6lAwoAQvsaI4PM635bNAwuYDXMwKb3vJrjNMMH3iEBUAtpAMhCAHnRZkLpPxmhRr7wJ071g9JAT5b7sn98TEbyh0H8HcgLBaLbadbomQDT1ukSNYWpFQAOjgyjde5+mI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571913483; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=zT/PknopUJneLthZ1/iJlUpE4o4o6AQUKnJjlfeGMcU=; b=PlMbH5/bGLS8mXTYLxvGH8cI6jhB7uh+uOKUUlVJfXagVLFMfpwk03Joa/LqFUFQS3lKUiEfcXagCW8CpTDBQbsBdXjOij2oE0RG1jJLI9tkyqnrjwhC8kTLP98xdm00Z2JOPg7g+cvNAGG2qNK78tbZTJUUhmwSjh9WPpKX3Us= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1571913483960208.335602280589; Thu, 24 Oct 2019 03:38:03 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-122-5ZbVRbyEPpWCs7_GJM3m5A-1; Thu, 24 Oct 2019 06:33:46 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 08B4D5E4; Thu, 24 Oct 2019 10:33:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D31CE5D6D0; Thu, 24 Oct 2019 10:33:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A809518005A0; Thu, 24 Oct 2019 10:33:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x9OAXOk8026994 for ; Thu, 24 Oct 2019 06:33:24 -0400 Received: by smtp.corp.redhat.com (Postfix) id D0BE45C1D4; Thu, 24 Oct 2019 10:33:24 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-50.brq.redhat.com [10.40.200.50]) by smtp.corp.redhat.com (Postfix) with ESMTP id E08795C1B5 for ; Thu, 24 Oct 2019 10:33:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571913466; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zT/PknopUJneLthZ1/iJlUpE4o4o6AQUKnJjlfeGMcU=; b=QxMdcdYG50t2usBGncNinPRstWXj2LpGC24jaJdIRxINUYkQ76M5wmJGBuXTsgshdjCq4q OLoUdQFnIx5Jw1bBJZT7avqLwNn0yHIILgyKFTTJeY/wc5xHjiaiUG3AGkpx5CvewdzulM 5Q5gF8ApEn1G9G8YTzwFNgZJP+uNS4w= From: Pavel Hrdina To: libvir-list@redhat.com Date: Thu, 24 Oct 2019 12:33:20 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] build: src: fix libtool dependency issue X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: 5ZbVRbyEPpWCs7_GJM3m5A-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Libtool gets a wrong order of arguments of libraries to install and it fails when installing libvirt-admin.so that libvirt.so is not yet installed. Caused by commit <3097282d8668693eb4b7c3fb1b4fe5b474996b9c>. Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- src/Makefile.am | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 34dfeeb9f9..ebc24610e2 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -100,6 +100,10 @@ COMMON_UNIT_VARS =3D \ -e 's|[@]sysconfdir[@]|$(sysconfdir)|g' \ $(NULL) =20 +# Set these variables before we include any of the subdirs as libvirt-admi= n.la +# has to be installed after libvirt.la. +lib_LTLIBRARIES +=3D libvirt.la libvirt-qemu.la libvirt-lxc.la + include util/Makefile.inc.am include conf/Makefile.inc.am include cpu/Makefile.inc.am @@ -146,8 +150,6 @@ SECDRIVER_LIBS +=3D $(APPARMOR_LIBS) endif WITH_SECDRIVER_APPARMOR =20 =20 -lib_LTLIBRARIES +=3D libvirt.la libvirt-qemu.la libvirt-lxc.la - moddir =3D $(libdir)/libvirt/connection-driver =20 confdir =3D $(sysconfdir)/libvirt --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list