[PATCH] qemu_agent: remove unused code

Kristina Hanicova posted 1 patch 2 years, 5 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/d16149db84791f9909e8f82fed7522db7510dc98.1635323615.git.khanicov@redhat.com
There is a newer version of this series
src/qemu/qemu_agent.c | 11 -----------
1 file changed, 11 deletions(-)
[PATCH] qemu_agent: remove unused code
Posted by Kristina Hanicova 2 years, 5 months ago
Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
---
 src/qemu/qemu_agent.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index 5f421be6f6..f7feadd5eb 100644
--- a/src/qemu/qemu_agent.c
+++ b/src/qemu/qemu_agent.c
@@ -237,17 +237,6 @@ qemuAgentIOProcessEvent(qemuAgent *agent,
         return -1;
     }
 
-/*
-    for (i = 0; i < G_N_ELEMENTS(eventHandlers); i++) {
-        if (STREQ(eventHandlers[i].type, type)) {
-            virJSONValue *data = virJSONValueObjectGet(obj, "data");
-            VIR_DEBUG("handle %s handler=%p data=%p", type,
-                      eventHandlers[i].handler, data);
-            (eventHandlers[i].handler)(agent, data);
-            break;
-        }
-    }
-*/
     return 0;
 }
 
-- 
2.31.1

Re: [PATCH] qemu_agent: remove unused code
Posted by Ján Tomko 2 years, 5 months ago
On a Wednesday in 2021, Kristina Hanicova wrote:

Missing commit message.

>Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
>---
> src/qemu/qemu_agent.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
>diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
>index 5f421be6f6..f7feadd5eb 100644
>--- a/src/qemu/qemu_agent.c
>+++ b/src/qemu/qemu_agent.c
>@@ -237,17 +237,6 @@ qemuAgentIOProcessEvent(qemuAgent *agent,
>         return -1;
>     }
>
>-/*
>-    for (i = 0; i < G_N_ELEMENTS(eventHandlers); i++) {
>-        if (STREQ(eventHandlers[i].type, type)) {
>-            virJSONValue *data = virJSONValueObjectGet(obj, "data");
>-            VIR_DEBUG("handle %s handler=%p data=%p", type,
>-                      eventHandlers[i].handler, data);
>-            (eventHandlers[i].handler)(agent, data);
>-            break;
>-        }
>-    }
>-*/

This hunk was introduced by:

commit c160ce3316852a797d7b06b4ee101233866e69a9
CommitDate: 2012-01-24 12:19:51 +0100
     QEMU guest agent support

Which also added the following:

/* When you are the first to uncomment this,
  * don't forget to uncomment the corresponding
  * part in qemuAgentIOProcessEvent as well.
  *
static struct {
     const char *type;
     void (*handler)(qemuAgent *agent, virJSONValue *data);
} eventHandlers[] = {
};
*/

With that deleted as well:

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano

>     return 0;
> }
>
>-- 
>2.31.1
>