[PATCH v2] qemu_agent: remove unused code

Kristina Hanicova posted 1 patch 2 years, 5 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/bded1df103b874e95210af0a6ce4325dc92f92b1.1635332234.git.khanicov@redhat.com
src/qemu/qemu_agent.c | 22 ----------------------
1 file changed, 22 deletions(-)
[PATCH v2] qemu_agent: remove unused code
Posted by Kristina Hanicova 2 years, 5 months ago
This is v2 of: https://listman.redhat.com/archives/libvir-list/2021-October/msg01064.html

Diff to v1:
* I forgot to delete another part of the unused code which
  belonged together (noticed by Jano)

This section of code was left unused ever since it was introduced
ten years ago. I think we can safely remove it.

Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
---
 src/qemu/qemu_agent.c | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index 5f421be6f6..f319b881fc 100644
--- a/src/qemu/qemu_agent.c
+++ b/src/qemu/qemu_agent.c
@@ -60,17 +60,6 @@ VIR_LOG_INIT("qemu.qemu_agent");
  */
 #define QEMU_AGENT_MAX_RESPONSE (10 * 1024 * 1024)
 
-/* When you are the first to uncomment this,
- * don't forget to uncomment the corresponding
- * part in qemuAgentIOProcessEvent as well.
- *
-static struct {
-    const char *type;
-    void (*handler)(qemuAgent *agent, virJSONValue *data);
-} eventHandlers[] = {
-};
-*/
-
 typedef struct _qemuAgentMessage qemuAgentMessage;
 struct _qemuAgentMessage {
     char *txBuffer;
@@ -237,17 +226,6 @@ qemuAgentIOProcessEvent(qemuAgent *agent,
         return -1;
     }
 
-/*
-    for (i = 0; i < G_N_ELEMENTS(eventHandlers); i++) {
-        if (STREQ(eventHandlers[i].type, type)) {
-            virJSONValue *data = virJSONValueObjectGet(obj, "data");
-            VIR_DEBUG("handle %s handler=%p data=%p", type,
-                      eventHandlers[i].handler, data);
-            (eventHandlers[i].handler)(agent, data);
-            break;
-        }
-    }
-*/
     return 0;
 }
 
-- 
2.31.1