[v1] virsh: Add missing TAB completers for several commands

[PATCH 0/6] virsh: Add missing TAB completers for several commands

Radosław Śmigielski via Devel posted 6 patches 5 days, 7 hours ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1783602061.git.rsmigiel@redhat.com

There is a newer version of this series

tools/virsh-completer-domain.c | 49 ++++++++++++++++++++++++++++++++++
tools/virsh-completer-domain.h | 10 +++++++
tools/virsh-domain.c           |  6 +++++
3 files changed, 65 insertions(+)

Expand all Fold all

[PATCH 0/6] virsh: Add missing TAB completers for several commands

Posted by Radosław Śmigielski via Devel 5 days, 7 hours ago

From: Radoslaw Smigielski <rsmigiel@redhat.com>

This series adds missing virsh TAB completion callbacks for six
command options:

  - dump --file
  - blockcopy --dest
  - detach-interface --type
  - domdisplay --type
  - domxml-from-native --format
  - save --file

This is a small step towards closing the missing completers tracked in:
https://gitlab.com/libvirt/libvirt/-/work_items/9

As of now there are 29 missing bash completers, the one fixed in this
patch is first batch.

As some of the patches change only one line, I would apprecate your
feedback if these small one should be combined into a single patch?

Radoslaw Smigielski (6):
  virsh: Add completer for '--file' option of 'dump' subcommand
  virsh: Add completer for '--dest' option of 'blockcopy' command
  virsh: Add completer for '--type' option of 'detach-interface' command
  virsh: Add completer for '--type' option of 'domdisplay' command
  virsh: Add completer for '--format' option of 'domxml-from-native' command
  virsh: Add completer for '--file' option of 'save' command

 tools/virsh-completer-domain.c | 49 ++++++++++++++++++++++++++++++++++
 tools/virsh-completer-domain.h | 10 +++++++
 tools/virsh-domain.c           |  6 +++++
 3 files changed, 65 insertions(+)

-- 
2.54.0