From nobody Tue Jul 14 21:21:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1783602487; cv=none; d=zohomail.com; s=zohoarc; b=gAb8c+ogDLhVWKJTn+XYyvShT/aDDMpHmyBWyBuPAx44f44KXDq/Eqd4LQ5mwKLMcumw33QkVCp2eReqouFZ6MkB/0gr2e7sxYDP68gxAzr7j6pETRT8Uqen/O9IK3BCxzXgoaU0IfS6owRxiOJhg0p8AveF2X4RP0m2QbG01R8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783602487; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=JG9wnEPqQ2Xry10Ihb7HC6bjQVEoUe+UD8D+ixs1mFA=; b=gTGqagqq3IVHkJ1it0U9OggDTlsT4eS9vNeJLbo7+j2lsEVDjSk7beaVtzgxbTUzrZlK1NfP/6mXzGM6iVsvGLSWsTShkIzutfIV7fitnos4StV6fkGMkfKPQV/r48syT1NZI5oiKoPza6W0bmO+yJDIoysAYcKETz66afcQWs8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1783602487841761.5003492833437; Thu, 9 Jul 2026 06:08:07 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 59F8B41B50; Thu, 9 Jul 2026 09:08:05 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 5ABFC41D90; Thu, 9 Jul 2026 09:06:17 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id BED6741A4E; Thu, 9 Jul 2026 09:05:57 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 0944B41B4A for ; Thu, 9 Jul 2026 09:05:56 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-231-aPmd37kPOzW_8lHLCDfcAw-1; Thu, 09 Jul 2026 09:05:55 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6D6C51955F1A for ; Thu, 9 Jul 2026 13:05:54 +0000 (UTC) Received: from rsmigiel-thinkpadx1carbongen11-remote-csb.redhat.com (unknown [10.44.33.224]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F241536F29; Thu, 9 Jul 2026 13:05:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783602356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JG9wnEPqQ2Xry10Ihb7HC6bjQVEoUe+UD8D+ixs1mFA=; b=ClNE9KrQX4J3iPqptn+WwmHVWKTvvy48yRNKI7J3kCTkALMrvdZeSucid6m0wWXyywV8By sW7vlxpINPUar4Vgiv9C3fRh57qobDuwpb4P8zM9yEHKuLL7qhS6RYxeLykk8/dE/Vn6uc zvbNFjypJrJkEHpy4IE0cVAa7cWikU4= X-MC-Unique: aPmd37kPOzW_8lHLCDfcAw-1 X-Mimecast-MFC-AGG-ID: aPmd37kPOzW_8lHLCDfcAw_1783602354 To: devel@lists.libvirt.org Subject: [PATCH 1/6] virsh: Add completer for '--file' option of 'dump' subcommand Date: Thu, 9 Jul 2026 15:00:57 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: uJQmMiRLpAgq4P8ZOPI9SacBAyeZ7ZkJO8tqElq8ADM_1783602354 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: IW7UB2J5G42VUCCQFO5YHCFSOXNM53KG X-Message-ID-Hash: IW7UB2J5G42VUCCQFO5YHCFSOXNM53KG X-MailFrom: rsmigiel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Radoslaw Smigielski X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Rados=C5=82aw_=C5=9Amigielski_via_Devel?= Reply-To: rsmigiel@redhat.com X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1783602490039158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Radoslaw Smigielski The '--file' option of 'dump' command specifies where to store the core dump file. Partially-fixes: https://gitlab.com/libvirt/libvirt/-/work_items/9 Signed-off-by: Radoslaw Smigielski --- tools/virsh-domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index aa4f2a7a481b..f466976931c6 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -5911,6 +5911,7 @@ static const vshCmdOptDef opts_dump[] =3D { .type =3D VSH_OT_STRING, .positional =3D true, .required =3D true, + .completer =3D vshCompletePathLocalExisting, .help =3D N_("where to dump the core") }, VIRSH_COMMON_OPT_LIVE(N_("perform a live core dump if supported")), --=20 2.54.0 From nobody Tue Jul 14 21:21:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1783602544; cv=none; d=zohomail.com; s=zohoarc; b=W7n1dw9tGG+VvbztYqkwwU7fPdMheJ76DKmEUbPWlo8n8YCofEUnX9FnsgfkYPE3pk9WLtLjd6dsCD7leRCBK53PDsjpjj6Qec598wI2PmRKf53YnbJ2a/yp4steU94MamdJ8clrAYM0NJSVl5/Sd1Jdjl6HlSF7t+P5l5pHylc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783602544; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=D+IEuMZeKwn0ECJadJLxu1G6TjqaVxY9Hw+ZVzgjU6M=; b=hBgUNWPMrklVgaHAjrRN25HX5MORlkyAPcGyhblHoUY/P4hmzZoS+bKQMZf2M+8XiOaj6lv6IINgDUVFpNnEjd1Ke7Porl5NBd05fP254WRqlzECETuk39bwYR6NnpQ2NsqyggtRH1I4KsmiKv5u71vRBsErVz9lsAVYWaNXksU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1783602544834757.3731675811532; Thu, 9 Jul 2026 06:09:04 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id A40EA41BB8; Thu, 9 Jul 2026 09:09:03 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 453AA41DD4; Thu, 9 Jul 2026 09:06:26 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 8C04B41B52; Thu, 9 Jul 2026 09:05:58 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id EDEDB41A4E for ; Thu, 9 Jul 2026 09:05:57 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-444-66iKlZwFOEaO4GvX3b2uPg-1; Thu, 09 Jul 2026 09:05:56 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C2BE31955E8F for ; Thu, 9 Jul 2026 13:05:55 +0000 (UTC) Received: from rsmigiel-thinkpadx1carbongen11-remote-csb.redhat.com (unknown [10.44.33.224]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D689536F29; Thu, 9 Jul 2026 13:05:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783602357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D+IEuMZeKwn0ECJadJLxu1G6TjqaVxY9Hw+ZVzgjU6M=; b=YUcXvk96sTZZAnmtmbLi83Es8b4WjfDgypnSr2NlZ914fFXQzXxADG4ID8tPPensnmHfBr m0v98wrcML4oVx9IjCTJ/OQ87ne22P/FjPp2p+yehEPtcRH+t9uGRjQ8ndu32cwvzQfoCe URa+IHLo+UxDU2KuD3l8pWHBGmF+sGc= X-MC-Unique: 66iKlZwFOEaO4GvX3b2uPg-1 X-Mimecast-MFC-AGG-ID: 66iKlZwFOEaO4GvX3b2uPg_1783602355 To: devel@lists.libvirt.org Subject: [PATCH 2/6] virsh: Add completer for '--dest' option of 'blockcopy' command Date: Thu, 9 Jul 2026 15:00:58 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BJ-3pXs4856i0S0aM56JcTMq6iIX8hUvg0cDFo4uawM_1783602355 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: MRGSTVA6MIGGTK57QWIIFX37GCVIWPFQ X-Message-ID-Hash: MRGSTVA6MIGGTK57QWIIFX37GCVIWPFQ X-MailFrom: rsmigiel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Radoslaw Smigielski X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Rados=C5=82aw_=C5=9Amigielski_via_Devel?= Reply-To: rsmigiel@redhat.com X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1783602546526158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Radoslaw Smigielski The '--dest' option of 'blockcopy' command specifies the path of the copy to create. Partially-fixes: https://gitlab.com/libvirt/libvirt/-/work_items/9 Signed-off-by: Radoslaw Smigielski --- tools/virsh-domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index f466976931c6..e6f2ca3a449a 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -2629,6 +2629,7 @@ static const vshCmdOptDef opts_blockcopy[] =3D { {.name =3D "dest", .type =3D VSH_OT_STRING, .unwanted_positional =3D true, + .completer =3D vshCompletePathLocalExisting, .help =3D N_("path of the copy to create") }, {.name =3D "bandwidth", --=20 2.54.0 From nobody Tue Jul 14 21:21:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1783602601; cv=none; d=zohomail.com; s=zohoarc; b=W/J2h8wdlylYLMmvHCvQxo8aFWjPrX59XlIwjwtz337wVIWXaBwK17JyzOp+4AfkqNcPl5s/KYCc9XtqYNURqSMhcsPi2Pxq9OA9QkUm/6QU9v9u6trerJT24emC6cMzOGYb8SQnM5tykw0qvPHgEvzcdZusJW2GMkIKNX8we3s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783602601; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=aLWHDx9TpRyqqQGVVtZe2+0omODp/C9GCLlTe7PV9ic=; b=mglmCG4Rvh6ZcBif8XoqQaHJOUj87H6Pou2xTKzG1g12W4XkraiUMxw7e/rBb9mnGsMV/JGPx7QfKdFuxmjHSU4aw1jCp4vY273q45XAV8aeMRydvQE5VNN+TFhaYbFLwYYKMPOZI/OuJmzVZfoCCseNCzNAwtdoppGWYs0n7hA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1783602601521410.5601641094578; Thu, 9 Jul 2026 06:10:01 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 3163541C4F; Thu, 9 Jul 2026 09:10:00 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 851F041BC1; Thu, 9 Jul 2026 09:06:32 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 51F5941A4E; Thu, 9 Jul 2026 09:06:01 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id F379041A4E for ; Thu, 9 Jul 2026 09:05:59 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-7ZNXWaqFMwSiWEiouMoXOQ-1; Thu, 09 Jul 2026 09:05:58 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2EB7618009DF for ; Thu, 9 Jul 2026 13:05:57 +0000 (UTC) Received: from rsmigiel-thinkpadx1carbongen11-remote-csb.redhat.com (unknown [10.44.33.224]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4497B36933; Thu, 9 Jul 2026 13:05:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783602359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aLWHDx9TpRyqqQGVVtZe2+0omODp/C9GCLlTe7PV9ic=; b=DiW7CFz1KaltZHRtx+25o71mp4XFlfXXf2XbvRz/Sta+yJDam+0dwX5YZviLiL5iz1M2ai nnI+9u8t8T9nQCcT1nIUYX3mGLlK1X6YmN4djuLMqN9xyaSXro+9O6FLtHISGHByRg+GB7 h9IuYnRe3vldMkP7qWPloDqSKIZKY8M= X-MC-Unique: 7ZNXWaqFMwSiWEiouMoXOQ-1 X-Mimecast-MFC-AGG-ID: 7ZNXWaqFMwSiWEiouMoXOQ_1783602357 To: devel@lists.libvirt.org Subject: [PATCH 3/6] virsh: Add completer for '--type' option of 'detach-interface' command Date: Thu, 9 Jul 2026 15:00:59 +0200 Message-ID: <3b7d3c46eaba6e7f6d2e0fc51503003a273a79b5.1783602062.git.rsmigiel@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: --FIgwbQUEqIxQsfHT4_WqXbKB6sIGA46W8_aC3bUOc_1783602357 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: C4CPW7ZOI6PK5TH7CBJ33TNF2KJI3JDE X-Message-ID-Hash: C4CPW7ZOI6PK5TH7CBJ33TNF2KJI3JDE X-MailFrom: rsmigiel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Radoslaw Smigielski X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Rados=C5=82aw_=C5=9Amigielski_via_Devel?= Reply-To: rsmigiel@redhat.com X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1783602603031158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Radoslaw Smigielski The '--type' option of 'detach-interface' command specifies the network interface type to detach. Partially-fixes: https://gitlab.com/libvirt/libvirt/-/work_items/9 Signed-off-by: Radoslaw Smigielski Reviewed-by: Peter Krempa --- tools/virsh-domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index e6f2ca3a449a..79823072ad26 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -12785,6 +12785,7 @@ static const vshCmdOptDef opts_detach_interface[] = =3D { {.name =3D "type", .type =3D VSH_OT_STRING, .positional =3D true, + .completer =3D virshDomainNetTypeCompleter, .help =3D N_("network interface type") }, {.name =3D "mac", --=20 2.54.0 From nobody Tue Jul 14 21:21:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1783602668; cv=none; d=zohomail.com; s=zohoarc; b=d322gCoXwyDUo/uxkOP70E36bvVV7NbPVTiys7GE8CUM59WNSF9AO3qZ8hY/7Q3/qXsA48+T8GlSKllPgfHUqDO6cYMu+jAXnWOtc5a2aV5psCByuqf+xp8lzJ9Va9XANeCrHgZps7U6VmigqdCqoR5n4FcEtPdkaQP9rgCVADU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783602668; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=7Mn6SlPBAmAJo06kuN+hpTvsrVrQHpzGEiu1+wnfog0=; b=bFn7HjNIK8/xNeIXvJVALq3lcrikf5KcAULXKZsgfX6x/lVhNsTqwOMVQDtbkdTT0EQY6CetGmMZCPmUK8KVL84R3TVA91AsatwT0IvKqPuO9Uu20quAXgiEj8yNJ9G8UKLOiUX3YTPqaLzY0oPfOz3tCplGD5VqBRa+uH3ZqAk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1783602668906756.5001850496027; Thu, 9 Jul 2026 06:11:08 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id BE3C641CD0; Thu, 9 Jul 2026 09:11:07 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id D773241E4C; Thu, 9 Jul 2026 09:06:36 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id A15FE41BC0; Thu, 9 Jul 2026 09:06:08 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3854641BA5 for ; Thu, 9 Jul 2026 09:06:00 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138-nL-48XaEPOWL7JOF55B8Jw-1; Thu, 09 Jul 2026 09:05:59 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 978A5195606A for ; Thu, 9 Jul 2026 13:05:58 +0000 (UTC) Received: from rsmigiel-thinkpadx1carbongen11-remote-csb.redhat.com (unknown [10.44.33.224]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A9F5336933; Thu, 9 Jul 2026 13:05:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783602360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Mn6SlPBAmAJo06kuN+hpTvsrVrQHpzGEiu1+wnfog0=; b=cxVwzdN7kloyq67zn7fFJ8Sr01Ia4X77sU9QV4u/NkDr95IsNlm6KvDD6ieq6u0ycIrxCw mqZ7h6xXKJ85mDEuumfdPsuINLtzKHI8F62YYwSOOux+R0O32sQvsoAAaZfuutsjqUI9tz BKicKUvjA45CfNEHAbFiZBfSS+ZS9vQ= X-MC-Unique: nL-48XaEPOWL7JOF55B8Jw-1 X-Mimecast-MFC-AGG-ID: nL-48XaEPOWL7JOF55B8Jw_1783602358 To: devel@lists.libvirt.org Subject: [PATCH 4/6] virsh: Add completer for '--type' option of 'domdisplay' command Date: Thu, 9 Jul 2026 15:01:00 +0200 Message-ID: <40b6c8d1b52f7097988fa05206ed74ff58a710b7.1783602062.git.rsmigiel@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: A6a9tJMG6vigJNixH9x-VZQs_K5K8IFTOcNvI7Cq_kA_1783602358 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CQUXFUZERSZ5KI3CWCZAVQJ7NE2EP64U X-Message-ID-Hash: CQUXFUZERSZ5KI3CWCZAVQJ7NE2EP64U X-MailFrom: rsmigiel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Radoslaw Smigielski X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Rados=C5=82aw_=C5=9Amigielski_via_Devel?= Reply-To: rsmigiel@redhat.com X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1783602669709158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Radoslaw Smigielski The '--type' option of 'domdisplay' command selects a particular graphical display scheme (vnc, spice, rdp, or dbus). Partially-fixes: https://gitlab.com/libvirt/libvirt/-/work_items/9 Signed-off-by: Radoslaw Smigielski --- tools/virsh-completer-domain.c | 13 +++++++++++++ tools/virsh-completer-domain.h | 5 +++++ tools/virsh-domain.c | 1 + 3 files changed, 19 insertions(+) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index 8bdf68ac091d..4c0ddb01d855 100644 --- a/tools/virsh-completer-domain.c +++ b/tools/virsh-completer-domain.c @@ -1132,3 +1132,16 @@ virshDomainNetTypeCompleter(vshControl *ctl G_GNUC_U= NUSED, return vshEnumComplete(VIR_DOMAIN_NET_TYPE_LAST, virDomainNetTypeToString); } + + +char ** +virshDomainDisplayTypeCompleter(vshControl *ctl G_GNUC_UNUSED, + const vshCmd *cmd G_GNUC_UNUSED, + unsigned int flags) +{ + static const char *types[] =3D {"vnc", "spice", "rdp", "dbus", NULL}; + + virCheckFlags(0, NULL); + + return vshCommaStringListComplete(NULL, types); +} diff --git a/tools/virsh-completer-domain.h b/tools/virsh-completer-domain.h index dfbc10acaaa8..3aab7bedae20 100644 --- a/tools/virsh-completer-domain.h +++ b/tools/virsh-completer-domain.h @@ -204,3 +204,8 @@ char ** virshDomainNetTypeCompleter(vshControl *ctl, const vshCmd *cmd, unsigned int flags); + +char ** +virshDomainDisplayTypeCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags); diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 79823072ad26..a546532b7dd2 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -12181,6 +12181,7 @@ static const vshCmdOptDef opts_domdisplay[] =3D { {.name =3D "type", .type =3D VSH_OT_STRING, .positional =3D true, + .completer =3D virshDomainDisplayTypeCompleter, .help =3D N_("select particular graphical display " "(e.g. \"vnc\", \"spice\", \"rdp\", \"dbus\")") }, --=20 2.54.0 From nobody Tue Jul 14 21:21:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1783602730; cv=none; d=zohomail.com; s=zohoarc; b=eNbv1hMSMXWofC+zWym356wUmRwe6mJafUpU64nUsbhC28mmCSqrZkX4PnCdXF6ugD/CFRXq7aznJCS7W503ncMTIq1T7loIJz/tXUIHolGerS8fi/P5salegwHn6mf1NfQUdpNy5fjbSs7bNnBUQ89qVaiWNyICsP9yZyas6p4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783602730; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=/SfMlIRmjBhJsJ8Fqq/P0mEAwxMQMqh6kaqiGSK1LGA=; b=OAmS55fhb5dJgID7fnJok1F8oFgMRewTwQeoflAJhhlnCh3ArBb1Vi2adslndo7OzKs+8Hno4rfetsgIIKxRdkKbvmt+2tVmIR7UmZ60wf8irfksF56mEr+tN95vhKTAQCMRJDDa3Z88hKAT0cc2rVMQDy63/zNT+vz0nynMTO4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1783602730340951.2826030579739; Thu, 9 Jul 2026 06:12:10 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 24D4F41B4A; Thu, 9 Jul 2026 09:12:08 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 03AD942401; Thu, 9 Jul 2026 09:06:41 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id F254641D8D; Thu, 9 Jul 2026 09:06:15 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C3D5241C5A for ; Thu, 9 Jul 2026 09:06:02 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-19-ePCflPUCPZGNAD6sG0z1tw-1; Thu, 09 Jul 2026 09:06:00 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0D66E1955F19 for ; Thu, 9 Jul 2026 13:06:00 +0000 (UTC) Received: from rsmigiel-thinkpadx1carbongen11-remote-csb.redhat.com (unknown [10.44.33.224]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1E9D436933; Thu, 9 Jul 2026 13:05:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783602362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/SfMlIRmjBhJsJ8Fqq/P0mEAwxMQMqh6kaqiGSK1LGA=; b=G9xyB5rC8uVOoQRGh3NnFSIT5/EG/c15VxU/lMefpfbFWpxZi7Jz3Jwh2zDGmWGhLHM4LY F4I2Icu3PpnHNRxoijINIlSUuBs0c47NsTj+R3ofLUY6EGXlS8DWZYPkQRMu7fPrRnoXEc IneuMGWIykb1Ec0T54RWB8KGmMtKE40= X-MC-Unique: ePCflPUCPZGNAD6sG0z1tw-1 X-Mimecast-MFC-AGG-ID: ePCflPUCPZGNAD6sG0z1tw_1783602360 To: devel@lists.libvirt.org Subject: [PATCH 5/6] virsh: Add completer for '--format' option of 'domxml-from-native' command Date: Thu, 9 Jul 2026 15:01:01 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oeXvi7UegLKw5dz7swt7gXh4a31pwBgjfkYQL6Tcmbg_1783602360 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: L4FEUYAZAQSK6JMHBERLJODGZAKBAXXO X-Message-ID-Hash: L4FEUYAZAQSK6JMHBERLJODGZAKBAXXO X-MailFrom: rsmigiel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Radoslaw Smigielski X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Rados=C5=82aw_=C5=9Amigielski_via_Devel?= Reply-To: rsmigiel@redhat.com X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1783602732297158501 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Radoslaw Smigielski The '--format' option of 'domxml-from-native' command specifies the native guest configuration format to import. Partially-fixes: https://gitlab.com/libvirt/libvirt/-/work_items/9 Signed-off-by: Radoslaw Smigielski --- tools/virsh-completer-domain.c | 36 ++++++++++++++++++++++++++++++++++ tools/virsh-completer-domain.h | 5 +++++ tools/virsh-domain.c | 1 + 3 files changed, 42 insertions(+) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index 4c0ddb01d855..8154ba8d622c 100644 --- a/tools/virsh-completer-domain.c +++ b/tools/virsh-completer-domain.c @@ -1145,3 +1145,39 @@ virshDomainDisplayTypeCompleter(vshControl *ctl G_GN= UC_UNUSED, =20 return vshCommaStringListComplete(NULL, types); } + + +char ** +virshDomainXMLNativeFormatCompleter(vshControl *ctl, + const vshCmd *cmd G_GNUC_UNUSED, + unsigned int flags) +{ + virshControl *priv =3D ctl->privData; + const char *hvType =3D NULL; + const char **formats =3D NULL; + static const char *xenFormats[] =3D {"xen-xl", "xen-xm", NULL}; + static const char *lxcFormats[] =3D {"lxc-tools", NULL}; + static const char *vmxFormats[] =3D {"vmware-vmx", NULL}; + static const char *bhyveFormats[] =3D {"bhyve-argv", NULL}; + + virCheckFlags(0, NULL); + + if (!priv->conn || virConnectIsAlive(priv->conn) <=3D 0) + return NULL; + + if (!(hvType =3D virConnectGetType(priv->conn))) + return NULL; + + if (STREQ(hvType, "Xen")) + formats =3D xenFormats; + else if (STREQ(hvType, "LXC")) + formats =3D lxcFormats; + else if (STREQ(hvType, "VMware") || STREQ(hvType, "ESX")) + formats =3D vmxFormats; + else if (STREQ(hvType, "BHYVE")) + formats =3D bhyveFormats; + else + return NULL; + + return vshCommaStringListComplete(NULL, formats); +} diff --git a/tools/virsh-completer-domain.h b/tools/virsh-completer-domain.h index 3aab7bedae20..40de90afb79f 100644 --- a/tools/virsh-completer-domain.h +++ b/tools/virsh-completer-domain.h @@ -209,3 +209,8 @@ char ** virshDomainDisplayTypeCompleter(vshControl *ctl, const vshCmd *cmd, unsigned int flags); + +char ** +virshDomainXMLNativeFormatCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags); diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index a546532b7dd2..abe3d0b3451e 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -10916,6 +10916,7 @@ static const vshCmdOptDef opts_domxmlfromnative[] = =3D { .type =3D VSH_OT_STRING, .positional =3D true, .required =3D true, + .completer =3D virshDomainXMLNativeFormatCompleter, .help =3D N_("source config data format") }, {.name =3D "config", --=20 2.54.0 From nobody Tue Jul 14 21:21:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1783602788; cv=none; d=zohomail.com; s=zohoarc; b=NUi5XGYpLiEUESyMevQZpx7eeTlkCj2YA5zs4UMWlyraIbbqIcH+5scrK2geVLb5sIWyBBUzDVt4NSNHjH+2LYHDEM7ZSMd+3Oi9zYKhGEO16wvUwBneqmUIRjGVrO+8WMDlAbDqJX3TTbIsTGX/qMZnqadh3z4ZoBHL73uvVjU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783602788; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=F6sx3aqaiHG1bwUdDmVT1Y2XAyBDiVgb68gSggp/jms=; b=HWlaostyjq2t62ylK2uDlLtVMiAVWD5eWxc/yXpH275QUdVax3E2tsa+wmLhNXcGv/iwz+6CFb8Qzj1h8xuNzjN3i6zFKKaSJ1GzsvnCZ9Kwo33MZOv7lZmdNNu63HflbtPGqQJOlZuNzFqVPYWabiB0QrN6DekHthlchVARCnw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1783602788799956.8212729036636; Thu, 9 Jul 2026 06:13:08 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id BB5A041AA9; Thu, 9 Jul 2026 09:13:07 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 1D52F43DE7; Thu, 9 Jul 2026 09:06:47 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 94AF041CBB; Thu, 9 Jul 2026 09:06:19 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B298041CBB for ; Thu, 9 Jul 2026 09:06:03 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-260-Yeg7l-7VMaaIQLPSqgc6lg-1; Thu, 09 Jul 2026 09:06:02 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6242119560B7 for ; Thu, 9 Jul 2026 13:06:01 +0000 (UTC) Received: from rsmigiel-thinkpadx1carbongen11-remote-csb.redhat.com (unknown [10.44.33.224]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7648936933; Thu, 9 Jul 2026 13:06:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783602363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F6sx3aqaiHG1bwUdDmVT1Y2XAyBDiVgb68gSggp/jms=; b=DDbuEk43YHvpOXzD6QsHXZ1kr+nW0FYJUYtQcmSZZQIQWbfnzr1wy66T9xJzfpi9WAjxfU tjH/NKY/s9xpTpUampJIhTQZyixSaBogZXHul0VujXEIo9hY12mvPGJkFyY7AIuiRx21zA J5/+RgaHsAHeeJYRA2v+KeNM404BGKg= X-MC-Unique: Yeg7l-7VMaaIQLPSqgc6lg-1 X-Mimecast-MFC-AGG-ID: Yeg7l-7VMaaIQLPSqgc6lg_1783602361 To: devel@lists.libvirt.org Subject: [PATCH 6/6] virsh: Add completer for '--file' option of 'save' command Date: Thu, 9 Jul 2026 15:01:02 +0200 Message-ID: <9e3c9e31a9758a318bf6f1018be5bdb319f4d77b.1783602062.git.rsmigiel@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ig3dcrCSy0lo7SrdIBm7KJvSW2TrAa0P_KVdIcfqLMM_1783602361 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KOJBL6GXOIN27MUFIOUPA6E6WHSKOMMW X-Message-ID-Hash: KOJBL6GXOIN27MUFIOUPA6E6WHSKOMMW X-MailFrom: rsmigiel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Radoslaw Smigielski X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Rados=C5=82aw_=C5=9Amigielski_via_Devel?= Reply-To: rsmigiel@redhat.com X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1783602790773158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Radoslaw Smigielski The '--file' option of 'save' command specifies where to store the saved domain state. Partially-fixes: https://gitlab.com/libvirt/libvirt/-/work_items/9 Signed-off-by: Radoslaw Smigielski --- tools/virsh-domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index abe3d0b3451e..56066edc5b31 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -4652,6 +4652,7 @@ static const vshCmdOptDef opts_save[] =3D { .type =3D VSH_OT_STRING, .positional =3D true, .required =3D true, + .completer =3D vshCompletePathLocalExisting, .help =3D N_("where to save the data") }, {.name =3D "bypass-cache", --=20 2.54.0